gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
126,609 Commits 12 Branches 481 Tags 2.4 GiB
c94657bf77
Commit Graph

75 Commits

Author SHA1 Message Date
Kamil Tekiela
c94657bf77 Use empty string as sentinel instead of false 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-12 12:36:55 +01:00
Maurício Meneghini Fauth
a256228264
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-08 17:09:46 -03:00
Maurício Meneghini Fauth
5ed8e65b90
Fix list of users of an user group not showing up 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-08 16:56:47 -03:00
Maurício Meneghini Fauth
86ea50336b
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-07 18:13:26 -03:00
Maurício Meneghini Fauth
6875680de9
Fix double encoding on User Groups pages 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-07 17:52:26 -03:00
Kamil Tekiela
82427ce600 Update psalm-baseline.xml 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-03 15:25:05 +01:00
Maurício Meneghini Fauth
e104f66d97
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-11 15:46:30 -03:00
William Desportes
4cec0f1163
Stop pmadb database detection when all features are disabled 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-04-08 13:42:44 +02:00
Maurício Meneghini Fauth
656474179d
Merge pull request #18318 from kamil-tekiela/refactor-relation 
Refactor relation
 2023-04-05 10:43:03 -03:00
Maurício Meneghini Fauth
9d844613d0
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-05 10:24:00 -03:00
Kamil Tekiela
357680474e Memoize Relation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-04 11:59:29 +01:00
Kamil Tekiela
e7717ed186 Fix bug preventing disabling tracking feature 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-03 12:22:31 +01:00
Kamil Tekiela
9fcafd2504 Improve method name 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-02 23:50:46 +01:00
Kamil Tekiela
cd9ca8419a Use array_fill_keys 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-02 23:38:25 +01:00
Kamil Tekiela
49cb7e89b2 Invert the logic to make it easier to understand 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-02 23:38:25 +01:00
Kamil Tekiela
aef2a96012 Move getDefaultPmaTableNames out of the loop 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-02 23:38:24 +01:00
Kamil Tekiela
850e867136 Extract getTableReplacementNames 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-02 22:08:07 +01:00
Maurício Meneghini Fauth
6a2c12bdc8
Add missing traversable type hints 
Replace array type hint with mixed[] type hint, since it means the same.
This way it's possible to require traversable type hint for new code.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-02 01:32:12 -03:00
Maurício Meneghini Fauth
dd885dc7b8
Use single-line arrays when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-27 17:39:17 -03:00
Maurício Meneghini Fauth
e5698c85e9
Require single line for function calls 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-26 23:10:10 -03:00
Maurício Meneghini Fauth
437215cab2
Rename variables to use camel case format 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-26 21:47:50 -03:00
Kamil Tekiela
3ecf14df34 Fixing erroneous params 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 12:47:43 +00:00
Kamil Tekiela
3774c29604 Fix implicit nulls 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 12:45:18 +00:00
Kamil Tekiela
555c6798eb Add native param types 
Includes TypeHints.UnionTypeHintFormat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 12:45:18 +00:00
Kamil Tekiela
a6cfa894be Use quoteString in UserGroups 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-02 21:47:16 +00:00
Kamil Tekiela
0bdcaba2d2
Add native property types (#18143) 
* Add native property types

Includes TypeHints.UnionTypeHintFormat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Set some default values for properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Format and promote properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant asserts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $tmanager->theme is never null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix empty on $statementInfo bool

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant issets

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getPacked() returns nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant if

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $this->content can be null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify ThemeManager::getInstance()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use isset for checking if property is initialized

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use nullable instead of uninitialized property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* password is no longer nullable

I can't verify that none of the globals ever tried to set it to null, but the variable should never be nullable.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $same_wide_width param can be float or int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update Message.php

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast Sub_part to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix one line doc comments

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-26 23:30:41 -03:00
Maurício Meneghini Fauth
556594b4cd
Fix coding standard spacing issues 
- Fixes one line doc comments
- Fixes parent call spacing
- Fixes constant spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 21:06:17 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 20:48:46 -03:00
Kamil Tekiela
e8c5eef6f8
Remove annoying empty statements (#18114) 
* Remove annoying empty statements

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Make $extra strict and stop passing false to it

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Make $page strict and stop passing null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-24 20:11:37 -03:00
Kamil Tekiela
902d1a1e77
Add native return type hints (#18126) 
* Add remaining native return type hints to flush out bugs

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast the mixed value to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getAutoIncrement() is supposed to return string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast values to string in DummyResult

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Make getCollation() return non-nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast seqInIndex to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast $cardinality to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* createFile may return false

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-23 15:43:36 -03:00
Kamil Tekiela
912f179432 Add Connection::TYPE_CONTROL to quoteString 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-21 22:36:01 +00:00
Maurício Meneghini Fauth
07af9572ea
Use constructor prop promotion for RelationParameters class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-21 18:51:25 -03:00
Maurício Meneghini Fauth
1ffd881fb4
Refactor ConfigStorage\RelationCleanup::user() 
- Replaces escapeString() with quoteString()

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-21 18:22:39 -03:00
Maurício Meneghini Fauth
b4f9063ceb
Refactor ConfigStorage\RelationCleanup::database() 
- Replaces escapeString() with quoteString()

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-21 17:54:20 -03:00
Maurício Meneghini Fauth
bddaa399af
Refactor ConfigStorage\RelationCleanup::table() 
- Replaces escapeString() with quoteString()

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-21 17:19:10 -03:00
Maurício Meneghini Fauth
c4a5440cf0
Refactor ConfigStorage\RelationCleanup::column() 
- Replaces escapeString() with quoteString()

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-21 15:51:24 -03:00
Maurício Meneghini Fauth
0ba371f921
Refactor ConfigStorage\UserGroups::delete() 
- Extracts dbi global variable
- Replaces escapeString with quoteString

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-21 14:40:25 -03:00
Maurício Meneghini Fauth
47846068fa
Remove some useless comments 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 23:45:06 -03:00
Maurício Meneghini Fauth
4ff3724c3f
Use union with null instead of short nullable type 
Since union type are now possible, using union with null makes more
clear that it is a union type.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 21:48:19 -03:00
Maurício Meneghini Fauth
785f8c1c00
Use constructor property promotion where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 19:39:02 -03:00
Maurício Meneghini Fauth
b0bc4f460e
Use null safe object operator where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 18:21:56 -03:00
Kamil Tekiela
80c4db7253 Use strict check when type is known 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-19 23:19:54 +00:00
Kamil Tekiela
cfe54a501b Add union types 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-15 15:23:28 +00:00
Kamil Tekiela
8433f66447 Remove unused variable in catch 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-14 12:10:23 +00:00
Kamil Tekiela
98cfc64667 Remove escapeString from Relation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-10 16:32:00 -03:00
Maurício Meneghini Fauth
41dec1effc
Extract connection type constants to the Connection class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-01-17 02:21:27 -03:00
Kamil Tekiela
9a8dc40ae9 Remove usage of elvis operator 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-20 19:50:58 +00:00
Kamil Tekiela
3b49a5bedb Implement quoteString() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-06 19:06:48 +00:00
Kamil Tekiela
2c416128e5 Pass as argument to Table 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-17 22:30:33 +01:00
Maurício Meneghini Fauth
e453c57fb8
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-17 16:24:34 -03:00