Commit Graph

1500 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
8bbb1edbea
Remove ThemeManager::getInstance() method
Remove singleton from the Theme\ThemeManager class and uses DI where
possible.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-09 21:29:49 -03:00
William Desportes
b5899c2d53
Merge branch 'QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-05-06 11:25:42 +02:00
Liviu-Mihail Concioiu
4951bc7fea Update CVE link with the new one
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2023-05-06 01:06:11 +02:00
William Desportes
66f607c608
Merge branch 'QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-05-04 22:30:56 +02:00
Kamil Tekiela
a01eefc4c2 Remove $timestampSeen which was always false
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-23 11:20:05 +01:00
Kamil Tekiela
36481a0dca Change if into its short form
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-23 11:20:05 +01:00
Kamil Tekiela
ae5b5a1a86 Remove $jsvkey and $vkey
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-23 11:20:05 +01:00
Kamil Tekiela
fbb185e7a9 Remove globals
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-23 11:20:05 +01:00
Kamil Tekiela
9124c19539 Remove $GLOBALS['columns_cnt']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-23 11:20:05 +01:00
Kamil Tekiela
bfe1f4facf Remove redundant argument
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-23 11:20:05 +01:00
Kamil Tekiela
b2357568a1 Use str_ends_with and str_starts_with
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-23 11:20:05 +01:00
Kamil Tekiela
269535a7a5 Change $tabindex into a private property
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-23 11:20:05 +01:00
Kamil Tekiela
a8070b5498 $tabindexForValue was always 0
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-23 11:20:05 +01:00
Kamil Tekiela
62459b33e5 Change RW param into a private property
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-23 11:20:05 +01:00
Kamil Tekiela
747941ece1 Move $returnToSqlQuery out of the method
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-23 11:20:04 +01:00
William Desportes
99881debb5
Fix lint route not working correctly
Related to 5a2baf607f
Related to https://github.com/phpmyadmin/sql-parser/pull/438

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-04-22 14:52:35 +02:00
Kamil Tekiela
5cd6c16684 Instead of returning array, use array cast
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-20 16:53:19 +01:00
Kamil Tekiela
25b24966c1 Move getParamsForUpdateOrInsert into controller
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-20 16:53:19 +01:00
Kamil Tekiela
a852acb3e9 Move $isInsertignore out of getParamsForUpdateOrInsert
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-20 16:53:19 +01:00
Kamil Tekiela
56d1eed358 Remove MAX_FILE_SIZE
This is not used anywhere in frontend or backend.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-20 16:53:19 +01:00
Kamil Tekiela
8367af19be Remove unused $biggestMaxFileSize param
Not sure if it should have been a global, but judging by the rest of the code, I believe it's no longer needed.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-20 16:53:19 +01:00
Kamil Tekiela
9800c3574f Move urlParamsInEditMode to ChangeController
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-20 16:53:18 +01:00
Maurício Meneghini Fauth
45c7d30093
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-12 16:38:00 -03:00
Maurício Meneghini Fauth
3e7cf7cfab
Fix failing RelationTest test
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-12 16:35:28 -03:00
Maurício Meneghini Fauth
8c7c87f524
Merge pull request #18308 from win20/navigation-panel-settings-icon-issues
Fix issues with settings icon in nav panel
2023-04-12 16:17:48 -03:00
Evgeny Skorlov
4530585ad3
Replace superglobals with serverrequest in controllers
Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-12 15:49:31 -03:00
Maurício Meneghini Fauth
514ed287c6
Merge pull request #18328 from MoonE/fieldmetadata
Refactor DbiDummy and improve FieldMetadata
2023-04-12 14:13:20 -03:00
Maurício Meneghini Fauth
4c15ace946
Merge pull request #18327 from kamil-tekiela/More-Tracking-refactoring
More tracking refactoring
2023-04-12 11:10:00 -03:00
Maurício Meneghini Fauth
e104f66d97
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-11 15:46:30 -03:00
Maurício Meneghini Fauth
eb3ba7831b
Merge pull request #18326 from MauricioFauth/jqplot-chart-js
Replace jqPlot with Chart.js in /server/status/queries
2023-04-10 11:59:30 -03:00
Maurício Meneghini Fauth
7f1cddaf33
Merge pull request #18335 from kamil-tekiela/18332
Fix boolean condition
2023-04-09 18:59:30 -03:00
Kamil Tekiela
5d0de52112 Fix boolean condition
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-08 22:58:50 +01:00
Kamil Tekiela
bca265b82b Cast POST values to expected types
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-08 22:27:24 +01:00
MoonE
0ff3f10134
Fix editing GEOMETRYCOLLECTION EMPTY (#18189)
* Test editing empty geometry collection

- 'GEOMETRYCOLLECTION()'
- 'GEOMETRYCOLLECTION EMPTY'

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>

* Fix editing GEOMETRYCOLLECTION EMPTY

Instead of searching for first parenthesis look for word end.
Parsing was and is somewhat unsafe, though it works with the data
received from ST_AsText.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>

---------

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-04-08 15:12:40 -03:00
William Desportes
4cec0f1163
Stop pmadb database detection when all features are disabled
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-04-08 13:42:44 +02:00
Maximilian Krög
abf49ce9d4
Bettery types for DbiDummy / DummyResult
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-04-07 21:47:07 +02:00
Maximilian Krög
3228a19c2d
Improve FieldMetadata
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-04-07 21:46:19 +02:00
Kamil Tekiela
0be1d58b62 Move the code around
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-07 13:46:26 +01:00
Kamil Tekiela
ed586ac9cb Remove report_export param
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-07 13:46:26 +01:00
Kamil Tekiela
a89cedbed9 Fix bug introduced cca381a
cca381a415

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-07 13:46:26 +01:00
Kamil Tekiela
8e88585f69 Merge if statements
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-07 13:46:26 +01:00
Kamil Tekiela
74a0c26129 Create DTO for TrackedData
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-07 13:46:26 +01:00
Maurício Meneghini Fauth
62d16a07ee
Replace jqPlot with Chart.js in /server/status/queries
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-06 18:52:43 -03:00
Kamil Tekiela
ce35872738 Reload data instead of modifying in place
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-06 00:01:11 +01:00
Kamil Tekiela
57f4fa7583 Remove $GLOBALS['msg']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-06 00:01:11 +01:00
Kamil Tekiela
62bd41870f Remove $GLOBALS['entries']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-06 00:00:49 +01:00
Kamil Tekiela
4f0a618187 Remove useless assignment
Psalm incorrectly complains.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

sa
2023-04-06 00:00:49 +01:00
Kamil Tekiela
15885ea495 Remove $GLOBALS['filter_users']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-05 17:34:46 +01:00
Kamil Tekiela
711cb95264 Remove $_POST
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-05 17:25:05 +01:00
Kamil Tekiela
bca99f1e4d Remove deleteTrackingReportRows()
It's a hyperlink so it can't be both.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-05 17:05:50 +01:00