gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
126,609 Commits 12 Branches 481 Tags 2.4 GiB
c94657bf77
Commit Graph

528 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
624126edc8
Redesign the database and table privileges pages 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-08 21:04:44 -03:00
William Desportes
5775005692
Fix LintControllerTest 
Probably due to sql-parser changes

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-05-04 22:32:44 +02:00
Maurício Meneghini Fauth
250a32b795 Add the Config::getCurrentServer() method 
The Config::getCurrentServer() method returns the current server
configuration. It's an VO that is equivalent to
$GLOBALS['cfg']['Server'] setting.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-30 17:37:34 -03:00
Maurício Meneghini Fauth
aa119f7e62 Remove unused Config::$defaultServer property 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-30 13:23:27 -03:00
Kamil Tekiela
25b24966c1 Move getParamsForUpdateOrInsert into controller 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-20 16:53:19 +01:00
Kamil Tekiela
9800c3574f Move urlParamsInEditMode to ChangeController 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-20 16:53:18 +01:00
Evgeny Skorlov
4530585ad3
Replace superglobals with serverrequest in controllers 
Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-12 15:49:31 -03:00
Maurício Meneghini Fauth
514ed287c6
Merge pull request #18328 from MoonE/fieldmetadata 
Refactor DbiDummy and improve FieldMetadata
 2023-04-12 14:13:20 -03:00
Maurício Meneghini Fauth
3cd57dcf2c
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-11 23:05:50 -03:00
Maurício Meneghini Fauth
d464a8d081
Fix GisDataEditorControllerTest namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-11 23:03:24 -03:00
Maurício Meneghini Fauth
e104f66d97
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-11 15:46:30 -03:00
MoonE
0ff3f10134
Fix editing GEOMETRYCOLLECTION EMPTY (#18189) 
* Test editing empty geometry collection

- 'GEOMETRYCOLLECTION()'
- 'GEOMETRYCOLLECTION EMPTY'

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>

* Fix editing GEOMETRYCOLLECTION EMPTY

Instead of searching for first parenthesis look for word end.
Parsing was and is somewhat unsafe, though it works with the data
received from ST_AsText.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>

---------

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-04-08 15:12:40 -03:00
Maximilian Krög
abf49ce9d4
Bettery types for DbiDummy / DummyResult 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-04-07 21:47:07 +02:00
Maximilian Krög
3228a19c2d
Improve FieldMetadata 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-04-07 21:46:19 +02:00
Maurício Meneghini Fauth
62d16a07ee
Replace jqPlot with Chart.js in /server/status/queries 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-06 18:52:43 -03:00
Kamil Tekiela
357680474e Memoize Relation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-04 11:59:29 +01:00
Maurício Meneghini Fauth
dd885dc7b8
Use single-line arrays when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-27 17:39:17 -03:00
Maurício Meneghini Fauth
e5698c85e9
Require single line for function calls 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-26 23:10:10 -03:00
Maurício Meneghini Fauth
437215cab2
Rename variables to use camel case format 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-26 21:47:50 -03:00
Maurício Meneghini Fauth
c7855f6e95
Create the PhpMyAdmin\Replication namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-20 14:16:01 -03:00
Kamil Tekiela
8eb023bcce Remove last public use of Tracker::isTracked 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 22:36:25 +00:00
Kamil Tekiela
938dd6f7f8 Remove getSqlResultForSelectableTables 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 22:36:25 +00:00
Kamil Tekiela
924fcc79f9 Refactor logic for getting Tracking status 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 22:36:21 +00:00
Kamil Tekiela
c0b367cc57 Create Tracking namespace 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 22:35:32 +00:00
Maurício Meneghini Fauth
f13bd41bac
Merge pull request #18247 from kamil-tekiela/Native-param-types 
Native param types
 2023-03-17 17:52:45 -03:00
Kamil Tekiela
8a5ce0b557 Split long lines 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 12:48:12 +00:00
Kamil Tekiela
3ecf14df34 Fixing erroneous params 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 12:47:43 +00:00
Maximilian Krög
79ab3dfe11
Fix some comment typos 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-16 21:26:19 +01:00
Maurício Meneghini Fauth
e24d2201c5
Merge pull request #18218 from MoonE/gis-visualization-settings 
Refactor GisVisualization settings
 2023-03-15 15:16:57 -03:00
Maurício Meneghini Fauth
10e1a848ed
Add support for theme color modes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-13 23:28:29 -03:00
Maximilian Krög
e8e877b662
Small change to urlParams and errorUrl globals initialization 
Default to emtpy array for urlParams, remove null initialazation for
errorUrl.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-13 21:53:19 +01:00
Maximilian Krög
3891f2bca2
Add and use getters for GisVisualization properties 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-13 21:53:19 +01:00
Maximilian Krög
07388c10a7
Remove default width / height 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-13 21:53:17 +01:00
Maximilian Krög
6b9f0d8441
Add pos and rows properties 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-13 21:52:49 +01:00
Maurício Meneghini Fauth
865c46e320
Move Theme and ThemeManager into the Theme namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-13 10:25:48 -03:00
Maximilian Krög
fa7ec73dd2
Make sure a spatial column is available 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-05 15:29:19 +01:00
Maximilian Krög
5d10439bd4 Refactor OpenLayer visualization code generation 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-04 15:50:50 -03:00
Maximilian Krög
5dac31a8c0 Use OpenLayers source.getExtent() instead of calculating from features 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-04 15:50:50 -03:00
Kamil Tekiela
1c0264f043 Small refactoring in Server/Plugins 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-03 20:44:49 -03:00
Kamil Tekiela
142f15f373
Use quoteString in controllers (#18191) 
* CreateController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* FindReplaceController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* SetVariableController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* GetVariableController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* UserGroupsFormController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* TablesController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-03 17:40:45 -03:00
Kamil Tekiela
276577ca2a
Remove $GLOBALS['PMA_PHP_SELF'] (#18149) 
* Remove $GLOBALS['PMA_PHP_SELF']

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove $GLOBALS['PMA_PHP_SELF'] from tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Moved cleanupPathInfo to Routing

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove parse_url from getRootPath

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove invalid tests

Surely, we never expect PATH to be backslash delimited. The code is not designed to handle this and the tests for this don't make much sense.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix trailing slash in path

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-27 17:56:27 -03:00
Maurício Meneghini Fauth
f9c8035768
Add native parameter types to test classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-27 01:54:03 -03:00
Maurício Meneghini Fauth
16a0660a78
Add native property types to test classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-27 01:17:22 -03:00
Maurício Meneghini Fauth
556594b4cd
Fix coding standard spacing issues 
- Fixes one line doc comments
- Fixes parent call spacing
- Fixes constant spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 21:06:17 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 20:48:46 -03:00
Maurício Meneghini Fauth
cb67fa306d
Remove Reflection's setAccessible() method 
This method is no-op since PHP 8.1.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-21 20:35:45 -03:00
Maurício Meneghini Fauth
4ff3724c3f
Use union with null instead of short nullable type 
Since union type are now possible, using union with null makes more
clear that it is a union type.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 21:48:19 -03:00
Kamil Tekiela
cfe54a501b Add union types 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-15 15:23:28 +00:00
Maurício Meneghini Fauth
0ab9e4ac77
Change PHPUnit data providers to use static methods 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-14 12:42:16 -03:00
Kamil Tekiela
f7524fd3b9
Minor code refactoring of Privileges.php (#17993) 
* Small fixes
* Replace escapeString with quoteString
This also fixes bug with $_POST['old_username'].
* Add userExists() method
* Merge if statements
* Use ServerRequest for $initial
* Extract getExportPageTitle from getExportUserDefinitionTextarea
* Update baselines
* Complete redesign of getCurrentAuthenticationPlugin()
* Add method getEmptyUserNotice()
* Remove redundant variable sets and unsets
* Add method checkStructureOfPrivilegeTable()
* Remove testGetHtmlForViewUsersError()
* Privatize getAddUserHtmlFieldset
* Improve tests for mysql.user table checks

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-01-28 20:40:30 -03:00