Commit Graph

30 Commits

Author SHA1 Message Date
Kamil Tekiela
be55c6c9a7 Fix type hints
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:12:23 +00:00
Kamil Tekiela
9f860f77c7 Use StructureOrDataType consistently
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:12:22 +00:00
Kamil Tekiela
b62ffe17c7 Merge the logic into Settings
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-16 19:31:50 +00:00
Kamil Tekiela
4e9866f797 Remove unnecessary nullability
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-30 15:12:08 +00:00
Kamil Tekiela
0f8a3c7e72 Remove unnecessary nullability
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-29 14:54:01 +00:00
Kamil Tekiela
5b8168ded6 Privatize Sanitize::isSetup()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-04 23:18:48 +00:00
Kamil Tekiela
2756f27249 Add dedicated methods for is_setup
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-04 23:16:15 +00:00
Maurício Meneghini Fauth
a97cca5f39
Replace static variables with static class properties
Static variables are better suitable for standalone functions. For
methods, static properties are better because they are easier to handle.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-07-17 22:24:06 -03:00
Maurício Meneghini Fauth
dc1bd60dd1
Fix boolean usage of the return value of preg_match()
preg_match() and preg_match_all() returns the number of pattern matches
(which might be zero), or false on failure. However, preg_match() always
returns 1 when a pattern is matched as it stops searching after the
first match.

- https://www.php.net/manual/en/function.preg-match.php
- https://www.php.net/manual/en/function.preg-match-all.php

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-07-13 14:43:05 -03:00
Maurício Meneghini Fauth
681b914fb0
Explicity calls Validator::validate* methods
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-07-07 20:44:24 -03:00
Maurício Meneghini Fauth
e03642be0d
Extract config inline params JS from config/form_display/display.twig
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-06-05 20:08:21 -03:00
Maurício Meneghini Fauth
52b3ef4495
Remove Config\ConfigFile global variables
- Removes the 'cf' and 'ConfigFile' global variables.
- Extracts the ConfigFile creation from SetupPageRedirection middleware
and moves it to the Setup\SetupHelper class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-10 21:16:33 -03:00
Maurício Meneghini Fauth
63ae297cf9
Rename Config\Settings::$DBG to $debug
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-17 15:28:20 -03:00
Maurício Meneghini Fauth
c9c286b32a
Replace DBG config array access with Debug class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-17 14:37:39 -03:00
Kamil Tekiela
2f7161fff9 Replace NotAList with assert
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-13 17:15:33 +01:00
Kamil Tekiela
a47c9a7cf3 Throw exceptions instead of errors
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-13 17:15:33 +01:00
Kamil Tekiela
54b5464ec2 Replace function casts with normal casts
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-03 15:07:57 +01:00
Kamil Tekiela
8e4443b17b
Applying suggestions from static analysis tools (#19013)
* Drop array keys from lists

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Import UrlTest

When it doesn't exist in Prod, the code will still work the same.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Drop redundant return [];

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix object access checks

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use strict comparison

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Int keys should be specified as integers

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use empty string check instead of strlen

Potential null deprecations are replaced with loose condition.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use stripos instead of *substr

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify substr's 3rd param

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary defaults

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace isZeroBasedArray with array_is_list

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify texEscape()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify exportZeroBasedArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for loop with array_diff

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for with foreach

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove nullable param in backquoteCompat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-coalescing operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Inline $result variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Turn $event into a constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Move selectDb outside the loop

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix code style order of operation

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary isset argument

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove line break

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use foreach instead of for

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-02-27 12:29:02 -03:00
Kamil Tekiela
822ebbfe59 Remove unnecessary parentheses
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-01-12 15:26:31 +01:00
Kamil Tekiela
bccbda7249 Small code quality fixes
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-01-12 14:57:46 +01:00
Kamil Tekiela
5ce27be6ac Replace mb_substr
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-01-12 03:01:17 +01:00
Kamil Tekiela
4975df100b Replace mb_strpos
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-01-12 03:01:17 +01:00
Maurício Meneghini Fauth
1129750eee
Replace server global with Current::$server
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-24 02:08:50 -03:00
Kamil Tekiela
e90cfe584f Change method name
This method doesn't sanitize anything. While it does format the message into HTML, it doesn't remove or clean anything. What it does is replace BB codes into HTML.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-02 00:10:16 +01:00
Maurício Meneghini Fauth
54631fa63b
Merge pull request #18809 from kamil-tekiela/Simplify-code
Simplify code
2023-11-28 13:41:33 -03:00
Kamil Tekiela
51f9c749ad Simplify code
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-11-28 14:42:37 +01:00
Kamil Tekiela
d3ee2d07b8 Remove dead code
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-11-28 13:17:01 +01:00
Maurício Meneghini Fauth
a4fad2488d
Move ./sql directory to ./resources/sql
- Related to https://github.com/phpmyadmin/phpmyadmin/issues/18512

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-10-18 13:40:38 -03:00
Maurício Meneghini Fauth
1ddcad2bfb
Replace libraries/classes references with src
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-30 15:59:29 -03:00
Maurício Meneghini Fauth
c2955cc2b2
Rename the directory libraries/classes/ to src/
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-30 15:59:28 -03:00