Commit Graph

332 Commits

Author SHA1 Message Date
Tim Siebels
d9cbf2664c Fix default port to null for hhvm
HHVM doesn't allow false to be passed as port to mysqli_real_connect.
It only allows a nullable integer until ZendParamMode is finished.

See facebook/hhvm#1817

Signed-off-by: Tim Siebels <tim_siebels_aurich@yahoo.de>
2014-07-24 17:54:21 +02:00
Chirayu Chiripal
04a3a7073b RFE-1488/781: User privilege tab not shown in all relevant cases
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-07-18 00:13:08 +05:30
Chirayu Chiripal
1f324be4b1 RFE-637: Custom field handlers (input transformations)
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-07-12 01:52:32 +05:30
Hugues Peccatte
66f82fbfac Update PHPDoc and remove useless variables and methods to fix scrutinizer errors.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-06-19 22:09:18 +02:00
Madhura Jayaratne
9100790551 Fix types
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-06-06 18:49:55 +05:30
Madhura Jayaratne
af857f33bc Fix parameter name
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-05-10 13:19:06 +02:00
Madhura Jayaratne
f487813356 Remove sperfluous doc comment
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-05-10 13:17:29 +02:00
Michal Čihař
72d180afd8 Add basic test for navigation tree
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-10 11:23:33 +02:00
Michal Čihař
afe2279fc4 Avoid problems with undefined drizzle constants
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 16:49:05 +02:00
Michal Čihař
2f91d172ef Avoid duplicate flags
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 16:46:33 +02:00
Michal Čihař
b1915bade0 The storeResult needs mysqli lin parameter to operate
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 16:29:56 +02:00
Michal Čihař
cb6b37f19d Remove extra spaces
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 15:57:45 +02:00
Michal Čihař
a55100e4fe Better way to generate drizzle field flags
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 14:08:58 +02:00
Michal Čihař
11d48bbca0 Better variable name
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 14:08:58 +02:00
Michal Čihař
a2d5c59a72 Correct type annontation for DBI
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 14:08:58 +02:00
Michal Čihař
09e15add26 Move getting link to the wrapper class so that the drivers always get right link parameter
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 12:36:59 +02:00
Michal Čihař
e65027e080 Check return value
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 11:36:24 +02:00
Michal Čihař
3690415c70 Share code for getting mysql link object
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 11:09:39 +02:00
Michal Čihař
c249246e10 Share code for caching affected rows
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 11:03:12 +02:00
Michal Čihař
2f312320f7 Move require to the correct place
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 10:42:59 +02:00
Michal Čihař
1273c3349c Return null for not set socket
This is correct value for unset socket.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 10:19:03 +02:00
Michal Čihař
b82e706dcb Share post connect code between DBIs
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 10:12:55 +02:00
Michal Čihař
9e8505ff5e Factor out socket/port parsing for connecting database
Almost same code was used in three DBIs, so let's share it.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 10:01:35 +02:00
Michal Čihař
39339112f3 Fix access to global variable
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 09:43:09 +02:00
Michal Čihař
69a9cb1e58 Share logic for calling postConnect method
This should be called on success, when we're creating primary
connection.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 09:41:56 +02:00
Michal Čihař
60ea7a18d7 Remove insertId from the interface and dummy DBIs
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 09:28:11 +02:00
Michal Čihař
f6ffaa1e27 This code has no effect
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 09:24:53 +02:00
Michal Čihař
510825c97e Share implementation of insertId among DBIs
There is no need to have the method implemented three times.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 09:21:11 +02:00
Michal Čihař
69beffffee Simplify code for getting field flags
Let's define array of flag names, so that we don't have to duplicate the
code for each flag.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 09:15:34 +02:00
Michal Čihař
cdc924e027 Share code for defining PMA_MYSQL_CLIENT_API
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-06 14:29:31 +02:00
Michal Čihař
96daf9eea5 Use numerical value instead of possibly undefined constant
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-14 13:42:11 +01:00
Hugues Peccatte
493f9c5a1a Don't use function in for loop test.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2013-12-18 21:29:34 +01:00
Hugues Peccatte
ab42fd2ac9 PHPCS update.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2013-12-17 18:53:14 +01:00
Marc Delisle
fe668e138f Fix tests 2013-11-27 13:08:51 -05:00
Hugues Peccatte
464ec23ad8 Huge PHPDoc update. 2013-11-10 23:04:58 +01:00
Hugues Peccatte
d3601abf96 Global PHPDoc update. 2013-11-10 12:29:55 +01:00
Marc Delisle
bb923e6fb4 Fix typo 2013-10-03 11:25:09 -04:00
Dieter Adriaenssens
ea36bf626a wrap long lines 2013-09-25 15:13:47 +02:00
Marc Delisle
5b214d07e7 Fix coding style 2013-09-24 06:25:54 -04:00
Madhura Jayaratne
fa2a226585 Fix indentation 2013-08-27 21:38:29 +05:30
Isaac Bennetch
8fd8c4d525 Improved SSL communication between MySQL and phpMyAdmin 2013-08-16 23:20:21 -04:00
Michal Čihař
f3d94d93ff Wrap long lines 2013-08-07 10:44:01 +02:00
xmujay
3f358142cb fix the "Not support query" error by moving mock data to DBI Dummy class 2013-07-13 11:31:01 +08:00
xmujay
a90ae2550f add FEDERATED to DBI dummy data 2013-07-06 11:45:38 +08:00
Michal Čihař
37d142bc3f Remove compatibility code for PHP 5.2 2013-07-01 15:29:56 +02:00
ayushchd
46a6dc32e0 Test for Tracker.class.php 2013-06-27 18:23:02 +05:45
ayushchd
5ab5cb0f94 Conflict resolve with DBIDummy Class 2013-06-12 18:01:52 +05:45
ayushchd
febc05dae0 Unit tests for charset conversions
Added test cases for:

1. libraries/char*
2. libraries/iconv*
3. libraries/kanji*
2013-06-12 16:14:09 +05:45
Michal Čihař
2417937179 Define another query used in testsuite 2013-06-11 14:31:04 +02:00
Madhura Jayaratne
218092f92e Reverting "Move drizzle related code to PMA_DBI_Drizzle class" part of 17b3df142 2013-05-27 13:51:13 +05:30