gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
129,408 Commits 12 Branches 481 Tags 2.4 GiB
cbdaff3356
Commit Graph

39 Commits

Author SHA1 Message Date
Kamil Tekiela
cbdaff3356 Fix type hints 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-12-18 15:09:43 +00:00
Kamil Tekiela
fb130367a0 Fix type hints 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-12-18 15:09:43 +00:00
Kamil Tekiela
eaa9f2d051 Fix type hints 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-12-18 15:09:41 +00:00
Maurício Meneghini Fauth
7d6b17a417
Replace sql_query global var with Current::$sqlQuery 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2024-12-09 13:51:22 -03:00
Kamil Tekiela
0c84b630a4 Drop getReservedColumnNames() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-10-30 19:29:02 +00:00
Kamil Tekiela
ec977df5cd ForeignerKey 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-09-24 18:35:32 +01:00
Kamil Tekiela
70f7682425 Add native true type 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-08-16 11:56:22 +02:00
Maurício Meneghini Fauth
dc1bd60dd1
Fix boolean usage of the return value of preg_match() 
preg_match() and preg_match_all() returns the number of pattern matches
(which might be zero), or false on failure. However, preg_match() always
returns 1 when a pattern is matched as it stops searching after the
first match.

- https://www.php.net/manual/en/function.preg-match.php
- https://www.php.net/manual/en/function.preg-match-all.php

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-07-13 14:43:05 -03:00
Maurício Meneghini Fauth
c6c9aeb678
Merge #19124 - Refactoring move copy 
The goal of this was to partition the big method into smaller easier to
understand chunks and get rid of globals. This code is still far from
perfect but I have no idea how to proceed further right now.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-05-10 11:13:57 -03:00
Kamil Tekiela
24e6089625 Add UiProperty enum 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-05-02 23:01:12 +02:00
Kamil Tekiela
bb37e649b9 Fix unit tests 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-04-22 22:56:33 +02:00
Kamil Tekiela
81853e877b Create TableMover class 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-04-22 21:52:40 +02:00
Kamil Tekiela
8e4443b17b
Applying suggestions from static analysis tools (#19013) 
* Drop array keys from lists

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Import UrlTest

When it doesn't exist in Prod, the code will still work the same.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Drop redundant return [];

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix object access checks

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use strict comparison

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Int keys should be specified as integers

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use empty string check instead of strlen

Potential null deprecations are replaced with loose condition.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use stripos instead of *substr

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify substr's 3rd param

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary defaults

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace isZeroBasedArray with array_is_list

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify texEscape()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify exportZeroBasedArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for loop with array_diff

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for with foreach

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove nullable param in backquoteCompat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-coalescing operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Inline $result variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Turn $event into a constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Move selectDb outside the loop

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix code style order of operation

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary isset argument

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove line break

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use foreach instead of for

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-02-27 12:29:02 -03:00
Kamil Tekiela
79a68a4349
Add type hints instead of mixed (#18976) 
* Remove some empty() statements

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix docbloc

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type hint to getHtmlForOneKey()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to buildColumnCreationStatement()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add return type to fetchByMode()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getCompatibilities()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getDirContent

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getCharLists()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to executeSqlQuery()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to findLineNumberAndColumn

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to lint()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getHtmlForNewTables3NF()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getViewsAndCreateSqlViewStandIn()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getPossibleRowFormat()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getTableAltersArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getValuesForColumn()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getAvailableMimeTypes()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add types to TwigLintCommand

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to isRowCountApproximated

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getReplicationStatus()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type in formatVariable()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to fetchSingleRow()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getPages()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to CentralColumns::getParams()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to removeRelation()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getWarnings()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getTableCommentsArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix docbloc comment

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to sanitizeUrl()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to uploadProgressSetup()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to explodeMarkup()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add types in Table

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getHtmlForDataStatements()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-02-07 19:19:12 -03:00
Maurício Meneghini Fauth
45b5577a3c
Merge pull request #18946 from kamil-tekiela/Table-updateForeignKeys 
Add type hint to Table::updateForeignKeys()
 2024-01-31 16:03:46 -03:00
Kamil Tekiela
0e1e91e2b5 Add type hint to Table::updateForeignKeys() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-31 15:54:13 +01:00
Kamil Tekiela
3ef1d3c3ce Drop getVirtualTables() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-29 19:43:54 +01:00
Maurício Meneghini Fauth
3353b47721
Create ConnectionType enum 
Replaces Connection::TYPE_* constants with ConnectionType enum.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-01-29 12:47:15 -03:00
Kamil Tekiela
822ebbfe59 Remove unnecessary parentheses 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-12 15:26:31 +01:00
Kamil Tekiela
1a1737c36f Move getSqlQueryForIndexCreateOrEdit() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-31 17:22:24 +01:00
Kamil Tekiela
4677dac58f Refactor Indexes::doSaveData() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-31 17:22:24 +01:00
Kamil Tekiela
6e102ed0e2 Add type hint for getStatusInfo() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-27 19:16:09 +01:00
Kamil Tekiela
344e3306cf Redesign getCachedTableContent() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-27 18:17:31 +01:00
Kamil Tekiela
00617da975 Remove $forceRead param 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-27 18:11:15 +01:00
Kamil Tekiela
6ab2b59d8d Remove redundant arguments 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-27 17:31:54 +01:00
Kamil Tekiela
7373b58cd5 Remove trigger_error from getStatusInfo() 
This is a custom undefined index error, which is a developer error, not a runtime error. It should be enforced in the code, and should not throw a user error.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-27 15:02:23 +01:00
Kamil Tekiela
01aaa90861 Remove $_SESSION['is_multi_query'] 
It's not clear what this was supposed to do, but it definitely shouldn't be done this way.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-27 14:49:28 +01:00
Maurício Meneghini Fauth
98ee8f7158
Merge pull request #18862 from MauricioFauth/server-global 
Replace server global with Current::$server
 2023-12-24 17:48:28 -03:00
Maurício Meneghini Fauth
1129750eee
Replace server global with Current::$server 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-12-24 02:08:50 -03:00
Kamil Tekiela
ae78224190 Simplify return statement 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-20 21:07:03 +01:00
Kamil Tekiela
a4f09239d5 Fix wrong comparison operator 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-20 21:07:03 +01:00
Kamil Tekiela
5e24fb8a52 Replace cacheTableContent with cacheTableValue 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-20 21:07:03 +01:00
Kamil Tekiela
f849cc5b17 Remove unnecessary code 
The cache is already filled inside getTablesFull().

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-20 21:07:02 +01:00
Maurício Meneghini Fauth
711f6c0f14
Replace db global variable with static class property 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-12-17 14:58:59 -03:00
Kamil Tekiela
d204a758fd Remove $GLOBALS['showtable'] 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-15 20:00:31 +01:00
Kamil Tekiela
4fb335e960 Make in_array strict 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-07 17:11:48 +01:00
Kamil Tekiela
063a494793 Improve type hint of getColumnsWithIndex() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-07 02:15:44 +01:00
Kamil Tekiela
51f9c749ad Simplify code 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-11-28 14:42:37 +01:00
Maurício Meneghini Fauth
582809d589
Move Table class into Table namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-11-15 16:09:42 -03:00