Commit Graph

59 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
1e542cd621
Replace vendor_config.php constants with an array
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-26 16:48:56 -03:00
Maurício Meneghini Fauth
ee45b3981c
Create the UrlRedirector class
Extracts the url.php logic to the UrlRedirector::redirect static method.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-01 12:23:39 -03:00
Maurício Meneghini Fauth
8f2f3eff40
Remove the Core::isValid method
This improves the type checking and simplifies the code.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-02 13:20:50 -03:00
Maurício Meneghini Fauth
a0d91ec153
Move common.inc.php to classes/Common.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-06 14:00:44 -03:00
Maurício Meneghini Fauth
dc37d436cc
Extract common.inc.php logic to Common::run method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-06 13:48:11 -03:00
Maurício Meneghini Fauth
17f4e09a6b
Extract some common checks from common.inc.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-06 13:27:14 -03:00
Maurício Meneghini Fauth
76aabc9826
Remove PMA_MINIMUM_COMMON constant
Replaces it with the `$isMinimumCommon` global variable.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-02 01:29:07 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
75fc2ed74f Remove dbi global from DatabaseInterface::load method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-15 16:24:14 -03:00
William Desportes
ae182cddb5
Ref #16005 - Move services loader to a php array
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-04 08:44:12 +01:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
63dbcd01d9 Remove or ignore side effects in PHP files
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 20:22:37 -03:00
Maurício Meneghini Fauth
77518d341e Remove unused use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 21:20:58 -03:00
Oleg Abrazhaev
7d7fe98be5 extract TWIG for url.php and fix formatting #14801
Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>
2019-10-27 14:29:09 +01:00
Maurício Meneghini Fauth
5d2266ae41 Fix missing global declaration
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-05 20:35:22 -03:00
Maurício Meneghini Fauth
ee59b98a01 Merge branch 'QA_5_0' 2019-09-04 18:37:42 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Mauro Valvano
319057e33c
Fixed url.php crashing because it was not loading the DatabaseInterface service
Signed-off-by: Mauro Valvano <valvano.m@live.it>
2019-08-30 23:57:53 +02:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00
Maurício Meneghini Fauth
38e5b12c1c Define an absolute path to use for require statements
Fixes #6167

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-22 14:37:31 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 21:04:19 -02:00
Maurício Meneghini Fauth
01e8064e35 Retrieve parameters from $_GET in url.php
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
af148ad92b Enable strict mode in PHP files
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 04:36:04 -03:00
Maurício Meneghini Fauth
8f943ae1c0 Move classes to PhpMyAdmin namespace
- Move Sanitize to PhpMyAdmin namespace
- Move SavedSearches to PhpMyAdmin namespace
- Move Scripts to PhpMyAdmin namespace
- Move ServerStatusData to PhpMyAdmin namespace
- Move Sql to PhpMyAdmin namespace
- Move StorageEngine to PhpMyAdmin namespace
- Move SubPartition to PhpMyAdmin namespace
- Move SysInfoLinux to PhpMyAdmin namespace
- Move SysInfoSunOS to PhpMyAdmin namespace
- Move SysInfoWINNT to PhpMyAdmin namespace
- Move SysInfo to PhpMyAdmin namespace
- Move SystemDatabase to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-07 01:46:08 -03:00
Maurício Meneghini Fauth
119563b7ea Move classes to PhpMyAdmin namespace
- Move OpenDocument to PhpMyAdmin namespace
- Move OutputBuffering to PhpMyAdmin namespace
- Move Partition to PhpMyAdmin namespace
- Move Pdf class to PhpMyAdmin namespace
- Move RecentFavoriteTable to PhpMyAdmin namespace
- Move Response to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-06-30 23:44:10 -03:00
Maurício Meneghini Fauth
13c0f7bc3c Move classes to PhpMyAdmin namespace
- Move Advisor to PhpMyAdmin namespace
- Move Bookmark to PhpMyAdmin namespace
- Move Charsets to PhpMyAdmin namespace
- Move Config class to PhpMyAdmin namespace
- Move Console class to PhpMyAdmin namespace
- Move Core to PhpMyAdmin namespace
- Move DatabaseInterface to PhpMyAdmin namespace
- Move DbList to PhpMyAdmin namespace
- Move DbQbe to PhpMyAdmin namespace
- Move DbSearch to PhpMyAdmin namespace
- Move DisplayResults to PhpMyAdmin namespace
- Move Encoding to PhpMyAdmin namespace
- Move Error to PhpMyAdmin namespace
- Move ErrorHandler to PhpMyAdmin namespace
- Move File to PhpMyAdmin namespace
- Move Font to PhpMyAdmin namespace
- Move Footer to PhpMyAdmin namespace
- Move Header to PhpMyAdmin namespace
- Move Index to PhpMyAdmin namespace
- Move IndexColumn to PhpMyAdmin namespace
- Move LanguageManager to PhpMyAdmin namespace
- Move Language to PhpMyAdmin namespace
- Move Linter to PhpMyAdmin namespace
- Move ListAbstract to PhpMyAdmin namespace
- Move ListDatabase to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-06-28 21:17:18 -03:00
Maurício Meneghini Fauth
e330402b5b Refactor the core functions into static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-06-03 00:52:22 -03:00
Michal Čihař
308c9d7951 Simplify Response object handling
- always use use and short name
- avoid calling getInstance() several times in one script

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-12-07 18:17:59 +01:00
Michal Čihař
f72572708f Merge branch 'QA_4_6-security' into master-security 2016-07-22 14:42:09 +02:00
Michal Čihař
67b538efc3 Send standard set of HTTP headers on redirect
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-22 12:19:35 +02:00
Michal Čihař
7641e3f3b1 Merge branch 'QA_4_6' 2016-07-22 12:12:21 +02:00
Michal Čihař
1d70a1ba64 Allow only https outgoing links
We no longer produce http links, so it's better to filter out these at
all levels.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-22 12:10:11 +02:00
Michal Čihař
e5337e51b0 Merge branch 'QA_4_6' 2016-06-15 11:38:38 +02:00
Michal Čihař
47f918f3fe Use standard redirect function
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-15 11:38:00 +02:00
Durgesh
6650f7b07d Refactor text sanitization and javascript escaping, Issue #11989, #11988
Signed-off-by: Durgesh <007durgesh219@gmail.com>
2016-02-22 14:45:19 +05:30
Michal Čihař
2a9fb73f92 Remove PmaAbsoluteUri from redirects
This is no longer needed as per RFC 7231.

Issue #11412

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-03 14:32:14 +01:00
Marc Delisle
9ee3931c09 Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-03 10:43:10 -05:00
Marc Delisle
cd09765675 Port content spoofing fix
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-10-23 06:50:04 -04:00
Madhura Jayaratne
7199825abd Long links may be converted to forms
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-05-07 17:53:50 +05:30
Rahul Kadyan
4d308ba364 Remove unneeded closing tags
Closing tags at the end of file are not mandatory. It is often
suggested to omit to closing tags at the end of file to prevent
unwanted effects as PHP will start output buffering if there is
any character after closing tag.

Reference: http://php.net/manual/en/language.basic-syntax.phptags.php

Signed-off-by: Rahul Kadyan <hi@znck.me>
2015-03-06 23:37:35 +05:30
Michal Čihař
1daa32fb97 bug #4612 [security] XSS vulnerability in redirection mechanism
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-12-03 08:29:55 -05:00
Michal Čihař
d938eb9eb1 Simplify url redirectory code, no need for two branchs 2014-02-11 09:15:28 +01:00
Michal Čihař
5e9cf18073 Improvements in URL redirector
- do not concatenate message to allow better translation
- avoid possbile XSS
2014-02-11 09:14:42 +01:00
Madhura Jayaratne
09dec45ffa Remove commented debugging code. Replace tabs with spaces
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-02-08 12:36:08 +05:30
Marc Delisle
5c5673f4cf Fix coding style; add localization
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-02-07 12:49:57 -05:00
Dhananjay
0a18d86059 Fix for bug#4237.
Signed-off-by: Dhananjay <dhananjaynakrani@gmail.com>
2014-02-07 11:56:46 +05:30
Dieter Adriaenssens
4c88729902 fix coding style: true is lower case 2013-09-12 17:50:58 +02:00