Commit Graph

10443 Commits

Author SHA1 Message Date
Michal Čihař
e4c5401e6c Properly escape MIME transformatoin names
Fixes #13045

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-03-02 09:19:37 +01:00
Michal Čihař
faffa92f22 Fixed related field selection for native relations
The PMA_getForeigners handles just fine both situations, so there is no
need to check the configuration in advance.

Fixes #12967

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-03-01 15:43:33 +01:00
Michal Čihař
cb60b4a750 Fixed displaying of all rows
Fixes #13031

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-03-01 12:41:07 +01:00
Michal Čihař
dee50ad8d1 Reference self as self not using class name
Issue #13040

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-03-01 09:59:58 +01:00
Michal Čihař
248a42af7e Fixed javascript confirmation of dangerous queries
The confirmations did work properly only in console and not anywhere
else.

- the check function was expecting textarea, while it got text from
  other calls
- the check for empty form was completely outdated, but that seems to
  lead only to dead code and no breakage
- for the inline editor, the form was not properly focused and restored
  on confirmation error

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-03-01 09:33:18 +01:00
Michal Čihař
c27d47ed75 Use Referrer-Policy header to specify referrer policy
The referrer policy in Content-Security-Policy is deprecated.

Fixes #13033

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-27 11:42:21 +01:00
Michal Čihař
8ea5ea351b Document bugfix
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-22 09:50:52 +01:00
Isaac Bennetch
b50b97af49 Hide comment field on table Structure tab when no comment is set
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2017-02-21 21:36:52 -05:00
Michal Čihař
510d7ab8ca Changelog entry for issue #13020
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-21 09:13:18 +01:00
Michal Čihař
a9ddb39aac Show phpMyAdmin errors even with error_reporting set to 0
Fixes #13021

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-20 10:04:38 +01:00
Joshua Atkins
53eff5d47b Align NULL values according to column alignment
Fixes #13000.

Signed-off-by: Joshua Atkins <support@jublo.net>
2017-02-20 09:06:36 +01:00
Michal Čihař
59e9856200 Fixed OpenDocument exports
Fixes #13002

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-20 08:44:03 +01:00
Michal Čihař
8a08c90cb1 Merge branch 'QA_4_7' into hotfix/13010-pmadb-relation-replaceinto 2017-02-20 08:38:39 +01:00
Michal Čihař
454620dcf8 Require SQL parser > 4.1.2
This brings additional fixes like for #12345

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-20 08:25:34 +01:00
Joshua Atkins
c4654d24df Copy db: Fix SQL error for copying PMADB metadata
Fixes #13010.

Signed-off-by: Joshua Atkins <support@jublo.net>
2017-02-19 22:35:21 +01:00
Isaac Bennetch
2f7dd1e149 Slight improvements to the UI for Relation view; Fixes to table structure.
Fixes #13016 and #13017

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2017-02-19 09:17:13 -05:00
Michal Čihař
dc3ef3ce7f Try harder to honor LoginCookieValidity setting
Even when it is lower than session.gc_maxlifetime we try to keepalive
the session by AJAX.

Fixes #11231

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-14 16:29:55 +01:00
Michal Čihař
fa051ff3e8 Add basic support for TokuDB
This applies most of https://github.com/phpmyadmin/phpmyadmin/pull/12693
on top of current code base.

- offer correct operations on operations tab
- properly handle counting same as with InnoDB

Fixes #12693

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-14 13:55:17 +01:00
Michal Čihař
c86aa9b275 Always show error reporting dialog on top
Fixes #12958

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-14 11:51:23 +01:00
Michal Čihař
8f8943abf4 Improved foreign key editor
- sort numerically with NaturalOrder
- do not add extra empty value on not set foreign keys

Fixes #12976

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-14 11:27:42 +01:00
Michal Čihař
889ccb6555 Better defaults when creating multi fields foreign key
It does not make sense to set all fields to one key.

Fixes #12980

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-14 11:09:57 +01:00
Michal Čihař
e7951f733d List all databses in navigation panel database dropdown
Fixes #12996

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-14 11:02:02 +01:00
Michal Čihař
58472a97d2 Fixed javascript error on 3NF normalization
Fixes #12927

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-13 15:30:51 +01:00
Michal Čihař
dda0d8b69d Load server stats queries scripts in order
We can not load first script which uses later one.

Fixes #12934

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-13 15:06:13 +01:00
Michal Čihař
bca2e1c588 Use standard way for getting token value in designer
This way we share code with rest of phpMyAdmin, not building it again.

Fixes #12804

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-13 15:00:11 +01:00
Michal Čihař
a083a4c839 Fixed manipulation with GIS data having zero coordinates
Another example when using PHP's empty() leads to problems.

Fixes #12957

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-13 14:44:47 +01:00
Michal Čihař
8f611f05cf Fixed rendering of foreign key browsing
Fixes #12985

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-13 13:51:13 +01:00
Michal Čihař
d54061d1f8 Include token in hidden fields
This will fix few broken users:

- error reporting
- table search in navigation
- user preferences

Fixes #12964

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-13 12:53:36 +01:00
Michal Čihař
fc1c784a43 Changelog entry for #12922 and #12933
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-13 12:24:20 +01:00
Michal Čihař
0038245ec8 Improved rendering of new version information
- remove extra space in from of new version information
- add space between sentence and new version

Fixes #12981

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-13 11:56:36 +01:00
Michal Čihař
baa390df89 Fixed error when loading favorite tables to console
The token was missing in POST request.

Fixes #12990

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-13 11:34:57 +01:00
Michal Čihař
bcc7c7af35 Allow secure.php.net in url redirector
Fixes #12993

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-13 11:30:42 +01:00
Michal Čihař
924aabf652 Do not show language selector without choices
Move the check from template to the code, so that the selection is
completely hidden when there is nothing to select.

Fixes #12988

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-13 11:22:43 +01:00
Isaac Bennetch
8db5de02a0 Better error message when Composer files are missing.
Fixes #12972

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2017-02-09 10:32:21 -05:00
Madhura Jayaratne
99e4e0d1ee Fix #12966 After adding a column ADD INDEX option won't be displayed when enabling AI
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2017-02-07 22:32:22 +05:30
Michal Čihař
63db3da30a Enclose exports in transaction by default
Fixes #12960

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-07 10:30:45 +01:00
Michal Čihař
0d9c1101ac Fixed export of tracking data
Fixes #12954

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-06 13:37:21 +01:00
Michal Čihař
f73a98e421 Fixed database renaming
Fixes #12955

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-06 13:31:39 +01:00
Michal Čihař
80de044517 Changelog entry for #12904 and #12939
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-06 13:26:04 +01:00
Michal Čihař
98fafeec79 Properly pass token on navigation paginating
Fixes #12936

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-02 14:57:41 +01:00
Michal Čihař
5a3410ca86 Fixed sorting of tables in relation view
Fixes #12941

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-02 14:43:18 +01:00
Michal Čihař
eeb0771245 Fixed hint rendering on adding new user
Fixes #12945

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-02 14:06:48 +01:00
Michal Čihař
5022ff9560 Do not show errors from OpenSSL cookie encryption/decryption
This can happen from corrupted cookies, by invalid encryption parameters
used in older phpMyAdmin versions or by wrong openSSL configuration.

In neither case the error is useful to user, but we need to clear the
error buffer as otherwise the errors would pop up later, for example
during MySQL SSL setup.

Fixes #12924

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-02 13:43:51 +01:00
Isaac Bennetch
7b4068da7d Fix undefined index warning with some SSL connections and ssl_ca_paths.
Fixes #12929

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2017-01-28 23:06:46 -05:00
Michal Čihař
c18d2a9ced Changelog entry for #12923
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-01-25 10:03:08 +01:00
Michal Čihař
476649fbdc Merge commit 'c812bcd4112c3d44e6e6bc72e710b9935c6aa9d3' 2017-01-24 09:51:01 +01:00
Michal Čihař
20aa51f601 Merge branch 'master-security' 2017-01-24 09:49:49 +01:00
Isaac Bennetch
c812bcd411 Prepare for 4.6.6 release
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2017-01-23 14:19:14 -05:00
Michal Čihař
55880451eb Always use \r\n as newline when editing fields
Convert \n to \r\n during inline editing to be consistent with form submitted
value.

The internal browser representation has to be just \n while form submitted
value \r\n, see specification:

https://www.w3.org/TR/html5/forms.html#the-textarea-element

Fixes #12918

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-01-23 16:28:13 +01:00
Michal Čihař
744cf1d463 Merge branch 'QA_4_6-security' into master-security 2017-01-21 16:46:16 +01:00