Maurício Meneghini Fauth
39f42f848b
Remove some useless docblock comments
...
Fixes docblock spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
77518d341e
Remove unused use statements
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
f6a17433a2
Use null coalesce operator when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 20:16:58 -03:00
Maurício Meneghini Fauth
fa6fc404fe
Create Table\TriggersController
...
Moves database|table triggers entry point logic to
Database|Table\TriggersController and removes the entry point file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 17:53:18 -03:00
Maurício Meneghini Fauth
351e34ecf5
Upgrade PHPStan to version 0.12.0
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-07 20:26:39 -03:00
Maurício Meneghini Fauth
7ac1d21c70
Fix some PHPStan level 2 errors
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-05 19:50:24 -03:00
Maurício Meneghini Fauth
dd06cd38f8
Defines rules for double quote usage
...
Makes sure that any use of double quotes strings are warranted.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
William Desportes
9754f84866
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 18:07:31 +01:00
William Desportes
ff812e9366
Fix a merge mistake
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 18:05:59 +01:00
William Desportes
4534c4b519
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 17:44:27 +01:00
William Desportes
3ebcf62e78
Merge branch 'QA_4_9' into QA_5_0
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 17:43:06 +01:00
William Desportes
b6e1ea68f3
Fix issue reported by Scrutinizer
...
It seems like ... can also be of type null; however, parameter $existrel_foreign of PhpMyAdmin\Table::updateForeignKeys does only seem to accept array
Link: https://scrutinizer-ci.com/g/phpmyadmin/phpmyadmin/inspections/72ec4952-c554-485c-b2f9-0898330b9368/issues/files/libraries/classes/Controllers/Table/RelationController.php?status=new&orderField=path&order=asc&honorSelectedPaths=0&issueId=42062672
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 15:56:54 +01:00
William Desportes
05dafc86fa
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 15:28:34 +01:00
William Desportes
dcc934b98a
Merge branch 'QA_4_9' into QA_5_0
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 15:26:41 +01:00
William Desportes
28d76482b8
Fix #15591 - Undefined index: foreign_keys_data
...
Fixes : #15591
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 14:53:21 +01:00
Hugues Peccatte
3255e4ad7b
Split Util class regarding the responsabilities ( #15567 )
...
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.
There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.
* Split Util class regarding the responsabilities
* Split the buttonOrImage function
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
William Desportes
acba81e091
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-10 21:06:25 +01:00
William Desportes
bf8939add6
Merge branch 'QA_4_9' into QA_5_0
...
Fixes the merge mitake done in df0543694c
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-10 21:02:57 +01:00
William Desportes
a11f0f22c8
Fix a minor error found while reviewing diffs
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-10 20:57:28 +01:00
William Desportes
df0543694c
Merge branch 'QA_4_9' into QA_5_0
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-10 20:54:15 +01:00
William Desportes
8aad190ae0
Fix #14951 - Moving Columns with DEFAULT NULL doesn't work on MariaDB 10.2+
...
Ref: 98a7479174
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-09 23:08:54 +01:00
William Desportes
e9ad2bc153
Fix #14951 - Moving Columns with type INT and default CURRENT_TIMESTAMP
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-09 23:08:08 +01:00
Maurício Meneghini Fauth
600079f0f0
Create Table\PrivilegesController
...
Extract Server\Privileges::getHtmlForSpecificTablePrivileges to a
controller.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-29 16:32:07 -03:00
Maurício Meneghini Fauth
1a14b3e4d3
Remove vim modelines
...
These settings are no longer required as they are guaranteed through
other coding standard tools.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
William Desportes
f3bdd3521d
Merge branch 'QA_5_0' into master
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-29 22:43:40 +02:00
William Desportes
2f2c942282
Merge branch 'QA_4_9' into QA_5_0
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-29 22:42:33 +02:00
R. Gurung
9d2eeb9378
Update libraries/classes/Controllers/Table/TableStructureController.php
...
Co-Authored-By: William Desportes <williamdes@wdes.fr>
Signed-off-by: Rahul Gurung <gurungrahul2@gmail.com>
2019-08-29 13:25:57 +05:30
Maurício Meneghini Fauth
d01e1c26b9
Fix active page on navigation bar
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-26 15:14:17 -03:00
Rahul Gurung
517b47e0a0
fixed error in change button for column names with backslash
...
Signed-off-by: Rahul Gurung <gurungrahul2@gmail.com>
2019-08-22 21:17:32 +05:30
Maurício Meneghini Fauth
ba6bad9533
Use the router for view_create.php
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-21 00:11:04 -03:00
William Desportes
40ed155775
Merge branch 'QA_5_0' into 'master'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 11:09:55 +02:00
William Desportes
f428277bad
Merge branch 'QA_4_9' into 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 11:08:28 +02:00
William Desportes
bef259c510
Fix NULL wrongly checked on field change
...
Pull-request: #15445
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 10:04:42 +02:00
Hugues Peccatte
98a7479174
Fix NULL wrongly checked on field change
...
When a field was requested to be changed, the "null" field was compared to its previous value. Unfortunately, both fields don't have the same value, so a change was always identified.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-19 18:00:18 +02:00
Maurício Meneghini Fauth
ee732651b3
Use the router for the table gis visualization page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-15 22:58:21 -03:00
William Desportes
b4d3b07476
Fix #15363 - Remove unexpected quotes on text fields
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-15 22:13:17 +02:00
Maurício Meneghini Fauth
d29e6d5728
Use the router for the table find and replace page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-14 18:07:42 -03:00
Maurício Meneghini Fauth
60e9a55021
Use the router for the table zoom search page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-14 15:48:59 -03:00
Maurício Meneghini Fauth
71a5c660df
Move sql entry points to libraries/entry_points
...
- sql.php -> libraries/entry_points/sql.php
- server_sql.php -> libraries/entry_points/server/sql.php
- db_sql.php -> libraries/entry_points/database/sql.php
- tbl_sql.php -> libraries/entry_points/table/sql.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-05 15:34:50 -03:00
Maurício Meneghini Fauth
208b0e25e1
Use the router for the sql pages
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-03 21:25:27 -03:00
Maurício Meneghini Fauth
3b973a442d
Use the router for table search page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-25 20:40:55 -03:00
Maurício Meneghini Fauth
aec0402679
Use the router for table structure page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-19 20:18:06 -03:00
Hugues Peccatte
598a4db588
Use short calculation/assignation syntax when possible
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-07-16 23:21:25 -03:00
Hugues Peccatte
0d8f6a3a93
Merge isset and unset calls
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-07-16 23:21:25 -03:00
Maurício Meneghini Fauth
0a5f24052a
Use the router for the tracking pages
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-15 01:38:18 -03:00
Maurício Meneghini Fauth
064e5eef0a
Use Collation value object when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-28 23:01:30 -03:00
William Desportes
a2268169ae
Use strict compare for count function
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:44:49 +02:00
William Desportes
64c1b26bac
Use strict compare for booleans
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:41:54 +02:00
William Desportes
6cc352ac12
phpstan level 3 fixes
...
21 errors left
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:37:38 +02:00
William Desportes
418b50dd4e
Merge branch 'QA_4_9'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:28:19 +02:00