Commit Graph

157 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
dd2b05330a Remove useless parentheses
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-12 00:18:01 -03:00
Maurício Meneghini Fauth
77518d341e Remove unused use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
f6a17433a2 Use null coalesce operator when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 20:16:58 -03:00
William Desportes
5f13152857
Fix some PHPStan level 3 errors
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-06 09:02:41 +01:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
William Desportes
4e4670e9c2
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-23 00:08:27 +01:00
William Desportes
293d273632
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-23 00:06:39 +01:00
William Desportes
3f9ac1dc98
Fix engine can be null
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-23 00:05:55 +01:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567)
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
William Desportes
9965009cce
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-20 12:52:11 +01:00
William Desportes
68cfb777a5
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-20 12:37:58 +01:00
William Desportes
97ccafa06a
Add a message for misconfigured designer (displaywork)
- When adding a column as display column in designer

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-20 12:30:14 +01:00
William Desportes
770f30aa86
Fix display field in Designer
Introduced by: a23f2ba51a

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-20 12:29:07 +01:00
Maurício Meneghini Fauth
8a0aa251fe Replace some custom CSS utilities with Bootstrap equivalents
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-12 19:35:37 -03:00
William Desportes
eda044cbac
Improve code after Scrutinizer report
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-11 21:33:25 +01:00
William Desportes
7f0949ad00
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-11 20:54:26 +01:00
William Desportes
5a83a289d8
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-11 20:31:34 +01:00
William Desportes
e070256fe4
Fix #13912 and #15123 - Tables of phpMyAdmin storage are not accessible
Fixes: #13912
Fixes: #15123

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-11 12:02:54 +01:00
William Desportes
f52f3afff3
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-09 15:48:34 +01:00
William Desportes
c16891cb40
Merge branch 'QA_4_9' into QA_5_0 2019-11-09 15:41:21 +01:00
William Desportes
4ae14a3da9
Improve l10n context for translators and fix a typo
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-09 15:35:59 +01:00
Maurício Meneghini Fauth
fae64caf60 Merge branch 'QA_5_0'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-21 10:26:31 -03:00
Maurício Meneghini Fauth
dca01a5f77 Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-21 10:11:34 -03:00
Maurício Meneghini Fauth
1a2cef1ae1 Fix some coding standard issues detected by PHPCS
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-21 09:57:06 -03:00
Maurício Meneghini Fauth
9b6cd02d61
Merge pull request #15509 from mauriciofauth/neutral-pronouns
Use gender-neutral pronouns
2019-10-18 09:13:52 -03:00
Maurício Meneghini Fauth
441f8daa1a Use gender-neutral pronouns
Replaces gender-specific pronouns with gender-neutral pronouns.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-18 09:13:08 -03:00
William Desportes
343adb694f
Merge branch 'QA_5_0' 2019-10-18 00:14:04 +02:00
William Desportes
5698fb221f
Merge branch 'QA_4_9' into QA_5_0 2019-10-18 00:13:07 +02:00
Sergi L
602cf50e52
Text-area-overflows-parent-element
Signed-off-by: Sergi Linares <sergi_linares@outlook.com>
2019-10-17 23:21:24 +02:00
Maurício Meneghini Fauth
6ea135a0d0 Merge branch 'QA_5_0' 2019-09-21 17:31:48 -03:00
Maurício Meneghini Fauth
3e330fd403 Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-21 17:30:44 -03:00
Maurício Meneghini Fauth
0a8fc4446b Fix some invalid array accesses with PHP 7.4
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-21 17:22:52 -03:00
William Desportes
d43e34868b
Merge branch 'QA_5_0' into master
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-09-08 16:44:15 +02:00
William Desportes
8343320841
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-09-08 16:02:41 +02:00
William Desportes
58f56111df
Fix reloading a designer page
- Added cast to be sure pageNumber is an int -1 or postitive

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-09-08 11:40:13 +02:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
d01e1c26b9 Fix active page on navigation bar
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-26 15:14:17 -03:00
William Desportes
803d07d868
Merge branch 'QA_5_0' into 'master'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 14:19:56 +02:00
William Desportes
b8527d90dd
Fix typo introduced by 1af61f88b3
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 13:49:25 +02:00
William Desportes
1af61f88b3
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 12:34:24 +02:00
William Desportes
027f39057a
Merge branch 'QA_4_9' into QA_5_0
- Fixed css img urls for designer

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 12:22:37 +02:00
William Desportes
6d0f3083ca
Fix display field can return a boolean
[ci skip]

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 12:15:21 +02:00
William Desportes
a23f2ba51a
Fix some bugs with strange table and database names
- Fix export
- Fix split on . to have db and table
- Replace some $_REQUEST occurences
- Add translations to "add tables from another database" : "None" > strNone
- Refactor the ugly code that used globals to use an object "DesignerTable"
- Fix save a new added table
- Fix delete page items
- Fix more bugs

Fixes: #15446
Fixes: #13370
Fixes: #14945
Closes: #15438

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 00:55:41 +02:00
Hugues Peccatte
de57539fb7 Build "tables list" in JS
This will allow to have the list generation in only one place, as the tables can now be added on the fly. So JS also needs to add items to this list.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-21 00:01:17 +02:00
Hugues Peccatte
14ba5a1b24 Retrieve DB instead of relying on current one
When adding a table to the designer, it is useful to know the DB of this table to be able to jump to its structure.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-20 22:23:35 +02:00
Maurício Meneghini Fauth
c3c58e6cd4 Use the router for the database QBE page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-07 23:43:44 -03:00
Maurício Meneghini Fauth
18a9d4f9db Use the router for the multi table query page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-07 23:00:18 -03:00
Hugues Peccatte
0d8f6a3a93 Merge isset and unset calls
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-07-16 23:21:25 -03:00
Hugues Peccatte
04616ff7fe Import instead of using FQN
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-07-05 23:21:14 +02:00