Commit Graph

257 Commits

Author SHA1 Message Date
Michal Čihař
f978e347fb Add missing requie once for testsuite
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-23 14:28:28 +02:00
Michal Čihař
f9d6c40939 Safer handling of sessions during authentication
- always generate new session for login form
- always generate new session when authenticated using cookie auth

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-23 13:48:25 +02:00
Michal Čihař
adfd5a22b9 Avoid double redirects in signon auth on logout
Also adjusts tests to no longer rely on runkit.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-23 13:23:16 +02:00
Michal Čihař
11eb574242 Improve handling of logout
- add separate script for handling logout
- no longer require old_usr for all authentication methods
  (this avoids potential information leak)
- require valid token for logout

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-23 13:02:21 +02:00
Michal Čihař
21db724c85 Remove need for having define for test
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-23 12:09:36 +02:00
Michal Čihař
1523985bce Fix login after logout with http authentication
We can not check token here as it's always there (in the URL) after
logout.

Fixes #12098

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-03-17 11:31:06 +01:00
Michal Čihař
5042b65398 Merge branch 'QA_4_5' into QA_4_6 2016-02-12 10:45:43 +01:00
Michal Čihař
4534a90b80 Silent warnings when checking for file existance
Another occurences of file_exists which can be limited by open_basedir.

Issue #11940

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-12 10:38:47 +01:00
Michal Čihař
2148e7cad8 Implement test for Cookie auth without runkit
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-03 20:21:40 +01:00
Michal Čihař
c2b41b829a Wrap header() and headers_sent() in response
This allows us to test the code without using runkit. Currenly only
AuthenticationHttp is migrated to new code, but others will follow.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-03 19:49:05 +01:00
Michal Čihař
431450a237 Make test run even without runkit
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-03 19:49:05 +01:00
Michal Čihař
db6af1be82 Simplify code
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-03 17:57:19 +01:00
Michal Čihař
2a9fb73f92 Remove PmaAbsoluteUri from redirects
This is no longer needed as per RFC 7231.

Issue #11412

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-03 14:32:14 +01:00
Michal Čihař
ac9714cf6a Autoloading for phpseclib
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-01 21:53:53 +01:00
Michal Čihař
7b58acf62e Merge branch 'QA_4_5' 2016-02-01 21:46:33 +01:00
Madhura Jayaratne
30ac5b6094 Fix #11892 Error with PMA 4.4.15.3
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2016-01-29 08:33:42 +11:00
Michal Čihař
b69fa1499f Bring back file inclustion, just remove version check from it
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-28 17:08:19 +01:00
Michal Čihař
072ff0b38a Remove checks for PHP versions we no longer support
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-28 16:08:47 +01:00
Michal Čihař
37004337ab Merge commit 'a478437e0ee4d74ec5036cb32e165da002303dd1' 2016-01-14 09:10:43 +01:00
Deven Bansod
3b8644318a Fix #11752 , analyse the grant strings to perform checks for privileges instead of running all the test queries on mysql db
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-01-08 16:48:57 +05:30
Michal Čihař
55b317c699 Remove /*overload*/ prefix from mb_* calls
I believe this was temporary flagging to see which code is migrated and
can be safely removed now.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-04 16:35:28 +01:00
Marc Delisle
66c15daba0 Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-06 08:01:07 -05:00
Marc Delisle
357b1b4757 Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-04 09:05:42 -05:00
Marc Delisle
2607023281 Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-03 11:00:01 -05:00
Marc Delisle
9ee3931c09 Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-03 10:43:10 -05:00
Michal Čihař
46a70dba88 Remove unused method (parent class defines it)
Signed-off-by: Michal Čihař <michal@cihar.com>
2015-12-01 13:54:04 +01:00
Marc Delisle
ab7942be89 Fix merge conflicts
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-11-29 07:29:32 -05:00
Deven Bansod
77f220cee5 Merge branch 'QA_4_5'
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>

Conflicts:
	libraries/plugins/auth/AuthenticationCookie.php
2015-11-26 19:29:18 +05:30
Deven Bansod
8eb712579d Fixes #11693 : Flush privileges overusage - related to issue 11597
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2015-11-26 19:25:18 +05:30
Hugues Peccatte
154a942145 Remove side effects in declaration files.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-10-27 18:56:40 +01:00
Marc Delisle
8e666ec1b5 Fix merge conflicts
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-10-24 16:35:58 -04:00
Deven Bansod
223a7a5e4e Fix 11597
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2015-10-25 04:27:56 +05:30
Hugues Peccatte
37d2a661c0 Make PHPCS happy.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-10-07 22:49:49 +02:00
Hugues Peccatte
af7eaeb047 Make PHPCS happy.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-10-07 21:51:21 +02:00
Hugues Peccatte
6f4676cdfc Merge remote-tracking branch 'origin/master' into useNamespaces_master 2015-10-04 18:04:49 +02:00
Marc Delisle
fd7c8522ea Clarify method name
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-10-03 10:14:29 -04:00
Hugues Peccatte
71b62bcef9 Merge remote-tracking branch 'origin/master' into useNamespaces_master 2015-09-26 13:50:49 +02:00
Madhura Jayaratne
7ec4bcdbea Use include for files being included conditionally
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-09-22 21:11:11 +10:00
Hugues Peccatte
914cdaa984 Merge remote-tracking branch 'origin/master' into useNamespaces_master 2015-09-19 22:31:36 +02:00
Marc Delisle
0b87f93fec Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-09-19 13:21:17 -04:00
Hugues Peccatte
7185d61649 Set uses instead of absolute namespace.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-12 15:43:39 +02:00
Hugues Peccatte
42c0ebac85 Merge branch 'master' into useNamespaces_master 2015-09-09 22:05:00 +02:00
Marc Delisle
337658a927 Fix merge conflict
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-09-08 11:38:50 -04:00
Marc Delisle
f447cd94b0 Fix merge conflict
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-09-08 11:35:05 -04:00
Madhura Jayaratne
785f4e2711 Fix reCaptcha bypass
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-09-08 07:13:24 +10:00
Hugues Peccatte
70acefd180 Replace Response calls by short calls.
Add missing require.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-05 23:39:02 +02:00
Hugues Peccatte
6c594eb0cf Fix calls.
Remove useless PHPDoc.
Add missing require.
Add missing 'use'.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-05 22:58:47 +02:00
Marc Delisle
a2898d760e Fixes #11463 Cannot redeclare class phpseclib\Crypt\AES
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-09-05 12:20:09 -04:00
Hugues Peccatte
178a6edd38 Add namespace on part of plugins classes.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-05 00:33:42 +02:00
Hugues Peccatte
04b4f723d8 Move libraries/plugins/auth and export classes into a namespace.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-05 00:09:30 +02:00