gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
121,498 Commits 12 Branches 481 Tags 2.4 GiB
d005ea8041
Commit Graph

294 Commits

Author SHA1 Message Date
William Desportes
d005ea8041
Remove some else conditions by using early exits or moving code 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-29 01:30:25 +02:00
William Desportes
c51af5a003
Fix phpstan reported errors 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-28 23:48:27 +02:00
William Desportes
9487604a42
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-28 02:12:17 +02:00
William Desportes
c21738dbf0
Documentation updates 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-28 02:04:48 +02:00
Maurício Meneghini Fauth
5750dfb1bb
Extract method to get edit user group modal form 
Creates a new route: /server/user-groups/edit-form

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-26 22:59:09 -03:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-20 22:35:21 -03:00
William Desportes
41e0d4dfb7
Use the Query\Compatibility class to simply and remove duplicate checks 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-20 20:57:10 +02:00
William Desportes
e46cbf6519
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-20 20:19:08 +02:00
David Sinquin
86f239ca44
Fix password management for Percona Server. 
Simply stick to what is done for Oracle MySQL.

Signed-off-by: David Sinquin <david.sinquin@gandi.net>
 2021-04-20 18:34:17 +02:00
William Desportes
8fbb01a684
Merge branch 'origin/QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-19 21:51:45 +02:00
Maurício Meneghini Fauth
59e4dae52a
Remove invalid inline doc comments 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-18 14:49:28 -03:00
Saksham Gupta
9a9b7ad335 Fix #16404 Password generation fix after new user creation failure 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Check error on SQL query

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Lint fix

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add comments

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
 2021-04-15 20:34:35 +05:30
Maurício Meneghini Fauth
4273634c17
Extract getActiveAuthPlugins method to Plugins class 
Extracts the getActiveAuthPlugins method from the
PhpMyAdmin\Server\Privileges class to the PhpMyAdmin\Server\Plugins
class, rename it to getAuthentication and adds tests.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-14 16:07:40 -03:00
Maurício Meneghini Fauth
14532f2f07
Rename variables to use camelCase in Server\Privileges 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-25 14:03:26 -03:00
William Desportes
30d05f40c2
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-20 19:24:35 +01:00
William Desportes
33d6b0cf3c
Fix a PHP notice "Undefined index: pred_username" 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-20 17:43:43 +01:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 14:18:35 -03:00
William Desportes
c8360eaf8b
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-02-18 02:07:49 +01:00
William Desportes
b9ee5c708f
Fix "Undefined index: selected_usr" when the user tried to delete no selected user 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-02-17 20:25:01 +01:00
Maurício Meneghini Fauth
1e5fbd57fc
Create Twig\AssetExtension and image Twig function 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-01-28 16:09:17 -03:00
William Desportes
9abf4cb109
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-01-22 00:37:51 +01:00
Prashant Tholia
ebff28171c
Fix #16463 - 'REFERENCES' privilege checkbox's title 
Set different title messages depending on database and database version for 'REFERENCES' field in user 'Edit Preferences' form.

Co-Authored-By: William Desportes <williamdes@wdes.fr>
Signed-off-by: Prashant Tholia <prashant.tholia@gmail.com>
 2021-01-22 00:05:43 +01:00
Maurício Meneghini Fauth
443e4289c3
Replace user groups jQuery UI's dialog with a modal 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-01-12 17:28:22 -03:00
Maurício Meneghini Fauth
4ad6e2ea4e
Use Bootstrap's pagination for user accounts page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-12-29 17:59:59 -03:00
Maurício Meneghini Fauth
5178f76f95
Move fieldset CSS style to the .pma-fieldset class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-12-28 19:46:40 -03:00
Maurício Meneghini Fauth
d23be36126
Fix some errors found by PHPStan and Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-26 15:20:44 -03:00
Saksham Gupta
be3905944f Fixes: https://github.com/phpmyadmin/phpmyadmin/issues/16477 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fix db Edit privileges

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fix conflict

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add missing bracket

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fix Lint

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
 2020-11-16 02:09:54 +05:30
Isaac Bennetch
4d99680147 Force BINARY comparison when looking at privileges. 
Otherwise, a mismatch between the "Server connection collation" dropdown
and the system tables/views causes an error message.

Fixes: #15463

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
 2020-10-29 09:23:38 -04:00
Maurício Meneghini Fauth
a83ec78ebf Make DatabaseInterface::isUserType method private 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-24 00:40:03 -03:00
Maurício Meneghini Fauth
71d9a8f760 Remove is_grantuser and is_createuser PHP globals 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-23 22:58:49 -03:00
Maurício Meneghini Fauth
ac9bccf67d Replace $GLOBALS['dbi'] with global $dbi 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-11 09:24:21 -03:00
Maurício Meneghini Fauth
e66be179ca Use camel case naming for class members 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-05 10:37:07 -03:00
Maurício Meneghini Fauth
bb32ba6d9c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-04 12:31:43 -03:00
Maurício Meneghini Fauth
e7c8e20edb Fix some type errors detected by PHPStan 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-02 00:37:23 -03:00
Maurício Meneghini Fauth
f2e49a92c6 Fix some type errors detected by PHPStan 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-30 19:23:01 -03:00
Maurício Meneghini Fauth
d36d9437a1 Fix some errors detected by Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-16 21:03:53 -03:00
Maurício Meneghini Fauth
40d2a1c605
Merge pull request #16338 from mauriciofauth/replication 
Refactor the ReplicationInfo class
 2020-09-12 09:07:33 -03:00
Maurício Meneghini Fauth
cd862d4f00 Remove replication_info global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-12 09:04:44 -03:00
Maurício Meneghini Fauth
34dd2a61f8 Remove strPrivDesc* global variables 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-11 17:22:30 -03:00
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
03d8314bba Create the PhpMyAdmin\Profiling class 
Extracts Profiling related methods to the Profiling class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-26 16:02:30 -03:00
William Desportes
d63a72ad51
Fixes #16278 - Remove underscore prefix from property names 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-08-06 15:46:39 +02:00
Maurício Meneghini Fauth
c92663adbb Move ChangePassword::getHtml to Server\Privileges class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-29 19:12:35 -03:00
Maurício Meneghini Fauth
2358b9c4f9 Fix missing property type hints 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-22 21:42:22 -03:00
Maurício Meneghini Fauth
2bf9d2bf68 Ignore too long lines warn in Server\Privileges class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-22 18:26:53 -03:00
William Desportes
9e39713b5a
Document "DELETE HISTORY" for translators 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-07-22 21:45:02 +02:00
Maurício Meneghini Fauth
ae975e594e Remove Privileges::getHtmlForUserGroupDialog method 
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-17 12:42:58 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
05c62ad1a8 Fix some PHPStan errors 
Fixes "Cannot access offset on array" errors.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-02 16:12:07 -03:00