Commit Graph

6268 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
a70b08d62f
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-21 12:48:23 -03:00
Maurício Meneghini Fauth
f7f85bb450
Merge branch 'QA_5_1' into QA_5_2
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-21 12:37:29 -03:00
Maurício Meneghini Fauth
366c586330
Add better error handling when IndexedDB is not working
- Fixes #16853

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-20 19:20:34 -03:00
Maurício Meneghini Fauth
a8ca6894a7
Create the validator-messages.js file
- Extracts the validator messages from the javascript/variables template
  into a new file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-15 15:13:59 -03:00
Maurício Meneghini Fauth
e514bda5b1
Create datetimepicker.js file
Extracts the datepicker and timepicker translations logic from
the javascript/variables template into the new datetimepicker.js file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-15 14:04:46 -03:00
Maurício Meneghini Fauth
c482cd47ef
Remove gridEditingConfig JS global
- Uses data attribute instead.
- Uses Bootstrap's tooltip instead of the jQuery plugin.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-14 23:19:29 -03:00
Maurício Meneghini Fauth
a0337bf220
Refactor JavaScriptMessagesController controller
- Removes the dependency of the cfg and theme PHP globals.
- Handles the errors when encoding the messages to JSON.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-14 18:09:57 -03:00
Maurício Meneghini Fauth
835b9b356d
Merge pull request #17372 from CommanderRoot/remove-deprecated-js-substr
Remove usage of deprecated String.prototype.substr()
2022-02-13 09:54:00 -03:00
Tobias Speicher
44b528fb00 Remove usage of deprecated String.prototype.substr()
String.prototype.substr() is deprecated (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we either switch to String.prototype.substring() or something else appropriate for the use case
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2022-02-12 00:04:47 +01:00
Maurício Meneghini Fauth
e46f0435f4
Use webpack to sync js files
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-10 13:43:35 -03:00
Maurício Meneghini Fauth
fb18d3b3a9
Extract functions from registerOnload in server/privileges.js
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-09 16:51:07 -03:00
Maurício Meneghini Fauth
fece1cc0ab
Extract function from registerOnload in server/plugins.js
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-07 21:21:18 -03:00
Maurício Meneghini Fauth
53172b0068
Extract event handlers in server/databases.js file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-07 21:14:14 -03:00
William Desportes
a7b222db8a
Merge branch 'origin/QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-02-06 15:47:17 +01:00
William Desportes
65c9f49c1e
Merge branch 'QA_5_1' into QA_5_2
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-02-06 15:45:57 +01:00
Kamil Tekiela
e84e1bda02
Fix #17239 - header row show/hide columns buttons on each line after hover are shown on each row
Ref: 97810b3a21

igned-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-02-06 15:06:55 +01:00
Maurício Meneghini Fauth
28892052df Refactor home.js file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-06 08:13:05 -03:00
William Desportes
fbe257db4f
Ref #17342 - Mark sql format as non processing on request error
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-02-06 02:18:38 +01:00
Maurício Meneghini Fauth
6698616206
Merge branch 'QA_5_2' 2022-02-05 14:32:04 -03:00
Maurício Meneghini Fauth
7e5a031436 Fix More button bug in table structure page
Fixes #17292

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-04 20:29:35 -03:00
Maurício Meneghini Fauth
10d09f4876
Merge branch 'QA_5_2'
[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-03 18:11:54 -03:00
Maurício Meneghini Fauth
f911458b71
Fix CSS class name conflict in navigation tree
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-03 18:09:21 -03:00
Shucon Tech
ee57160671
Replace Page settings dialog with modal (#17127)
* Replace Page settings dialog with modal

Signed-off-by: Saksham Gupta <shucontech@gmail.com>

Fix max-width class

Signed-off-by: Saksham Gupta <shucontech@gmail.com>

* Fix failing tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-01 10:49:48 -03:00
Shucon Tech
4a606ee594
Replace Add Index dialog with modal (#17125)
* Replace Add Index dialog with modal

Signed-off-by: Saksham Gupta <shucontech@gmail.com>

Index type selection box

Signed-off-by: Saksham Gupta <shucontech@gmail.com>

Fix open bugs

Signed-off-by: Saksham Gupta <shucontech@gmail.com>

* Fix failing tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-31 19:51:56 -03:00
Shucon Tech
c3889257cf
Replace Change Password dialog to modal (#17116)
* Replace Change Password dialog to modal

Signed-off-by: Saksham Gupta <shucontech@gmail.com>

* Bootstrap modal class

Signed-off-by: Saksham Gupta <shucontech@gmail.com>

* Fix failing tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-30 18:10:20 -03:00
Shucon Tech
745c39bf9c
Replace function Confirm dialog with modal (#17115)
* Replace function Confirm dialog with modal

Signed-off-by: Saksham Gupta <shucontech@gmail.com>

* Fix failing tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-28 21:54:14 -03:00
Maurício Meneghini Fauth
6c52955c61
Merge branch 'QA_5_1' into QA_5_2
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-28 17:21:15 -03:00
Maurício Meneghini Fauth
265e807929
Fix broken pagination links in the navigation sidebar
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-27 17:38:27 -03:00
Maurício Meneghini Fauth
0bee94b27e
Merge branch 'QA_5_1-security' into master-security
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-11 14:31:56 -03:00
Maurício Meneghini Fauth
02e8588404
Merge branch 'QA_4_9-security' into QA_5_1-security
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-10 18:39:23 -03:00
Maurício Meneghini Fauth
4fd7aa7a2c
Use POST for Navigation's aPath and vPath
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-10 12:19:44 -03:00
Maurício Meneghini Fauth
58ed5bfa9e
Extract Simulate DML action from ImportController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-27 18:37:15 -03:00
Kamil Tekiela
97810b3a21 Fix bug #17239
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-26 23:10:34 +00:00
Maurício Meneghini Fauth
1e542cd621
Replace vendor_config.php constants with an array
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-26 16:48:56 -03:00
Maurício Meneghini Fauth
2a4b170a34
Merge branch 'QA_5_1'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-21 13:13:09 -03:00
Maurício Meneghini Fauth
9308850381
Fix double encoding when droping columns
Related to #17247.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-21 13:01:40 -03:00
Maurício Meneghini Fauth
fa5c684f27
Replace the master/slave terminology
Replaces master with primary and slave with replica.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-18 14:26:56 -03:00
Kamil Tekiela
83d950ed40 Bug fix: Fix triple HTML encoding
Some values were encoded into HTML entities thrice. This commit removes
unnecessary HTML escaping.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-14 12:21:36 +00:00
William Desportes
f718f475e4
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-12-12 19:35:54 +01:00
jonahtanjz
cecf786b0e Extract <em> tag for NULL values when copying to clipboard
Signed-off-by: jonahtanjz <jonahtanjz8@gmail.com>
2021-12-10 18:36:16 +08:00
Maurício Meneghini Fauth
fbd5b0a67c
Redesign the export/import pages to use Bootstrap components
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-25 13:37:47 -03:00
Kamil Tekiela
51f4017b32
Refactor destroy controller (#17194)
* Remove redundant conditions

They were always true. First, the variable is set to -1.
If the variable is -1, then set it to Message.
If the variable is Message then set the JSON array. All of this is
redundant.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $sqlQuery is not used anywhere

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Enforce $selected to be an array

I can't remove it as it is a global. Previously, it was set to a POST
variable. Since we validate that the variable is set and is not null,
we can use the value from $params. If we validate that it's also an
array we can replace for loop with foreach.
There is no passing by reference, so this change should be safe.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace $rebuildDatabaseList with input validation

The validation message says 'No databases selected.' so I assume that
we should check that we actually got at least one entry in the list.
If that is true, then the $rebuildDatabaseList is not needed and the
condition redundant.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* drop_selected_dbs is always set and is redundant

I am not sure if this is necessary. The AJAX request sends a value of "1"
but the code doesn't really do anything with it other than checking if
it is actually set. Is there some other path possible?

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Flatten the array with a single element

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant isset

The variable is set, so !isset === is_null. Why check for null if we can
check just for !is_array.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update psalm-baseline.xml

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Adhere to the coding standard

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-11-19 14:26:04 -03:00
Maurício Meneghini Fauth
b6ea050aef
Use Bootstrap's dropdown for table structure's More button
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-07 16:27:56 -03:00
Maurício Meneghini Fauth
bd95eb7c20
Merge branch 'QA_5_1'
- Bumps Bootstrap to v5.1.3

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-02 14:36:45 -03:00
Maurício Meneghini Fauth
3f279e47ea
Upgrade JavaScript dependencies
- Bumps Bootstrap to v4.6.1
- Bumps CodeMirror to v5.63.3
- Bumps OpenLayers to v6.9.0

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-02 13:01:08 -03:00
Maurício Meneghini Fauth
220ed30ef8
Remove printview.css theme files
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-10-31 17:35:55 -03:00
Maurício Meneghini Fauth
18c8a7d160
Change create table form to use Bootstrap's card
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-10-30 17:23:36 -03:00
Saksham Gupta
3149ee8443 Replace Create view dialog with modal
Signed-off-by: Saksham Gupta <shucontech@gmail.com>

Fix code quality

Signed-off-by: Saksham Gupta <shucontech@gmail.com>
2021-10-02 19:57:46 +05:30
Maurício Meneghini Fauth
c68b6a01a7
Merge pull request #17119 from shucontech/enum_editor_modal
Replace ENUM/SET editor dialog with modal
2021-10-01 14:00:39 -03:00