Commit Graph

4100 Commits

Author SHA1 Message Date
Kamil Tekiela
d043ceedc6 Refactor $sql_data
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:46:27 +00:00
Kamil Tekiela
ff4614d581 Use null-coalesce
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:45:31 +00:00
Kamil Tekiela
c2edf8534c Change empty for stricter comparison
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:45:31 +00:00
Kamil Tekiela
ade85420a8 Inline runQueryPost()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

import
2022-03-17 20:45:31 +00:00
Kamil Tekiela
ad0acda8b2 Remove parameter
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:23:25 +00:00
Kamil Tekiela
009a92c545 Set parameter type
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:23:25 +00:00
Kamil Tekiela
69b5e5e159 Fix phpdoc types
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:23:25 +00:00
Kamil Tekiela
a09fa965a4 Refactor the for loop
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:23:25 +00:00
Kamil Tekiela
0def6a56fc Remove boolean use of strcmp()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:23:25 +00:00
Kamil Tekiela
b3759ba7e4 Remove count()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:23:25 +00:00
Kamil Tekiela
06e4c77f64 Remove redundant cast
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:23:25 +00:00
Kamil Tekiela
5c8a4e90a0 Remove pass-by-ref
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:23:25 +00:00
Maurício Meneghini Fauth
217c6357e8
Fix FavoriteTableController error when missing db param
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-15 17:18:55 -03:00
Maurício Meneghini Fauth
9faaad41ac
Fix export not working
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-15 17:12:37 -03:00
Maurício Meneghini Fauth
8c6d3d8b3a
Remove the 400 http status code from AbstractController::checkParameters
Related to #17429

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-15 16:52:18 -03:00
Maurício Meneghini Fauth
5a75ebc7c7
Refactor Privileges::getRequireClause method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-14 15:15:21 -03:00
Maurício Meneghini Fauth
d70644ecf0 Extract results nav buttons into table template
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-13 21:26:15 -03:00
Maurício Meneghini Fauth
c0941401c1
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-11 14:26:19 -03:00
Maurício Meneghini Fauth
2653b2942b
Merge branch 'QA_5_1' into QA_5_2
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-11 13:02:15 -03:00
Maurício Meneghini Fauth
bc4397f28a
Refactor Transformation\WrapperController
Removes superglobals.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-10 20:32:19 -03:00
Maurício Meneghini Fauth
48fe211426
Add return type for Transformations getOptions and getMime
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-10 19:58:45 -03:00
Maurício Meneghini Fauth
5950693fb3
Fix possible undefined globals
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
e16682d57a
Remove IS_TRANSFORMATION_WRAPPER constant
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-09 21:59:06 -03:00
Maurício Meneghini Fauth
754e15ebab
Extract method to set globals in ExportController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-08 19:18:50 -03:00
Maurício Meneghini Fauth
ec4baa6583
Remove calls of Util::getValueByKey where path doesn't have a dot
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-08 14:30:19 -03:00
Maurício Meneghini Fauth
f940693c75
Move Util::checkParameters method to the AbstractController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-07 22:59:33 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
4448b57253
Merge pull request #17350 from jonahtanjz/17348-fix-html-code-formatting
Fix #17348 - Resolve formatting of <code> in Preferences > Export
2022-03-06 19:48:12 -03:00
William Desportes
a4417e07df
Ref #17418 - Fix #16746 - Remove the use of deprecated strftime in OpenDocument exports
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-03-05 23:41:06 +01:00
William Desportes
639175db9e
Fix a typo on OpenDocument class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-03-05 22:49:11 +01:00
William Desportes
71efab6ff3
Update phpstan and psalm baseline
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-03-05 21:05:12 +01:00
William Desportes
1cad1f5808
Merge #17191 - Fix #17188 - GIS visualization with edited query
Pull-request: #17191
Fixes: #17188

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-03-05 19:33:36 +01:00
William Desportes
049c6f8771
Merge #17377 - Fix incorrect usage of escapeMysqlWildcards
Pull-request: #17377

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-03-05 18:49:15 +01:00
Maurício Meneghini Fauth
20ebad0ec5
Merge pull request #17410 from kamil-tekiela/pr/17211
transfer the HTML content in InsertEdit.php for a twig file
2022-03-04 12:24:03 -03:00
Maurício Meneghini Fauth
10d31380ef
Merge pull request #17376 from kamil-tekiela/getDbInfo-mangles-tables-with-numerical-names
getDbInfo mangles table with numerical names
2022-03-04 12:16:52 -03:00
Maurício Meneghini Fauth
9b5b210fc4
Remove action global var from ColumnsDefinition class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-03 17:41:52 -03:00
Maurício Meneghini Fauth
a1a778d475
Fix some issues reported by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-03 12:36:34 -03:00
Maurício Meneghini Fauth
c0eb02d7d3
Extract ColumnsDefinition construction from controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-02 18:59:27 -03:00
Maurício Meneghini Fauth
f8bba12d61
Rename DatabaseInterface variables to use camel case
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-01 14:30:01 -03:00
Maurício Meneghini Fauth
d7515aa474
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-28 15:51:59 -03:00
Maurício Meneghini Fauth
7aec65222a
Fix an issue reported by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-28 12:21:11 -03:00
Maurício Meneghini Fauth
40135c26cc
Add basic test for Table\DeleteRowsController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-25 16:44:49 -03:00
Maurício Meneghini Fauth
45a3a959a4
Merge pull request #17375 from kamil-tekiela/Escaping-issues
Fix broken escaping on Insert page
2022-02-25 12:13:15 -03:00
Maurício Meneghini Fauth
60f75803e8
Add basic test for Table\DropColumnController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-24 22:29:22 -03:00
Maurício Meneghini Fauth
58e1583840
Move advisory_rules files to the Advisory\Rules class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-24 14:41:41 -03:00
Maurício Meneghini Fauth
81cfa99df4
Move Advisor class to PhpMyAdmin\Advisory namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-24 13:16:19 -03:00
Maurício Meneghini Fauth
687a83923a
Add basic test for Table\GetFieldController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-24 12:54:43 -03:00
Maurício Meneghini Fauth
cfc64619bf
Fix Table\ImportControllerTest failing test
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-24 11:48:22 -03:00
Maurício Meneghini Fauth
055c878bae
Add basic test for Table\GisVisualizationController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-23 21:50:22 -03:00
Maurício Meneghini Fauth
4c8691b6dd
Add basic test for Table\ImportController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-23 20:19:23 -03:00