gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
123,574 Commits 12 Branches 481 Tags 2.4 GiB
d043ceedc6
Commit Graph

1077 Commits

Author SHA1 Message Date
Kamil Tekiela
d043ceedc6 Refactor $sql_data 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-03-17 20:46:27 +00:00
Maurício Meneghini Fauth
217c6357e8
Fix FavoriteTableController error when missing db param 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-15 17:18:55 -03:00
Maurício Meneghini Fauth
9faaad41ac
Fix export not working 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-15 17:12:37 -03:00
Maurício Meneghini Fauth
8c6d3d8b3a
Remove the 400 http status code from AbstractController::checkParameters 
Related to #17429

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-15 16:52:18 -03:00
Maurício Meneghini Fauth
bc4397f28a
Refactor Transformation\WrapperController 
Removes superglobals.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-10 20:32:19 -03:00
Maurício Meneghini Fauth
5950693fb3
Fix possible undefined globals 
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
e16682d57a
Remove IS_TRANSFORMATION_WRAPPER constant 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-09 21:59:06 -03:00
Maurício Meneghini Fauth
754e15ebab
Extract method to set globals in ExportController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-08 19:18:50 -03:00
Maurício Meneghini Fauth
ec4baa6583
Remove calls of Util::getValueByKey where path doesn't have a dot 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-08 14:30:19 -03:00
Maurício Meneghini Fauth
f940693c75
Move Util::checkParameters method to the AbstractController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 22:59:33 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
10d31380ef
Merge pull request #17376 from kamil-tekiela/getDbInfo-mangles-tables-with-numerical-names 
getDbInfo mangles table with numerical names
 2022-03-04 12:16:52 -03:00
Maurício Meneghini Fauth
9b5b210fc4
Remove action global var from ColumnsDefinition class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-03 17:41:52 -03:00
Maurício Meneghini Fauth
a1a778d475
Fix some issues reported by PHPStan 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-03 12:36:34 -03:00
Maurício Meneghini Fauth
c0eb02d7d3
Extract ColumnsDefinition construction from controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-02 18:59:27 -03:00
Maurício Meneghini Fauth
40135c26cc
Add basic test for Table\DeleteRowsController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-25 16:44:49 -03:00
Maurício Meneghini Fauth
60f75803e8
Add basic test for Table\DropColumnController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-24 22:29:22 -03:00
Maurício Meneghini Fauth
81cfa99df4
Move Advisor class to PhpMyAdmin\Advisory namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-24 13:16:19 -03:00
Maurício Meneghini Fauth
687a83923a
Add basic test for Table\GetFieldController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-24 12:54:43 -03:00
Maurício Meneghini Fauth
a70b08d62f
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-21 12:48:23 -03:00
Maurício Meneghini Fauth
f7f85bb450
Merge branch 'QA_5_1' into QA_5_2 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-21 12:37:29 -03:00
Maurício Meneghini Fauth
69a8c97e67
Merge pull request #17406 from mauriciofauth/add-index-bug 
Fix create index form accepting too many columns
 2022-02-21 11:42:04 -03:00
Maurício Meneghini Fauth
366c586330
Add better error handling when IndexedDB is not working 
- Fixes #16853

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-20 19:20:34 -03:00
Maurício Meneghini Fauth
1cac3baeab
Fix create index form accepting too many columns 
- Fixes #16769

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-20 13:11:30 -03:00
Maurício Meneghini Fauth
a8ca6894a7
Create the validator-messages.js file 
- Extracts the validator messages from the javascript/variables template
  into a new file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-15 15:13:59 -03:00
Maurício Meneghini Fauth
e514bda5b1
Create datetimepicker.js file 
Extracts the datepicker and timepicker translations logic from
the javascript/variables template into the new datetimepicker.js file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-15 14:04:46 -03:00
Maurício Meneghini Fauth
c482cd47ef
Remove gridEditingConfig JS global 
- Uses data attribute instead.
- Uses Bootstrap's tooltip instead of the jQuery plugin.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-14 23:19:29 -03:00
Maurício Meneghini Fauth
a0337bf220
Refactor JavaScriptMessagesController controller 
- Removes the dependency of the cfg and theme PHP globals.
- Handles the errors when encoding the messages to JSON.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-14 18:09:57 -03:00
Kamil Tekiela
50303cd77e Fix numerical keys 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-02-12 20:11:04 +00:00
Maurício Meneghini Fauth
5a34a3bb04
Remove db and table properties from controllers 
Replaces them with their respective globals.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-02 14:48:43 -03:00
Shucon Tech
c3889257cf
Replace Change Password dialog to modal (#17116) 
* Replace Change Password dialog to modal

Signed-off-by: Saksham Gupta <shucontech@gmail.com>

* Bootstrap modal class

Signed-off-by: Saksham Gupta <shucontech@gmail.com>

* Fix failing tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-30 18:10:20 -03:00
Shucon Tech
745c39bf9c
Replace function Confirm dialog with modal (#17115) 
* Replace function Confirm dialog with modal

Signed-off-by: Saksham Gupta <shucontech@gmail.com>

* Fix failing tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-28 21:54:14 -03:00
Maurício Meneghini Fauth
87f8ece01d
Deprecate the db and table properties from controllers 
The database and table parameters should be got from the server request
or from the respective globals.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-28 20:51:03 -03:00
Maurício Meneghini Fauth
8529de4d88
Merge pull request #17303 from kamil-tekiela/Remove-globals 
Remove globals
 2022-01-28 16:47:16 -03:00
Maurício Meneghini Fauth
a8d514a350
Remove db and table globals from DbTableExists class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-28 16:43:48 -03:00
Kamil Tekiela
47e81a5161 Remove $route global 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-27 11:47:40 +00:00
Isaac Bennetch
985912f58f Fix merge conflicts from security branch 
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
 2022-01-20 12:28:17 -05:00
Maurício Meneghini Fauth
411bacf613
Use Sodium for auth cookies encryption 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-13 18:46:04 -03:00
Maurício Meneghini Fauth
9b3a1f7734
Merge branch 'QA_5_1-security' into master-security 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-13 17:41:16 -03:00
Maurício Meneghini Fauth
44eb12f15a
Improve query params filtering in Setup pages 
Note: 'action_done' was not used since
c962ee4287.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-13 15:05:43 -03:00
Kamil Tekiela
86031d2bf6 Deimplement fetchAssoc() helper 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 22:44:53 +00:00
Maurício Meneghini Fauth
290f026a02
Merge pull request #17272 from kamil-tekiela/queryAsControlUser 
Query as control user
 2022-01-06 21:32:46 -03:00
Kamil Tekiela
73b7094b2b Remove redundant isset 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:22 +00:00
Kamil Tekiela
9afa59487e Collapse if statements into one 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:22 +00:00
Kamil Tekiela
202b17c34c Replace if with coalesce 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:21 +00:00
Kamil Tekiela
f5bb90ebb9 Move queryAsControlUser - Dbal refactoring pt.3 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:31:27 +00:00
Kamil Tekiela
83b4dda1a3 Change QUERY_STORE to QUERY_BUFFERED 
Set the value to 0 instead of 1 and remove all unnecessary usages of this constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-01 01:46:01 +00:00
Kamil Tekiela
47a039d70c Implement ResultInterface & MysqliResult 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-31 23:59:24 +00:00
Maurício Meneghini Fauth
58ed5bfa9e
Extract Simulate DML action from ImportController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 18:37:15 -03:00
Maurício Meneghini Fauth
feca48cc76
Change return type of DatabaseInterface::getError method 
Now, it returns last error message or an empty string instead of false
if no errors occurred.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 14:43:14 -03:00