Maurício Meneghini Fauth
|
5950693fb3
|
Fix possible undefined globals
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2022-03-10 18:05:21 -03:00 |
|
Maurício Meneghini Fauth
|
1438cb211e
|
Replace global keyword with $GLOBALS
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2022-03-07 17:31:11 -03:00 |
|
Maurício Meneghini Fauth
|
687a83923a
|
Add basic test for Table\GetFieldController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2022-02-24 12:54:43 -03:00 |
|
Maurício Meneghini Fauth
|
0bee94b27e
|
Merge branch 'QA_5_1-security' into master-security
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2022-01-11 14:31:56 -03:00 |
|
Maurício Meneghini Fauth
|
02e8588404
|
Merge branch 'QA_4_9-security' into QA_5_1-security
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2022-01-10 18:39:23 -03:00 |
|
Maurício Meneghini Fauth
|
68c1ef8581
|
Populate POST with decrypted params
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2022-01-10 12:19:44 -03:00 |
|
Maurício Meneghini Fauth
|
d057b68aa1
|
Add unit tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2022-01-10 12:19:43 -03:00 |
|
Kamil Tekiela
|
83b4dda1a3
|
Change QUERY_STORE to QUERY_BUFFERED
Set the value to 0 instead of 1 and remove all unnecessary usages of this constant
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
|
2022-01-01 01:46:01 +00:00 |
|
Kamil Tekiela
|
47a039d70c
|
Implement ResultInterface & MysqliResult
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
|
2021-12-31 23:59:24 +00:00 |
|
Maurício Meneghini Fauth
|
44fe103b9c
|
Remove @access annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-12-22 11:43:45 -03:00 |
|
Kamil Tekiela
|
3d8a167eff
|
Remove Chrome < 43 check as this version is no longer supported
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
|
2021-12-08 15:26:52 +00:00 |
|
Kamil Tekiela
|
ce527035c2
|
PHPStan checkAlwaysTrueCheckTypeFunctionCall fixes
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
|
2021-12-08 15:26:52 +00:00 |
|
Kamil Tekiela
|
be87571da6
|
PHPStan checkAlwaysTrueStrictComparison fixes
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
|
2021-12-08 15:26:52 +00:00 |
|
Maurício Meneghini Fauth
|
f00d70cccb
|
Remove useless whitespaces
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-09-15 17:05:40 -03:00 |
|
Maurício Meneghini Fauth
|
9f3510d11a
|
Add bool return type where possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-09-14 20:11:51 -03:00 |
|
Maurício Meneghini Fauth
|
7f6472b2c2
|
Add void return type where possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-09-13 15:29:11 -03:00 |
|
Maurício Meneghini Fauth
|
8f2f3eff40
|
Remove the Core::isValid method
This improves the type checking and simplifies the code.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-09-02 13:20:50 -03:00 |
|
Maurício Meneghini Fauth
|
5725516656
|
Inline Core::ifSetOr method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-09-01 13:29:05 -03:00 |
|
William Desportes
|
f5f13a8ec2
|
Remove non needed else conditions
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
2021-07-21 01:33:59 +02:00 |
|
Maurício Meneghini Fauth
|
6ae07c96fb
|
Replace strpos !== false with str_contains
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-07-09 22:30:42 -03:00 |
|
Maurício Meneghini Fauth
|
355f6d9d20
|
Remove PhpMyAdmin\Config::enableBc method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-07-09 13:59:04 -03:00 |
|
Maurício Meneghini Fauth
|
262cbe45b9
|
Move some Core methods to Common class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-07-06 16:52:54 -03:00 |
|
Maurício Meneghini Fauth
|
a0d91ec153
|
Move common.inc.php to classes/Common.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-07-06 14:00:44 -03:00 |
|
Maurício Meneghini Fauth
|
81de66a019
|
Merge branch 'QA_5_1'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-07-05 17:26:46 -03:00 |
|
Maurício Meneghini Fauth
|
282fbe76c5
|
Fix case where $_SERVER['REQUEST_METHOD'] is undefined
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/16991
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-07-05 17:23:32 -03:00 |
|
Maurício Meneghini Fauth
|
c985faf9a1
|
Build response headers before sending them out
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-07-01 16:08:03 -03:00 |
|
Maurício Meneghini Fauth
|
9adaa912e1
|
Rename Response class to ResponseRenderer
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-06-30 12:35:22 -03:00 |
|
Maurício Meneghini Fauth
|
041542d16b
|
Use early exit for Core::fatalError method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-06-14 12:41:49 -03:00 |
|
Maurício Meneghini Fauth
|
1c084de30b
|
Fix coding standard errors
Related to 62f142c9fa.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-06-03 16:50:33 -03:00 |
|
William Desportes
|
77b5e402c5
|
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
2021-05-11 01:20:20 +02:00 |
|
William Desportes
|
db01d6a9da
|
Remove some else conditions by using early exits or moving code
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
2021-04-29 01:18:39 +02:00 |
|
Liviu-Mihail Concioiu
|
1c8f9b4d23
|
Replace secure.php.net with www.php.net and remove Polish and Persian from PHP documentation
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
|
2021-04-26 14:32:03 +02:00 |
|
Maurício Meneghini Fauth
|
8d0c2a339c
|
Move both operands of an assignment to the same line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-04-20 22:35:21 -03:00 |
|
Maurício Meneghini Fauth
|
59e4dae52a
|
Remove invalid inline doc comments
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-04-18 14:49:28 -03:00 |
|
Maurício Meneghini Fauth
|
44bdd1d390
|
Rename $url_params global to $urlParams
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-03-24 22:48:14 -03:00 |
|
Maurício Meneghini Fauth
|
6b0a10d8ca
|
Rename the error_handler global to use camel case
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-03-16 12:11:51 -03:00 |
|
Maurício Meneghini Fauth
|
7e33d227f5
|
Rename the PMA_Config global variable to config
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-03-08 15:03:12 -03:00 |
|
William Desportes
|
7bd3ec6b35
|
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
2021-03-06 21:25:54 +01:00 |
|
William Desportes
|
4aa629c6f4
|
Move the container builder loading to the Core class
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
2021-03-06 17:52:46 +01:00 |
|
Maurício Meneghini Fauth
|
d83abf63e7
|
Use PSR-12 for control structures spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-03-05 15:27:03 -03:00 |
|
Maurício Meneghini Fauth
|
0b8edc5bde
|
Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-03-05 14:18:35 -03:00 |
|
William Desportes
|
005b40ce99
|
Do not remove a non existing cookie
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
2021-01-24 23:55:38 +01:00 |
|
William Desportes
|
5abcae9255
|
Fixed some typos in the code base
I used code spell checker and did all the libraries/classes/*.php files one by one.
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
2020-11-01 22:46:01 +01:00 |
|
Maurício Meneghini Fauth
|
ac9bccf67d
|
Replace $GLOBALS['dbi'] with global $dbi
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-10-11 09:24:21 -03:00 |
|
Maurício Meneghini Fauth
|
bb32ba6d9c
|
Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-10-04 12:31:43 -03:00 |
|
Maurício Meneghini Fauth
|
cbaa67ea6c
|
Fix some type errors detected by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-10-02 14:11:58 -03:00 |
|
Maurício Meneghini Fauth
|
f2e49a92c6
|
Fix some type errors detected by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-09-30 19:23:01 -03:00 |
|
Maurício Meneghini Fauth
|
03d8314bba
|
Create the PhpMyAdmin\Profiling class
Extracts Profiling related methods to the Profiling class.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-08-26 16:02:30 -03:00 |
|
Maurício Meneghini Fauth
|
0e3a82bd86
|
Remove Display\Error class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-07-29 23:08:29 -03:00 |
|
Maurício Meneghini Fauth
|
b4301b4c17
|
Extract method for check profiling
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-07-25 01:22:06 -03:00 |
|
