Commit Graph

73 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
5950693fb3
Fix possible undefined globals
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-07 17:31:11 -03:00
Kamil Tekiela
47e81a5161 Remove $route global
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-27 11:47:40 +00:00
Maurício Meneghini Fauth
44fe103b9c
Remove @access annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-22 11:43:45 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
8f2f3eff40
Remove the Core::isValid method
This improves the type checking and simplifies the code.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-02 13:20:50 -03:00
Maurício Meneghini Fauth
5725516656
Inline Core::ifSetOr method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-01 13:29:05 -03:00
Maurício Meneghini Fauth
cd1b8a9b77
Fix some errors found by PHPStan and Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-22 15:14:24 -03:00
Maurício Meneghini Fauth
1061a85b5e
Extract the HTML from the Footer::getSelfLink method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-03 18:36:45 -03:00
William Desportes
75c148b885
Update psalm baseline and include ignores
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-29 00:43:20 +02:00
William Desportes
dcc52b063a
Fix doc blocks
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-29 00:36:13 +02:00
Maurício Meneghini Fauth
90778eecf7
Upgrade phpmyadmin/coding-standard to 3.0.0
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-19 02:20:46 -03:00
Maurício Meneghini Fauth
045206429b
Extract the HTML from the Footer::getDemoMessage
Renames getDemoMessage to getGitRevisionInfo.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-26 21:32:40 -03:00
Maurício Meneghini Fauth
d900172b87
Suppress Psalm MissingFile error for revision-info file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-26 20:33:00 -03:00
William Desportes
7c2ebb163c
Write revision info from a CLI
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-25 21:42:23 +01:00
Maurício Meneghini Fauth
6b0a10d8ca
Rename the error_handler global to use camel case
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-16 12:11:51 -03:00
William Desportes
0c5aa81c78
Inject the error report modal and avoid sending depending on SendErrorReports
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-15 18:22:30 +01:00
Maurício Meneghini Fauth
207901e992
Remove the js/src/microhistory.js file
There is no need for the MicroHistory anymore now that the History
API is available in all supported browsers.

Also removes the jQuery hashchange plugin.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-10 17:06:21 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
4f574e53c3
Replace error report jquery-ui's dialog with a modal
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-12 17:28:23 -03:00
Maurício Meneghini Fauth
4873c32273 Remove DatabaseInterface::isUserType method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-25 20:53:50 -03:00
Maurício Meneghini Fauth
a83ec78ebf Make DatabaseInterface::isUserType method private
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-24 00:40:03 -03:00
Maurício Meneghini Fauth
ac9bccf67d Replace $GLOBALS['dbi'] with global $dbi
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-11 09:24:21 -03:00
William Desportes
d63a72ad51
Fixes #16278 - Remove underscore prefix from property names
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-08-06 15:46:39 +02:00
charliewindred
ca3c5e17b0 Remove underscore prefix from method names
Removed underscore from method names for PSR-12 compliance.
Signed-off-by: charliewindred <charliewindred@gmail.com>
2020-06-02 16:44:16 +01:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 18:08:20 -03:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
William Desportes
718ceadeb6
Merge branch 'QA_5_0-security' into master-security
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-22 01:23:51 +01:00
William Desportes
28bdc02c3c
Merge branch 'QA_4_9-security' into QA_5_0-security
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-22 01:19:16 +01:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567)
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
Maurício Meneghini Fauth
1119de642b Escape Git information on the index page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-18 18:03:53 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
4077c61b2e Remove support for target URL param for FAQ 1.34
Use the route parameter instead.

https://docs.phpmyadmin.net/en/latest/faq.html#faq1-34

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-26 12:23:01 -03:00
Maurício Meneghini Fauth
8ab7e28a98 Fix selfurl not containing the route parameter
Adds route parameter and removes empty parameters from selfurl.

Fixes #15418

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-08 01:59:48 -03:00
Maurício Meneghini Fauth
4bc08bb098 Fix some errors detected by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-31 20:59:24 -03:00
Maurício Meneghini Fauth
0f23a622bc Use the router for the server privileges page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-23 02:48:02 -03:00
Maurício Meneghini Fauth
7ee9ae2608 Rename js/microhistory.js variables to use camel case
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-29 16:35:44 -03:00
Maurício Meneghini Fauth
b0e5a9ac59 Extract HTML from Footer::getDisplay()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-04-19 16:39:24 -03:00
Maurício Meneghini Fauth
ae20364830 Upgrade phpmyadmin/coding-standard to v1.0
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-08 01:26:26 -02:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00