Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
f911458b71
Fix CSS class name conflict in navigation tree
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-03 18:09:21 -03:00
Isaac Bennetch
985912f58f
Fix merge conflicts from security branch
...
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2022-01-20 12:28:17 -05:00
Maurício Meneghini Fauth
0bee94b27e
Merge branch 'QA_5_1-security' into master-security
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-11 14:31:56 -03:00
Maurício Meneghini Fauth
02e8588404
Merge branch 'QA_4_9-security' into QA_5_1-security
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-10 18:39:23 -03:00
Maurício Meneghini Fauth
6f0d19f394
Do not encrypt params if used in data-post attribute
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-10 12:19:43 -03:00
Kamil Tekiela
2edc9da063
Deimplement dataSeek() helper
...
There were only two usages remaining. This helper isn't needed anymore.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-07 23:22:49 +00:00
Kamil Tekiela
f5bb90ebb9
Move queryAsControlUser - Dbal refactoring pt.3
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-06 19:31:27 +00:00
Kamil Tekiela
47a039d70c
Implement ResultInterface & MysqliResult
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-31 23:59:24 +00:00
Maurício Meneghini Fauth
d84af02945
Create VO classes for each RelationParameters features
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
c4575fd48b
Add methods to check for RelationParameters features
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-11 08:10:40 -03:00
Maurício Meneghini Fauth
b2a51c4d84
Create the RelationParameters value object
...
Replaces the $cfgRelation array with the RelationParameters value
object.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-14 18:22:36 -03:00
Maurício Meneghini Fauth
3e0856c77b
Remove useless string concatenations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
9f3510d11a
Add bool return type where possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-14 20:11:51 -03:00
Maurício Meneghini Fauth
7f6472b2c2
Add void return type where possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-13 15:29:11 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
...
Related to 62f142c9fa .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
61eae4dba9
Remove navigation link generation from the Nodes
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-11 23:50:17 -03:00
Maurício Meneghini Fauth
8e5cc35e72
Extract navigation icons generation from the Nodes
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-08 20:40:54 -03:00
William Desportes
d20f7f7d0a
Merge branch 'QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-24 19:01:26 +02:00
William Desportes
eb258a806d
Query adjustments
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-24 16:19:53 +02:00
Maurício Meneghini Fauth
59e4dae52a
Remove invalid inline doc comments
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-18 14:49:28 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
7994eb3ac6
Fix some errors found by Psalm
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-02-10 17:12:11 -03:00
Maurício Meneghini Fauth
a83959b3aa
Extract methods from Navigation\Nodes\Node::getData
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-20 17:44:32 -03:00
Maurício Meneghini Fauth
40c4f07de6
Use sprintf for Navigation\Nodes\Node::getData query strings
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-19 22:28:26 -03:00
Maurício Meneghini Fauth
ac9bccf67d
Replace $GLOBALS['dbi'] with global $dbi
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-11 09:24:21 -03:00
William Desportes
466ff06b3b
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-09-15 14:22:24 +02:00
William Desportes
62b9d8ca92
Merge #16354 - Fixes #14698 - Database named as 'New' causes PHP fatal error
...
Pull-request: #16354
Fixes : #14698
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-09-15 14:18:56 +02:00
Nina Pypchenko
de168edc59
Fixes #14698 . Navigation tree no longer breaks on encountering a database named 'New'
...
Signed-off-by: Nina Pypchenko <22447785+nina-py@users.noreply.github.com>
2020-09-15 20:53:02 +10:00
Maurício Meneghini Fauth
3b285ff17e
Use identical operator for non-empty strings
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
2529824c23
Extract change column action from table structure index method
...
Related to #16136
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-08 18:20:48 -03:00
William Desportes
5d933e03b9
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 23:40:25 +02:00
William Desportes
d06ec742e3
Fix an "Uncaught TypeError: PhpMyAdmin\DatabaseInterface::dataSeek()"
...
Uncaught TypeError: PhpMyAdmin\DatabaseInterface::dataSeek(): Argument #2 ($offset) must be of type int, string given, called in libraries/classes/Navigation/Nodes/NodeDatabase.php on line 488 and defined in libraries/classes/DatabaseInterface.php:2724"
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 23:06:40 +02:00
William Desportes
7623fed14a
Fix all found errors and add typehints if possible on NavigationTree class
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-02 23:50:49 +02:00
William Desportes
62baf0b8ea
Change Node::getChild return to ?Node
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-02 23:10:35 +02:00
Maurício Meneghini Fauth
f4582e083e
Use early exit when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
bd979dd1ff
Remove useless elseif with if
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 22:53:44 -03:00
Maurício Meneghini Fauth
3baad2eb1c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
William Desportes
4b0985843f
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 01:13:58 +02:00
William Desportes
481023e946
Fix #16127 - table column description error when DisableIS=true
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-19 20:11:53 +02:00
Maurício Meneghini Fauth
80a45fa0ae
Break too long lines
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 18:08:20 -03:00
William Desportes
9a95abd05f
Use declaration of global $dbi
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-16 12:03:29 +02:00
Maurício Meneghini Fauth
84139f4d51
Remove some useless variables
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 16:15:37 -03:00
Maurício Meneghini Fauth
a64393e7f5
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
Yash Bothra
40665b1f35
Fix #15893 - broken urls in navigation
...
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
2020-03-08 00:48:52 +01:00
William Desportes
cd9dd3ab92
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 20:29:02 +01:00
Rahul Gurung
ac358d45ae
Fix #15810 - the modal heading
...
Co-Authored-by: William Desportes <williamdes@wdes.fr>
In respect for the PR owner I am only co-autor but re-did all the work.
Signed-off-by: Rahul Gurung <gurungrahul2@gmail.com>
2020-02-22 20:04:48 +01:00