gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
123,574 Commits 12 Branches 481 Tags 2.4 GiB
d043ceedc6
Commit Graph

526 Commits

Author SHA1 Message Date
Kamil Tekiela
d043ceedc6 Refactor $sql_data 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-03-17 20:46:27 +00:00
Kamil Tekiela
c2edf8534c Change empty for stricter comparison 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-03-17 20:45:31 +00:00
Kamil Tekiela
ad0acda8b2 Remove parameter 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-03-17 20:23:25 +00:00
Kamil Tekiela
009a92c545 Set parameter type 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-03-17 20:23:25 +00:00
Kamil Tekiela
b3759ba7e4 Remove count() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-03-17 20:23:25 +00:00
Kamil Tekiela
5c8a4e90a0 Remove pass-by-ref 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-03-17 20:23:25 +00:00
Maurício Meneghini Fauth
5950693fb3
Fix possible undefined globals 
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 17:31:11 -03:00
Kamil Tekiela
6e1221ce62 Drop stripslashes 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-02-07 18:07:27 +00:00
William Desportes
a7b222db8a
Merge branch 'origin/QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-02-06 15:47:17 +01:00
William Desportes
65c9f49c1e
Merge branch 'QA_5_1' into QA_5_2 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-02-06 15:45:57 +01:00
William Desportes
cba530070f
Fix #17298 - Import of email-addresses from ods results in empty contents 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-02-06 14:19:01 +01:00
William Desportes
838ac24897
Fix #17344 - type error with values that are not strings in ODS sheets 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-02-06 14:18:47 +01:00
Kamil Tekiela
47e81a5161 Remove $route global 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-27 11:47:40 +00:00
Maurício Meneghini Fauth
f03cc59c8c
Add native types to TransformationsInterface methods 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-26 15:48:08 -03:00
Maurício Meneghini Fauth
feda222da9
Fix failing tests 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-26 10:02:26 -03:00
Isaac Bennetch
985912f58f Fix merge conflicts from security branch 
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
 2022-01-20 12:28:17 -05:00
Maurício Meneghini Fauth
8fa99a3363
Add stub file for uploadprogress_get_info function 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-19 14:49:12 -03:00
Maurício Meneghini Fauth
411bacf613
Use Sodium for auth cookies encryption 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-13 18:46:04 -03:00
Maurício Meneghini Fauth
7aaab24463
Remove the phpseclib dependency 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-13 17:43:50 -03:00
Kamil Tekiela
86031d2bf6 Deimplement fetchAssoc() helper 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 22:44:53 +00:00
Kamil Tekiela
a4b2d7e524 Deimplement fetchRow() helper 
This helper isn't needed anymore.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 22:44:53 +00:00
Kamil Tekiela
bcf2b7b322 Deimplement numFields() helper 
There were only two usages remaining. This helper isn't needed anymore.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 23:27:37 +00:00
Kamil Tekiela
f5bb90ebb9 Move queryAsControlUser - Dbal refactoring pt.3 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:31:27 +00:00
William Desportes
2c3f587495
Fix tcpdf setAutoPageBreak not using a boolean 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-01-03 12:08:53 +01:00
Kamil Tekiela
83b4dda1a3 Change QUERY_STORE to QUERY_BUFFERED 
Set the value to 0 instead of 1 and remove all unnecessary usages of this constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-01 01:46:01 +00:00
Kamil Tekiela
47a039d70c Implement ResultInterface & MysqliResult 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-31 23:59:24 +00:00
Maurício Meneghini Fauth
b1dc03365a
Bump TCPDF version to 6.4.4 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-31 16:58:34 -03:00
Maurício Meneghini Fauth
cb650d2a2d
Merge branch 'QA_5_1' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-29 19:44:12 -03:00
William Desportes
679eca275a
Fix phpdocs after tcpdf update to 6.4.3 (the actual hints where not valid) 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-12-29 01:41:58 +01:00
Maurício Meneghini Fauth
d84af02945
Create VO classes for each RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
c4e2582e56
Use TableName for RelationParameters tables 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 19:17:57 -03:00
Maurício Meneghini Fauth
44fe103b9c
Remove @access annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-22 11:43:45 -03:00
William Desportes
bc570cb1de
Fix merge 2a4b170a34, remove useless for loop 
Ref: 2a4b170a34

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-12-21 17:56:36 +01:00
Maurício Meneghini Fauth
92418f2226
Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-21 13:39:29 -03:00
Maurício Meneghini Fauth
2a4b170a34
Merge branch 'QA_5_1' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-21 13:13:09 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
989d3903e1
Fix coding standard issues after #17241 merge 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-13 10:37:54 -03:00
Maurício Meneghini Fauth
9be8ea204a
Merge pull request #17231 from mauriciofauth/relation-parameters-refactor 
Refactor  RelationParameters class
 2021-12-13 10:22:31 -03:00
William Desportes
f6b241cf5f
#16005 - performance improvement on the Export page 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-12-12 21:57:42 +01:00
William Desportes
68d5ea9400
Fix two errors reported by phpstan about json_decode on U2F implementation 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-12-12 19:44:33 +01:00
William Desportes
f718f475e4
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-12-12 19:35:54 +01:00
William Desportes
d2cd67f8dc
#16746 - Replace samyoul/u2f-php-server by code-lts/u2f-php-server 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-12-12 12:16:52 +01:00
Maurício Meneghini Fauth
4c3bf41d56
Use DatabaseName for RelationParameters::db instead of string 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-11 08:10:40 -03:00
Maurício Meneghini Fauth
c4575fd48b
Add methods to check for RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-11 08:10:40 -03:00
Kamil Tekiela
a42803297c
Psalm fixes 3 (#17221) 
* Update psalm-baseline.xml

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Small bug fixes

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* non-falsy-string is always true

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* currentSearch property is nullable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unusued parameter $columnIndex

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use parameters instead of globals in sendEditor()

The two globals in this method are read-only. There is an unused
parameter in the signature. Let's add one more and use them instead of globals.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unusued parameter $crlf

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-03 12:40:19 -03:00
Kamil Tekiela
f446e6da88 Remove unused variables 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-03 15:12:56 +00:00
Maurício Meneghini Fauth
acff73aa24
Merge pull request #17215 from kamil-tekiela/Psalm-fixes-1 
Use array_keys whenever only keys are needed in foreach
 2021-12-02 18:42:12 -03:00
Kamil Tekiela
1270efc2a9
Refactor util.php (#17212) 
* Remove extra space

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove null checks on properties that cannot be null

The value could be null only if the property exists in stdClass
returned by mysqli but is null. Mysqli doesn't do that. Unless the value
can be null in some other way, this check is redundant.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add psalm-return

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove $handle parameter of getUniqueCondition()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Type hint the $row parameter

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-02 17:37:09 -03:00
Kamil Tekiela
488e7cb5bf Use array_keys whenever only keys are needed in foreach 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-11-29 20:37:39 +00:00