gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
123,574 Commits 12 Branches 481 Tags 2.4 GiB
d043ceedc6
Commit Graph

218 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
5950693fb3
Fix possible undefined globals 
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
a70b08d62f
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-21 12:48:23 -03:00
Maurício Meneghini Fauth
f7f85bb450
Merge branch 'QA_5_1' into QA_5_2 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-21 12:37:29 -03:00
Maurício Meneghini Fauth
4848ccb481
Disable editing to system schemas 
- Fixes #16816

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-19 17:52:05 -03:00
Maurício Meneghini Fauth
dca5b1b893
Create the DisplayParts class 
Replaces the displayParts array with the DisplayParts object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-03 14:42:09 -03:00
Maurício Meneghini Fauth
c03cbdea88
Merge pull request #17276 from kamil-tekiela/microtime-sql 
Expose execution time as public property
 2022-01-19 12:13:12 -03:00
Kamil Tekiela
3e6e4fffbc Expose execution time as public property 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 21:21:55 +00:00
Kamil Tekiela
84e899bb86 Fix parameter types 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 18:21:21 +00:00
Kamil Tekiela
643c642c9d Remove redundant null coalesce 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 18:21:21 +00:00
Kamil Tekiela
8e035557a7 Refactor getMessageIfMissingColumnIndex 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 18:21:20 +00:00
Kamil Tekiela
caeb5fef29 Cleanup getHtmlForPreviousUpdateQuery 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:13 +00:00
Kamil Tekiela
d280d724ed Add return type 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:13 +00:00
Kamil Tekiela
7f8c1355fa Add check for false value 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:13 +00:00
Kamil Tekiela
b20922b773 Simplify getDefaultSqlQueryForBrowse 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:13 +00:00
Kamil Tekiela
e8bfa5e4e6 Remove redundant condition 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:13 +00:00
Kamil Tekiela
51207fff0b Set parameter type 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:13 +00:00
Kamil Tekiela
7b60bd57fa Remove unused pass-by-ref 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:13 +00:00
Kamil Tekiela
53518dc266 Fix argument type 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:13 +00:00
Kamil Tekiela
1df141dcd6 Remove unused parameter 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:13 +00:00
Kamil Tekiela
aa49e38fc0 Invert the condition within foreach 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:13 +00:00
Kamil Tekiela
18a16915df Use elvis operator instead of if 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:12 +00:00
Kamil Tekiela
c9a532dcaf Remove useless ! empty 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:12 +00:00
Kamil Tekiela
1e2772dbff Convert ternary into true boolean expression 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:12 +00:00
Kamil Tekiela
34b0a92a87 Merge if statements into one 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:12 +00:00
Kamil Tekiela
b1a82bf08b Refactor Sql.php 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:12 +00:00
Kamil Tekiela
83b4dda1a3 Change QUERY_STORE to QUERY_BUFFERED 
Set the value to 0 instead of 1 and remove all unnecessary usages of this constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-01 01:46:01 +00:00
Kamil Tekiela
47a039d70c Implement ResultInterface & MysqliResult 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-31 23:59:24 +00:00
Maurício Meneghini Fauth
2edf663611
Remove the Bookmark::getParams method 
Uses BookmarkFeature class instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 09:31:53 -03:00
Kamil Tekiela
eba8621881 Use DI for Results.php 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-26 23:10:34 +00:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:13 -03:00
Kamil Tekiela
be87571da6 PHPStan checkAlwaysTrueStrictComparison fixes 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-08 15:26:52 +00:00
Maurício Meneghini Fauth
acff73aa24
Merge pull request #17215 from kamil-tekiela/Psalm-fixes-1 
Use array_keys whenever only keys are needed in foreach
 2021-12-02 18:42:12 -03:00
Kamil Tekiela
488e7cb5bf Use array_keys whenever only keys are needed in foreach 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-11-29 20:37:39 +00:00
Kamil Tekiela
63b59f2550 Fix issues with wrong type provided for $table 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-11-28 19:33:09 +00:00
Maurício Meneghini Fauth
0d81b2166a
Add test for Sql::executeQueryAndSendQueryResponse 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-11-15 19:51:16 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
9f3510d11a
Add bool return type where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-14 20:11:51 -03:00
Maurício Meneghini Fauth
7f6472b2c2
Add void return type where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-13 15:29:11 -03:00
Maurício Meneghini Fauth
6ae07c96fb
Replace strpos !== false with str_contains 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-09 22:30:42 -03:00
William Desportes
4f74043e1a
Merge branch 'origin/QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-08 15:39:08 +02:00
William Desportes
65d262c170
Fix #17001 - adjust function signatures and handle no table name case 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-08 14:52:18 +02:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
21431578db
Fix some errors found by PHPStan and Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-24 18:03:14 -03:00
William Desportes
0a1f083990
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-06-23 20:36:21 +02:00
William Desportes
897f07d50d
Implement error management for #16977 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-06-23 13:18:40 +02:00
Maurício Meneghini Fauth
8f992a4fbf
Fix some errors found by PHPStan and Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-15 18:49:37 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors 
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-03 16:50:33 -03:00
William Desportes
3706c1fcd1
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-05-29 21:30:42 +02:00
Maurício Meneghini Fauth
cd1b8a9b77
Fix some errors found by PHPStan and Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-22 15:14:24 -03:00