Commit Graph

65 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
5950693fb3
Fix possible undefined globals
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
ec4baa6583
Remove calls of Util::getValueByKey where path doesn't have a dot
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-08 14:30:19 -03:00
Maurício Meneghini Fauth
f940693c75
Move Util::checkParameters method to the AbstractController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-07 22:59:33 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
9b5b210fc4
Remove action global var from ColumnsDefinition class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-03 17:41:52 -03:00
Maurício Meneghini Fauth
c0eb02d7d3
Extract ColumnsDefinition construction from controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-02 18:59:27 -03:00
Kamil Tekiela
1468976587 Convert phpdoc to param type
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-06 19:38:21 +00:00
Kamil Tekiela
9a34ec9fdf Remove invalid condition
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-06 19:37:34 +00:00
Maurício Meneghini Fauth
d84af02945
Create VO classes for each RelationParameters features
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
c4575fd48b
Add methods to check for RelationParameters features
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-11 08:10:40 -03:00
Kamil Tekiela
945d887a10 Fix var annotation for Charset and Collation
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-09 22:25:58 +00:00
Kamil Tekiela
ce527035c2 PHPStan checkAlwaysTrueCheckTypeFunctionCall fixes
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-08 15:26:52 +00:00
Kamil Tekiela
f446e6da88 Remove unused variables
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-03 15:12:56 +00:00
Kamil Tekiela
488e7cb5bf Use array_keys whenever only keys are needed in foreach
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-11-29 20:37:39 +00:00
Maurício Meneghini Fauth
b2a51c4d84
Create the RelationParameters value object
Replaces the $cfgRelation array with the RelationParameters value
object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-14 18:22:36 -03:00
Maurício Meneghini Fauth
a835d7cfcc
Remove array support from Util::backquote
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-10 19:33:09 -03:00
Maurício Meneghini Fauth
c1e864b1d7
Add Warning value object for SHOW WARNINGS rows
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-10-09 00:09:01 -03:00
Maurício Meneghini Fauth
75a1b02927
Add Table\Maintenance\Message value object
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-10-06 14:06:03 -03:00
Maurício Meneghini Fauth
560fb6ff8e
Refactor Table\Maintenance controllers to use ServerRequest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-10-05 16:35:26 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
00cb1b3668
Extract IndexesController::doSaveData method
Creates the Table\Indexes class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-11 14:38:44 -03:00
Maurício Meneghini Fauth
78c266d98f
Move partition classes to the Partitioning namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-21 14:01:25 -03:00
Fawzi E. Abdulfattah
9954c47577
Fix #16138 - ignore the length of integer types, and show a warning
Fixes: #16138

Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
2021-07-13 15:42:57 +02:00
Maurício Meneghini Fauth
6ae07c96fb
Replace strpos !== false with str_contains
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-09 22:30:42 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
5faf95016f
Use DatabaseName VO for db names in Table\Partition
- Adds DatabaseName support for DatabaseInterface::selectDb method

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-21 21:30:37 -03:00
Maurício Meneghini Fauth
4d09e19216
Add DatabaseName value object
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-21 16:17:28 -03:00
liviuconcioiu
c4ca6f346c
Fix #16829 - Add NOT LIKE %...% operator to Table search
Signed-off-by: Liviu Concioiu <liviu.concioiu@gmail.com>
2021-04-23 18:58:08 +02:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-20 22:35:21 -03:00
William Desportes
aaaff9c307
Extract some compatiblity checks into the Query\Compatibility class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-20 21:02:50 +02:00
William Desportes
d99da46f7a
Move isVirtualColumnsSupported to Query\Compatibility and simplify the code
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-20 20:31:38 +02:00
Maurício Meneghini Fauth
035e29a80b
Extract GIS related methods from Util class
Creates the PhpMyAdmin\Utils\Gis class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-22 15:03:39 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
3a25c96543
Create truncate table partition page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 22:36:05 -03:00
Maurício Meneghini Fauth
f419ce4f2e
Create repair table partition page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 22:32:34 -03:00
Maurício Meneghini Fauth
905f48184f
Create rebuild table partition page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 22:29:01 -03:00
Maurício Meneghini Fauth
42cf71d8aa
Create optimize table partition page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 22:22:19 -03:00
Maurício Meneghini Fauth
0c38913c15
Create drop table partition page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 22:16:46 -03:00
Maurício Meneghini Fauth
b64be69dd8
Create analyze table partition page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 21:29:27 -03:00
Maurício Meneghini Fauth
f8df25487f
Create check table partition page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 21:09:32 -03:00
Maurício Meneghini Fauth
bb32ba6d9c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-04 12:31:43 -03:00
Maurício Meneghini Fauth
5e17787c15 Merge branch 'QA_5_0'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-20 12:05:24 -03:00
Maurício Meneghini Fauth
0e5d9535e6 Remove columns_definitions/transformation template
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-17 17:56:07 -03:00
Maurício Meneghini Fauth
d82d598ec7 Improve table maintenance pages
Replaces tables with list group cards.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-28 19:37:09 -03:00
Maurício Meneghini Fauth
3b02872cd3 Create the Table\Maintenance class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-28 00:35:13 -03:00
Maurício Meneghini Fauth
858e8dc666 Extract template render from ColumnsDefinition::displayForm
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-12 17:21:36 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
05c62ad1a8 Fix some PHPStan errors
Fixes "Cannot access offset on array" errors.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-02 16:12:07 -03:00