gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
123,574 Commits 12 Branches 481 Tags 2.4 GiB
d043ceedc6
Commit Graph

158 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
d70644ecf0 Extract results nav buttons into table template 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-13 21:26:15 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
de32a92b71
Add more tests for Display\Results::getTable method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-21 14:53:32 -03:00
Maurício Meneghini Fauth
c482cd47ef
Remove gridEditingConfig JS global 
- Uses data attribute instead.
- Uses Bootstrap's tooltip instead of the jQuery plugin.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-14 23:19:29 -03:00
Maurício Meneghini Fauth
dca5b1b893
Create the DisplayParts class 
Replaces the displayParts array with the DisplayParts object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-03 14:42:09 -03:00
Maurício Meneghini Fauth
0bee94b27e
Merge branch 'QA_5_1-security' into master-security 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-11 14:31:56 -03:00
Kamil Tekiela
47a039d70c Implement ResultInterface & MysqliResult 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-31 23:59:24 +00:00
Maurício Meneghini Fauth
8e9dfe79db
Merge pull request #17243 from kamil-tekiela/Refactor-Results.php 
Refactor results.php
 2021-12-27 09:21:49 -03:00
Kamil Tekiela
7a735ddf92 Redesign CSS class generation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-26 23:10:34 +00:00
Kamil Tekiela
eba8621881 Use DI for Results.php 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-26 23:10:34 +00:00
Maurício Meneghini Fauth
d84af02945
Create VO classes for each RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
44fe103b9c
Remove @access annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-22 11:43:45 -03:00
Maurício Meneghini Fauth
bf49480160
Populate relation Session with RelationParameters class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:15 -03:00
Kamil Tekiela
1270efc2a9
Refactor util.php (#17212) 
* Remove extra space

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove null checks on properties that cannot be null

The value could be null only if the property exists in stdClass
returned by mysqli but is null. Mysqli doesn't do that. Unless the value
can be null in some other way, this check is redundant.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add psalm-return

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove $handle parameter of getUniqueCondition()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Type hint the $row parameter

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-02 17:37:09 -03:00
Maurício Meneghini Fauth
220ed30ef8
Remove printview.css theme files 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-10-31 17:35:55 -03:00
Maurício Meneghini Fauth
3e0856c77b
Remove useless string concatenations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-15 17:05:40 -03:00
Lukas Bixen
13807a1049
Fix ResultsTest after pull-request #17070 
Signed-off-by: Lukas Bixen <lrb2_@outlook.com>
 2021-08-22 23:25:50 +02:00
Maurício Meneghini Fauth
f970299289
Remove $defaultFunction variable from Display\Results 
Makes the type of $transformationPlugin variable more strict.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-09 12:50:28 -03:00
Maurício Meneghini Fauth
355f6d9d20
Remove PhpMyAdmin\Config::enableBc method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-09 13:59:04 -03:00
Maurício Meneghini Fauth
b1c936a0f3
Fix some errors found by Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-25 15:03:05 -03:00
William Desportes
0a1f083990
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-06-23 20:36:21 +02:00
William Desportes
5e557397b5
Fix tests after #16896 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-06-22 00:30:48 +02:00
Maurício Meneghini Fauth
b3f088e9fd
Extract HTML from Results::getTableHeadersForColumns 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-17 22:40:53 -03:00
Maurício Meneghini Fauth
c3b453aa3a
Extract the HTML from sorted table header 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-17 17:09:18 -03:00
Maurício Meneghini Fauth
fa12894e5f
Add unit tests for Display\Results::setConfigParamsForDisplayTable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-16 20:26:24 -03:00
Maurício Meneghini Fauth
39c0908af5
Remove display/results/sort_by_key template 
Merges it with the `display/results/table` template.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-16 13:03:32 -03:00
Maurício Meneghini Fauth
81dfced388
Add unit test for Display\Results::getTable method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-14 18:47:17 -03:00
Maurício Meneghini Fauth
f3b79d83c0
Add PHPUnit's Covers annotation on test classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-04 23:39:26 -03:00
William Desportes
8fbb01a684
Merge branch 'origin/QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-19 21:51:45 +02:00
William Desportes
42f4464c07
Adjust testGetDataCellForNonNumericColumns test data 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-19 19:05:56 +02:00
William Desportes
ae4518be9b
Add tests for #16836 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-19 19:00:35 +02:00
William Desportes
856145297f
Merge branch 'origin/QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-13 17:46:06 +02:00
William Desportes
721e927f12
Fix #16791 - Undefined index table_schema and "DESCRIBE FILES" broken links 
Reverts: ca0244f06b because the code was guessing what the parent had already found but the code did not fine the same results between the parent and the child.

Now passing the result from the parent to the child will remove one guessing

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-12 22:26:51 +02:00
William Desportes
927689554e
Remove impossible code since #1208 
Ref: 26dc919e68

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-12 21:50:51 +02:00
Maurício Meneghini Fauth
3d539b78e6
Merge branch 'QA_5_1' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-27 16:07:09 -03:00
William Desportes
8992ef095f
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-14 11:54:03 +01:00
William Desportes
c62e27d650
Fix #16724 - Remove old unstable code to make column order work 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-13 01:19:58 +01:00
Maurício Meneghini Fauth
33d711215d
Remove the PMA_VERSION constant 
Uses the PhpMyAdmin\Version::VERSION constant instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-08 22:22:55 -03:00
Maurício Meneghini Fauth
7e33d227f5
Rename the PMA_Config global variable to config 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-08 15:03:12 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 14:18:35 -03:00
William Desportes
c5155ecae9
Refactor field flags to use an object an not strpos 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-02-24 23:56:33 +01:00
Maurício Meneghini Fauth
ac4bfaebe7
Remove some custom CSS utilities 
Uses Bootstrap equivalents.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-12-26 20:05:03 -03:00
Maurício Meneghini Fauth
d3c31fabd4
Remove some custom CSS utilities 
Uses Bootstrap equivalents.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-12-23 19:06:38 -03:00
William Desportes
bc45a05dcd
Typo fixes in the JS codebase with VS code "code spell checker" 
And coding standard issues from pull-request #16364
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-11-12 23:27:57 +01:00
Petr Duda
eeaf18cfb3
Fix #16095 - Add test cases for displaying results in non-numeric columns 
Signed-off-by: Petr Duda <petrduda@seznam.cz>
 2020-11-02 09:28:22 +01:00
Petr Duda
2c7b7046e2
Fix #16095 - Leading space not shown in a CHAR column 
Signed-off-by: Petr Duda <petrduda@seznam.cz>
 2020-11-02 09:28:04 +01:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
75397c913d Refactor Display\Export class 
- Uses template inheritance for the export templates.
- Renames Display\Export to Export\Options.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-03 23:56:20 -03:00
Maurício Meneghini Fauth
4cbf018db3 Merge Display\Export::getDisplay templates 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-03 18:21:53 -03:00