Commit Graph

63 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
b37f424914 Retrieve parameters from $_POST in error report
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-11 09:33:50 -05:00
Maurício Meneghini Fauth
17bf8b7309 Replace static methods with instance methods
Replaces PhpMyAdmin\UserPreferences static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-23 15:26:02 -03:00
Maurício Meneghini Fauth
67e65d91bf Fix some coding style
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-09 21:54:02 -02:00
Maurício Meneghini Fauth
eaae50a1bc Add a constructor
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-09 21:10:17 -02:00
Maurício Meneghini Fauth
56daea7d86 Replace static methods with instance methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-08 12:25:13 -02:00
Maurício Meneghini Fauth
a10e2b0b96 Refactor error_report functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-13 20:51:08 -03:00
Maurício Meneghini Fauth
ce49e7f60f Refactor user_preferences functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-12 22:31:02 -03:00
Maurício Meneghini Fauth
119563b7ea Move classes to PhpMyAdmin namespace
- Move OpenDocument to PhpMyAdmin namespace
- Move OutputBuffering to PhpMyAdmin namespace
- Move Partition to PhpMyAdmin namespace
- Move Pdf class to PhpMyAdmin namespace
- Move RecentFavoriteTable to PhpMyAdmin namespace
- Move Response to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-06-30 23:44:10 -03:00
Maurício Meneghini Fauth
54a15dbd9c Move classes to PhpMyAdmin namespace
- Move Logging to PhpMyAdmin namespace
- Move Menu to PhpMyAdmin namespace
- Move Message to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-06-30 13:30:04 -03:00
Michal Čihař
308c9d7951 Simplify Response object handling
- always use use and short name
- avoid calling getInstance() several times in one script

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-12-07 18:17:59 +01:00
Hugues Peccatte
f0ba28fc1d Set namespace on Advisor, Config, Console and Util classes.
Set namespace on DbQbe.
Set namespace to 'DbSearch'.
Split Advisor.class.php file.
Change Advisor namespace.
Rename DbQbe class and file.
Set namespace on DisplayResults.
Set namespace on Error.
Use namespace for ErrorHandler.
Add class autoloader.
Change ErrorHandler filename.
Remove some require.
Update Config namespace path.
Update PMA_Util to PMA\libraries\Util.
Rename Font and File classes files.
Use namespace for Footer.
Set namespace in all libraries classes.
Namespace OutputBuffering.
Export SubPartition.
Rename Partition file.
Namespace PDF.
Namespace RecentFavoriteTable.
Replace PMA_Response by Response and PMA_Message by Message.
Update uses and calls.
Fix unit tests.
Fix SqlParser autoload.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:22:52 +02:00
Rahul Kadyan
4d308ba364 Remove unneeded closing tags
Closing tags at the end of file are not mandatory. It is often
suggested to omit to closing tags at the end of file to prevent
unwanted effects as PHP will start output buffering if there is
any character after closing tag.

Reference: http://php.net/manual/en/language.basic-syntax.phptags.php

Signed-off-by: Rahul Kadyan <hi@znck.me>
2015-03-06 23:37:35 +05:30
Hugues Peccatte
fd7f02f929 Fix typos.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-11-02 14:33:41 +01:00
Dhananjay Nakrani
83d63d23ea Fix coding style issues.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:55 +05:30
Dhananjay Nakrani
627873f146 Enable 'Send error reports automatically next time' option in php error reporting form.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:55 +05:30
Dhananjay Nakrani
b621ab9277 Merge paths for 'php'& 'js' error reporting.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
b2e3164441 Make return values of PMA_getReportData() consistent.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
bc76f04ce7 Remove trailing whitespaces.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
e37616adba Fix coding style issues.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
0b9439a246 Make automatic php error report submission ('sendErrorReport'='always') aysnchronous. Stop infinite auto error reporting loop.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
9a1fb901d0 Remove included 'common_error_reporting.php' script and its inclusion from all the scripts.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
86b3f352a9 Stop false alarms (displaying prompts-reporting form and reporting for 'false' (user warnings) errors).
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:53 +05:30
Dhananjay Nakrani
e9d5523795 Include error reporting script at the end of all the 'relevant' scripts.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:53 +05:30
Dhananjay Nakrani
d4bddddd93 Improve Error Message.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:53 +05:30
Dhananjay Nakrani
e74cd6ec1d Report errors based on user preference. All the cases taken care of.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:52 +05:30
Michal Čihař
1fb2276e2b Fix if formatting
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-28 10:43:33 +02:00
Michal Čihař
d3fcfec4bb Consistent message strings and types for error submission
We can share more strings on the failed error reporting and also the
messages should have same type regardless it was manual or automatic
submission.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-28 09:26:35 +02:00
Michal Čihař
3f21b2816f Get rid of overridable return type
Separate function for collecting the data from pretty printing it.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-06 13:26:41 +02:00
Madhura Jayaratne
3c9f6a6890 Space around . operator - mroe instances
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-01-08 18:56:30 +05:30
Michal Čihař
b027060c87 Another not checked variable before use (bug #4114) 2013-11-25 09:25:16 +01:00
Michal Čihař
aefabf5335 Check whether variable is set 2013-11-18 15:01:53 +01:00
Michal Čihař
15eaddb6af Coding style 2013-11-18 11:49:43 +01:00
Mohamed Ashraf
38fea8e663 Fixed linting error 2013-11-17 23:17:18 +01:00
Mohamed Ashraf
f82e321b75 Message shows failure of error report submission 2013-11-17 20:29:14 +01:00
Marc Delisle
677e4496b7 Bug #4114 No params checking in error_report.php 2013-11-17 08:56:55 -05:00
Madhura Jayaratne
b92fabb0d5 Fix coding style 2013-10-22 07:25:45 +05:30
Marc Delisle
5d92e16834 Merge pull request #730 from m0hamed/error_report_fix
Fixed bug where send error report not being called
2013-10-16 08:17:07 -07:00
Mohamed Ashraf
70d73fed94 Fixed bug where send error report not being called 2013-10-11 11:30:34 +02:00
Michal Čihař
3f3dfb1ecc Allow error reporting without precalculated line counts
As these can now be done on the fly
2013-10-03 14:48:23 +02:00
Dieter Adriaenssens
5028d8e716 improve message 2013-10-01 21:11:02 +02:00
Dieter Adriaenssens
34a75e0b11 fix typo 2013-09-30 17:37:57 +02:00
Mohamed Ashraf
39cddaf596 Fixed type 2013-09-21 00:43:42 +02:00
Mohamed Ashraf
c5d2d51007 Error reporting now fails gracefully on dev builds 2013-09-21 00:42:00 +02:00
Mohamed Ashraf
43c8e8c448 Refactored error report functions to a library and added doc blocks 2013-09-01 00:59:26 +02:00
Mohamed Ashraf
3edba72c1f Fixed inconsistencies with error reporting server in report schema 2013-08-18 19:40:55 +02:00
Mohamed Ashraf
dc63ed89c4 Added url sanitization to remove useless params and get script name for error grouping 2013-08-03 00:45:33 +02:00
Mohamed Ashraf
9d38212c06 Changed submission url to new controller 2013-08-03 00:44:47 +02:00
Mohamed Ashraf
005c8953a3 Removed some useless comments in error_report.php 2013-07-29 17:51:45 +02:00
Mohamed Ashraf
0e3b830e3e Changed using to ['cfg'] in error_report.php 2013-07-29 17:07:38 +02:00
Mohamed Ashraf
f8fe8e5aa3 Stacktrace now translated if line counts exist 2013-07-29 16:55:27 +02:00