Madhura Jayaratne
36b863afd0
Fix some style violations
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-05-06 09:55:27 +05:30
Marc Delisle
65277b2ebb
phpunit 4.2: assertTag is deprecated
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-05-05 14:32:29 -04:00
Madhura Jayaratne
00fd7b6ca0
Merge branch 'QA_4_3'
2014-12-10 15:13:46 +05:30
Madhura Jayaratne
9f58a8188a
Update tests
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-12-10 15:07:17 +05:30
Michal Čihař
b7e17814c1
Fix variable name
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-12-01 11:59:07 +01:00
Michal Čihař
a6764bab9b
Always restore mocked instance after test
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-12-01 11:38:40 +01:00
Hugues Peccatte
42e0bdd47a
Fix typos.
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-11-02 18:32:42 +01:00
Marc Delisle
9d187c0df6
Refactor code duplication
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-10-10 08:03:25 -04:00
Marc Delisle
03debd0a6e
Refactor: we had three similar functions, refactored into just one.
...
Also, these functions returned false, or a string containing the type,
but the string was only used to indirectly mean a true value; now
we explicitely return true in this case.
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-10-04 08:27:50 -04:00
Marc Delisle
b3bcdf55ee
Remove unused parameter
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-07 09:40:02 -04:00
Marc Delisle
2905b29f68
Remove dead code
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-07 09:25:14 -04:00
Chirayu Chiripal
a4e2472108
check null checkbox for datetime with default value null
...
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-09-06 13:47:06 +05:30
Chirayu Chiripal
1be86d1062
fix parameter types
...
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-08-07 19:20:02 +05:30
Chirayu Chiripal
11ae13f177
Improve validation on insert page
...
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-08-04 02:19:25 +05:30
Ashutosh Dhundhara
508f0a752b
RFE#919: Multiple-column foreign key relation.
...
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
Fix missing master column.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
Fix failing test.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
Fix coding styles.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
Fix function doc.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
Fix coding styles.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-08-01 19:50:12 +05:30
Marc Delisle
119049f7b3
Remove unused parameter
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-07-14 10:32:47 -04:00
Chirayu Chiripal
1f324be4b1
RFE-637: Custom field handlers (input transformations)
...
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-07-12 01:52:32 +05:30
Marc Delisle
de6ad93d24
Merge pull request #1209 from ashutoshdhundhara/rfe_1145
...
RFE#1145: Preview SQL instead of executing it.
2014-06-07 06:39:32 -04:00
Ashutosh Dhundhara
99b9e8d83c
RFE#1145: Preview SQL instead of executing it.
...
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-06-07 00:27:39 +05:30
Michal Čihař
21c6c2e79f
Pass correct types in testsuite
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 13:13:48 +02:00
Michal Čihař
83073fe53c
Remove duplicate variable initialization
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 13:12:51 +02:00
Michal Čihař
1cc4620d65
Pass correct types in testsuite
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 13:12:26 +02:00
Michal Čihař
666e302564
Fix indefined variables in test
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 13:08:40 +02:00
Michal Čihař
3e4ef11ba1
Pass correct parameter
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 13:07:48 +02:00
Michal Čihař
bfadec2f2b
Pass correct parameter values
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 13:05:26 +02:00
Michal Čihař
3e4da830ee
Correctly set static properties in testsuite
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 13:01:14 +02:00
Michal Čihař
dc825e82be
Correctly document parameter types
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 12:58:50 +02:00
Marc Delisle
20b2a3a707
Merge commit '28074d2'
2014-05-23 10:22:51 -04:00
Marc Delisle
9373e1b204
Fix merge conflict
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-23 10:21:37 -04:00
Ann + J.M
28074d27f4
Code style fixes
...
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-05-21 21:22:12 +02:00
Ann + J.M
5ddd0c1990
Code style fixes
...
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-05-21 20:56:01 +02:00
Chirayu Chiripal
85390a7169
rfe-982: Support for editing binary fields in hexadecimal
...
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-05-21 21:42:21 +05:30
Chirayu Chiripal
fed689c7e1
documentation & coding style issues fix
...
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-05-18 12:38:49 +05:30
Marc Delisle
b9b06845ff
Merge commit '7f445f9'
2014-05-16 07:53:38 -04:00
Chirayu Chiripal
7f445f99e3
Bug fix #4411 Protect Binary when set to no in settings still does not allow insert binary data
...
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
test case fix
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-05-15 20:05:52 +05:30
Chirayu Chiripal
c3f2abe873
FR #1487 : Browse Foreign Values should be modal dialog
...
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-05-14 17:30:11 +05:30
Jeff Chan
013a9a3395
Move slow test in HHVM to group medium
...
These tests were failing on HHVM because of the default 3 second timeout.
Yes, HHVM is supposed to be faster, but there's a "warmup" time for scripts
in JIT mode (which is on by default). I suspect that's why they're failing.
Signed-off-by: Jeff Chan <jefftchan@gmail.com>
2014-03-13 20:52:13 +00:00
Chirayu Chiripal
ef6dd51514
Feature Request #1501 add maxlength by field with length-spec
...
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-03-12 22:21:36 +05:30
Marc Delisle
1b639952d6
Merge commit '8ee7fc8'
2014-01-30 13:24:56 -05:00
Marc Delisle
8ee7fc8a9c
bug #4265 Missing datepicker icon for DATETIME(length)
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-30 13:23:31 -05:00
Madhura Jayaratne
cdd53ace21
Merge branch 'QA_4_1'
...
Conflicts:
libraries/Util.class.php
test/libraries/PMA_insert_edit_test.php
2014-01-29 23:30:33 +05:30
Madhura Jayaratne
c1c50b5944
Revert e8fa9e5335, ea0ad9d41c and f36fbfd4c6
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-01-29 23:06:43 +05:30
Marc Delisle
2a2d4cd2bb
Fix merge conflict
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-27 12:48:11 -05:00
Sampath Liyanage
ea0ad9d41c
unit tests updated. Some global variables were set in setup functions of some test files. one testing function with mockobjects was changed from once() to exactly(2) because the bug fix has made that function calls twice
...
Signed-off-by: Sampath Liyanage <plbsam@gmail.com>
2014-01-27 21:53:36 +05:30
Marc Delisle
0e88efbf9b
Merge branch 'QA_4_1'
2014-01-22 08:37:58 -05:00
Marc Delisle
7064e047a3
bug #4218 Chrome behavior with date fields
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-22 08:37:32 -05:00
Marc Delisle
eedc0f3071
Merge commit '10a6260'
2014-01-06 09:37:02 -05:00
Marc Delisle
10a6260180
Fix failing test
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-06 09:35:54 -05:00
Marc Delisle
a329137fbd
Fix tests
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2013-12-06 07:22:47 -05:00
Madhura Jayaratne
6a5062af3d
Fix failing tests
2013-11-28 21:34:02 +05:30