Commit Graph

152 Commits

Author SHA1 Message Date
Michal Čihař
308c9d7951 Simplify Response object handling
- always use use and short name
- avoid calling getInstance() several times in one script

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-12-07 18:17:59 +01:00
Michal Čihař
f36f61314f Remove odd/even markup
Issue #12070

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-12-07 10:17:15 +01:00
Durgesh
0b64827930 Refactored url parmeters generating, Issue #11990
Signed-off-by: Durgesh <007durgesh219@gmail.com>
2016-02-22 14:36:41 +05:30
Marc Delisle
06d22e636e Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-07 09:41:46 -05:00
Marc Delisle
66c15daba0 Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-06 08:01:07 -05:00
Marc Delisle
357b1b4757 Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-04 09:05:42 -05:00
Marc Delisle
2607023281 Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-03 11:00:01 -05:00
Hugues Peccatte
7f8f34e89d Remove classes require_once.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:22 +02:00
Hugues Peccatte
f0ba28fc1d Set namespace on Advisor, Config, Console and Util classes.
Set namespace on DbQbe.
Set namespace to 'DbSearch'.
Split Advisor.class.php file.
Change Advisor namespace.
Rename DbQbe class and file.
Set namespace on DisplayResults.
Set namespace on Error.
Use namespace for ErrorHandler.
Add class autoloader.
Change ErrorHandler filename.
Remove some require.
Update Config namespace path.
Update PMA_Util to PMA\libraries\Util.
Rename Font and File classes files.
Use namespace for Footer.
Set namespace in all libraries classes.
Namespace OutputBuffering.
Export SubPartition.
Rename Partition file.
Namespace PDF.
Namespace RecentFavoriteTable.
Replace PMA_Response by Response and PMA_Message by Message.
Update uses and calls.
Fix unit tests.
Fix SqlParser autoload.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:22:52 +02:00
Marc Delisle
bb01f9b2b7 Refactor db_info.inc.php
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-08-25 11:16:59 -04:00
Jason
59b11954f4 Recover tests for PMA_Table and rename sGetStatusInfo to getStatusInfo
Signed-off-by: Jason <jason.daurus@gmail.com>
2015-08-12 16:48:40 +08:00
Hugues Peccatte
08919d9252 Make PHPCS happy.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-07-25 09:36:48 +02:00
Jason
6fd29078b6 Fix test failures
Signed-off-by: Jason <jason.daurus@gmail.com>
2015-07-23 11:46:40 +08:00
Marc Delisle
14e8e4b3ff - Remove code duplication
- Improve variable name

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-07-16 14:22:35 -04:00
Hugues Peccatte
37f6b992da Fix typos.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-06-14 13:50:57 +02:00
Marc Delisle
1659f80c50 Clarify method name (avoid confusion with SQL's VIEW)
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-05-25 13:10:55 -04:00
Marc Delisle
4eccae5290 Merge pull request #1547 from znck/master
Remove unneeded closing tags
2015-03-26 07:56:45 -04:00
Marc Delisle
561233b91d Streamline message
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-03-24 12:00:43 -04:00
Rahul Kadyan
4d308ba364 Remove unneeded closing tags
Closing tags at the end of file are not mandatory. It is often
suggested to omit to closing tags at the end of file to prevent
unwanted effects as PHP will start output buffering if there is
any character after closing tag.

Reference: http://php.net/manual/en/language.basic-syntax.phptags.php

Signed-off-by: Rahul Kadyan <hi@znck.me>
2015-03-06 23:37:35 +05:30
Madhura Jayaratne
f8d68e6272 Eliminate duplicate code
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-11-11 20:49:11 +05:30
Ann + J.M
29ec69c849 Merge branch 'master' into ZweiSteinSoft/rfe/1550-pma-url-getcommon-new-style
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-10-22 16:58:00 +02:00
Marc Delisle
9680410019 Refactor code duplication
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-10-19 10:13:07 -04:00
Ann + J.M
b1a7039ae3 Convert PMA_URL_getCommon calls to new style
Rewritten tests need validation
Signed-Off-By: Ann + J.M. <phpMyAdmin@ZweiSteinSoft.de>
2014-10-18 19:42:29 +02:00
Marc Delisle
27b9e16dc6 Remove unneeded code
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-21 07:34:44 -04:00
Marc Delisle
64d606ed59 Fix code execution path warning
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-16 07:59:18 -04:00
Hugues Peccatte
9b77d746ab Mass modifications to use PMA_String.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-06 10:44:03 +02:00
Ashutosh Dhundhara
508f0a752b RFE#919: Multiple-column foreign key relation.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix missing master column.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix failing test.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix coding styles.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix function doc.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix coding styles.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-08-01 19:50:12 +05:30
Ann + J.M
71fb5057a3 rfe #1523 Better visual clue for table structure primary key column
Signed-Off-By: Ann + J.M. <phpMyAdmin@ZweiSteinSoft.de>
2014-05-19 14:02:08 +02:00
Marc Delisle
fcaa0f48b1 Remove code related to older MySQL version (minimum supported is 5.5)
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-08 07:13:25 +02:00
Michal Čihař
bb76286e8a Remove space from the string
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-02-27 10:45:52 +01:00
Marc Delisle
252d067fc1 Fix codestyle 2013-09-04 07:52:07 -04:00
Michal Čihař
0a3d1d5be8 Better names for URL generating functions 2013-08-07 10:58:17 +02:00
Michal Čihař
ef30133a94 Various coding style fixes 2013-08-06 15:44:51 +02:00
Madhura Jayaratne
650a8cdda3 Convert database interface to a class 2013-05-24 17:30:59 +05:30
Marc Delisle
01fb62be7d Use correct SQL terminology 2013-05-22 06:57:59 -04:00
Marc Delisle
d5ae979b50 Dead code 2013-05-22 06:55:04 -04:00
Michal Čihař
5858ca47d1 Wrap some long lines 2013-05-10 10:37:16 +02:00
Michal Čihař
61c9e4df28 Replace HTML/PHP mix with PHP 2013-05-10 10:35:23 +02:00
Kasun Chathuranga
42256b2d0c PMA_DBI_select_db --> PMA_DBI_selectDb 2013-05-04 08:26:27 +05:30
Kasun Chathuranga
6b1f6ae046 Merge branch 'master' into DBI_naming_cleanUp
Conflicts:
	libraries/database_interface.lib.php
	libraries/db_table_exists.lib.php
	libraries/relation.lib.php
	libraries/rte/rte_triggers.lib.php
	libraries/schema/Dia_Relation_Schema.class.php
	libraries/schema/Visio_Relation_Schema.class.php
	tbl_addfield.php
2013-05-01 00:51:15 +05:30
Kasun Chathuranga
77bb53dcf8 PMA_DBI_get_table_indexes --> PMA_DBI_getTableIndexes 2013-05-01 00:15:48 +05:30
Kasun Chathuranga
bc4bfaa6d5 PMA_DBI_fetch_value --> PMA_DBI_fetchValue 2013-05-01 00:02:00 +05:30
Kasun Chathuranga
32e6c06324 PMA_DBI_get_columns --> PMA_DBI_getColumns 2013-04-30 23:36:47 +05:30
Kasun Chathuranga
2becd65b1d PMA_DBI_get_columns_full --> PMA_DBI_getColumnsFull 2013-04-30 23:33:00 +05:30
Kasun Chathuranga
a85d9eaa2c PMA_DBI_get_tables --> PMA_DBI_getTables 2013-04-30 23:29:55 +05:30
Michal Čihař
2fbb4cee0d Consistently include colon in strings to translate
In some languages this makes difference in translating, so it's better
to give translators full context.
2013-04-25 14:22:31 +02:00
Rouslan Placella
0a087330fa The data dictionary is a print view page 2012-12-09 13:47:52 +00:00
Madhura Jayaratne
d8a6abce4d Clean PHP, HTML mix 2012-10-28 16:38:15 +05:30
Chanaka Indrajith
6971295e96 Renamed PMA_CommonFunctions::getInstance()-> with PMA_Util:: 2012-09-16 14:41:47 +05:30
Madhura Jayaratne
ba16e22315 Coding style improvements 2012-08-31 00:46:35 +05:30