Commit Graph

164 Commits

Author SHA1 Message Date
Michal Čihař
308c9d7951 Simplify Response object handling
- always use use and short name
- avoid calling getInstance() several times in one script

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-12-07 18:17:59 +01:00
Madhura Jayaratne
263bd601e6 Remove bookmark library includes
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2016-03-09 23:57:09 +11:00
Durgesh
0b64827930 Refactored url parmeters generating, Issue #11990
Signed-off-by: Durgesh <007durgesh219@gmail.com>
2016-02-22 14:36:41 +05:30
Madhura Jayaratne
56f684e466 Move common code inside the method
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2016-01-14 13:09:55 +11:00
Hugues Peccatte
f9d582bd09 Make PHPCS happy.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-11-08 15:58:48 +01:00
Marc Delisle
faaec8e9f4 Refactor high-level parser calling into a function
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-10-22 12:07:45 -04:00
Hugues Peccatte
7f8f34e89d Remove classes require_once.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:22 +02:00
Hugues Peccatte
0761fb1801 Rename classes files.
Rename classes.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:21 +02:00
Hugues Peccatte
f0ba28fc1d Set namespace on Advisor, Config, Console and Util classes.
Set namespace on DbQbe.
Set namespace to 'DbSearch'.
Split Advisor.class.php file.
Change Advisor namespace.
Rename DbQbe class and file.
Set namespace on DisplayResults.
Set namespace on Error.
Use namespace for ErrorHandler.
Add class autoloader.
Change ErrorHandler filename.
Remove some require.
Update Config namespace path.
Update PMA_Util to PMA\libraries\Util.
Rename Font and File classes files.
Use namespace for Footer.
Set namespace in all libraries classes.
Namespace OutputBuffering.
Export SubPartition.
Rename Partition file.
Namespace PDF.
Namespace RecentFavoriteTable.
Replace PMA_Response by Response and PMA_Message by Message.
Update uses and calls.
Fix unit tests.
Fix SqlParser autoload.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:22:52 +02:00
Marc Delisle
bb01f9b2b7 Refactor db_info.inc.php
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-08-25 11:16:59 -04:00
Madhura Jayaratne
ad49ae971e These checks are redundant. <feature>work variables should always be defined unless in an upgrade
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-07-15 19:31:37 +05:30
Dan Ungureanu
f7689d5c7e Replaced more of the old parser.
Updated sql-parser library.

Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
2015-07-10 23:18:15 +03:00
Madhura Jayaratne
6c52f2318c Merge branch 'QA_4_4' 2015-05-18 10:30:00 +05:30
Madhura Jayaratne
34f318e52d Allow accessing visual query builder when pmadb is not configured
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-05-18 10:28:57 +05:30
Marc Delisle
7c62dfd79d Make class instance match the class name
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-04-28 14:56:37 -04:00
Marc Delisle
4eccae5290 Merge pull request #1547 from znck/master
Remove unneeded closing tags
2015-03-26 07:56:45 -04:00
Rahul Kadyan
4d308ba364 Remove unneeded closing tags
Closing tags at the end of file are not mandatory. It is often
suggested to omit to closing tags at the end of file to prevent
unwanted effects as PHP will start output buffering if there is
any character after closing tag.

Reference: http://php.net/manual/en/language.basic-syntax.phptags.php

Signed-off-by: Rahul Kadyan <hi@znck.me>
2015-03-06 23:37:35 +05:30
Marc Delisle
16c171000a Merge commit '22c0249' 2015-03-05 08:37:58 -05:00
Marc Delisle
a3704ecb1d Merge branch 'QA_4_3' into QA_4_4 2015-03-05 08:36:53 -05:00
Marc Delisle
22c02499d7 Bug Undefined index savedsearcheswork
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-03-05 08:36:25 -05:00
Marc Delisle
6d56ef9c4d Remove dead code
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-01-16 06:02:39 -05:00
Marc Delisle
629e08cbc4 Code cleanup: $disp_mode was always empty at this point
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-12-28 09:48:04 -05:00
Bimal Yashodha
285c18acdd Use db_desginer.php as a route for all designer operation. Combine pmd_general.lib.php and designer.lib.php into db_designer.lib.php
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-08-14 07:22:32 +05:30
Bimal Yashodha
48dd4f354d Remove references to designer_coords and designerwork
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-06-16 11:39:39 +05:30
Madhura Jayaratne
af7e17a53d A boolean is expected here also
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-05-10 10:16:49 +02:00
Michal Čihař
55ed816931 Initialize variable (it is unset when saving of queries is disabled)
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 16:35:42 +02:00
Hugues Peccatte
34af4c4695 Remove hint about bookmarked searches.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-03-10 21:09:47 +01:00
Hugues Peccatte
ef8a1f6a05 Add new button to update a bookmarked search.
Hide buttons when not needed.
Reset form when selecting 'New bookmark'.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-03-10 21:07:00 +01:00
Hugues Peccatte
139a057c3e Rename 'Search bookmark' as 'Bookmarked search'.
Add new error when bookmarked search name is missing.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-03-03 20:43:22 +01:00
Hugues Peccatte
e39b6c5c74 Rename 'Search' as 'Search bookmark'.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-03-03 20:38:50 +01:00
Hugues Peccatte
da13840c0c Fix lost name of saved search.
Update filename of SavedSearch class.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-02-26 20:39:47 +01:00
Marc Delisle
a7bb76e045 The word "criteria" is already a plural
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-02-26 12:49:17 -05:00
Hugues Peccatte
5cf8424a7f Add hint to update a search.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-02-24 20:54:11 +01:00
Hugues Peccatte
4093df7b32 Fix warnings.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-02-24 19:35:51 +01:00
Hugues Peccatte
8b84cf0d91 Feature #569 Load/Save Query By Example
Implement possibility to save/load/delete a QBE on a DB.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-02-23 14:52:48 +01:00
Michal Čihař
b4d03dc9f5 Correct punctuation for sentences
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-02-02 11:30:39 +01:00
Michal Čihař
0a3d1d5be8 Better names for URL generating functions 2013-08-07 10:58:17 +02:00
Michal Čihař
ef30133a94 Various coding style fixes 2013-08-06 15:44:51 +02:00
Spun Nakandala
ea842c4f36 removed include sql.php from db_qbe.php 2013-07-23 21:35:18 +05:30
Madhura Jayaratne
ba16e22315 Coding style improvements 2012-08-31 00:46:35 +05:30
Atul Pratap Singh
9dece4fbef Add wrongly removed query execution part 2012-07-22 18:37:30 +05:30
Atul Pratap Singh
9ac38c49de Fix visual buider link for now 2012-07-22 16:24:17 +05:30
Atul Pratap Singh
80e13b0aca Add missing cfgRelation declaration 2012-07-22 16:16:45 +05:30
Atul Pratap Singh
c97ee5fd4b Remove some more global variables 2012-07-21 13:35:25 +00:00
Atul Pratap Singh
6132bb1299 Fix wrong require_once 2012-07-21 12:19:42 +00:00
Atul Pratap Singh
6fcbbb72d7 Use PMA_DBQbe in db_qbe.php 2012-07-20 16:28:58 +00:00
Atul Pratap Singh
0bf05d6b72 Some remaining variable name improvements 2012-07-18 12:58:47 +05:30
Atul Pratap Singh
748d2e9144 Form function to generate QBE form 2012-07-17 08:00:49 +05:30
Atul Pratap Singh
fdd851c19c Form funcion to get SQL query 2012-07-17 07:17:53 +05:30
Atul Pratap Singh
6f63f54ca9 Remove post_params 2012-07-17 07:06:57 +05:30