gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
124,669 Commits 12 Branches 481 Tags 2.4 GiB
d43f16f616
Commit Graph

4265 Commits

Author SHA1 Message Date
Maximilian Krög
d43f16f616
Fix user pagination for 'Any' user 
If the user name is empty any user may login from this host.

This fixes the pagination to display 'Any' instead of an empty string
and makes filtering with this link work.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-09-09 17:44:17 +02:00
Maximilian Krög
bf17145c70
Fix filtering by initials for user accounts starting with %, \, or _ 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-09-09 17:44:17 +02:00
Kamil Tekiela
d0e746fac6 Fix dropped triggers on rename 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-08-28 23:34:21 +01:00
Maurício Meneghini Fauth
38968ef36c
Add ChangeLog entry for #18611 
Adds unit test.

Fixes https://github.com/phpmyadmin/phpmyadmin/issues/18611
Closes https://github.com/phpmyadmin/phpmyadmin/pull/18630

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-28 16:32:49 -03:00
Sachin Bahukhandi
a8d2579c1c
Fixed the Undefined array key criteriaColumnOperators 
Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>
 2023-08-28 16:21:04 -03:00
Maurício Meneghini Fauth
2540af769b
Merge pull request #18657 from MoonE/qa-edit-change-geometry-type 
Geometry type selection only for Geometry column type
 2023-08-26 18:22:12 -03:00
Maurício Meneghini Fauth
9440dc5eda
Merge pull request #18656 from MoonE/qa-fix-editing-empty-geometry-collection 
Qa fix editing geometry collection
 2023-08-26 18:21:21 -03:00
Maximilian Krög
b04ea44362
Fix error when switching geom type in geometry collection 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-08-26 22:26:02 +02:00
Maximilian Krög
3786b40499
Geometry type selection only for Geometry column type 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-08-26 21:59:06 +02:00
Maximilian Krög
93a8f20eb9
Ignore duplicate set columns 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-08-26 21:35:44 +02:00
Maximilian Krög
62db67a47c
Show affected rows instead of matched rows in SimulateDml 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-08-26 21:35:44 +02:00
Maximilian Krög
fab0c6552d
Count number of affected rows with MySQL 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-08-26 21:35:44 +02:00
Maximilian Krög
f78683100a
Assert pre-conditions 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-08-26 21:35:43 +02:00
Maximilian Krög
15c5148dfc
No need to select actual column values 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-08-26 21:35:43 +02:00
Maximilian Krög
516efa2563
Fix simulated query with condition WHERE 0 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-08-26 21:35:43 +02:00
Maximilian Krög
836c5bd7ea
Fix some type declarations 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-08-26 21:35:39 +02:00
Kamran
135724f0d4
fix: simulate query matched rows wrong count (#18536) 
* bugfix for simulate query matched rows wrong count

Signed-off-by: kamioon <kamran.azari@gmail.com>

* remove extra parentheses
add space before and after the else keyword

Signed-off-by: kamioon <kamran.azari@gmail.com>

* replaced with suggested commit from @MoonE with the <=> operator

Signed-off-by: kamioon <kamran.azari@gmail.com>

* add parentheses for the main where condition in simulated update query

Signed-off-by: kamioon <kamran.azari@gmail.com>

* update tests for the simulated update query changes

Signed-off-by: kamioon <kamran.azari@gmail.com>

---------

Signed-off-by: kamioon <kamran.azari@gmail.com>
 2023-08-26 16:26:08 -03:00
Maurício Meneghini Fauth
fb09439ff5
Merge pull request #18650 from MoonE/result-title-attribute-escape 
Fix result cell title attribute escape
 2023-08-25 11:28:45 -03:00
Maximilian Krög
d4011ce587
Fix result cell title attribute escape 
It was escaped twice, here and in Generator::linkOrButton.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-08-25 00:05:44 +02:00
Kamil Tekiela
910c43db3b Fix: Cannot execute stored procedure with SELECT using the SQL tab 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-08-07 13:59:48 +01:00
William Desportes
1259c2638b
Fix #18578 - PDF export NULL values gives a type error 
Fixes: #18578

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-08-03 18:08:29 +02:00
William Desportes
7c975030b9
Fix #18592 - Remove instruction to remove the pma_collation_connection cookie removed in 4.8.0 
Ref: 3b6a994dcd
Fixes: #18592

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-08-03 15:00:19 +02:00
Kamil Tekiela
fb2953c487 Force string as return type of showCreate() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-07-24 19:45:24 +01:00
Liviu-Mihail Concioiu
3786a91cf0
Fix #18543 - Unsupported operand types: string - float (#18552) 
* Fix Unsupported operand types: string - float

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Improve code

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

---------

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2023-07-21 18:21:34 -03:00
William Desportes
a0d30e3de1
Update broken links in code 
[ci skip]

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-07-14 19:42:38 +02:00
William Desportes
234d7dc3e2
Add a code search hint 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-07-14 17:47:31 +02:00
William Desportes
8b4a158a1b
Ref #16005 - Remove loading on each request favorites and recents 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-07-14 17:47:30 +02:00
William Desportes
007036765f
Fix #17443 - stop reloading the navigation tree if nothing changed 
Fixes: #17443
Ref: ca54f1db05

Git bisect seems to say that ca54f1db05 is the first bad commit
And it is, in fact the `fixPmaTables` function was called with the request DB and so the code had 99.9% chance to NOT hit `$GLOBALS['reload'] = true;` since the clicked DB had no phpMyAdmin tables.
But now, it always targets first the phpmyadmin configured DB and so always does hit the reload, causing the panel to always reload

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-07-14 17:47:28 +02:00
William Desportes
d1019373ce
Fix route /database/structure/favorite-table - it does not require a db name 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-07-14 17:47:25 +02:00
Sachin Bahukhandi
0c7848083d
Fixed the Pagination missing when using SELECT DISTINCT (#18493) 
Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>
(cherry picked from commit 73efd6e03e)
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-07-13 15:11:23 -03:00
Liviu-Mihail Concioiu
82396c4f76 Fix wrong encoding of db group names 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2023-07-01 08:08:44 +02:00
Maurício Meneghini Fauth
5f7499abb0
Fix profiling chart not loading when profiling is activated 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-17 15:26:19 -03:00
Maurício Meneghini Fauth
7b88ab16af
Fix a case where a fatal error message was not displayed 
A fatal error message was not displayed when the ResponseRenderer object
already had some HTML, because the output buffer is only displayed when
there is no HTML.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-03 17:01:51 -03:00
Maurício Meneghini Fauth
64eceff4f9
Fix state times not getting summed in the profiling table 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-02 16:31:10 -03:00
Maurício Meneghini Fauth
578dbb301c
Fix SQL statement not being displayed correctly on RTL languages 
Fixes #18471

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-31 12:48:34 -03:00
Maurício Meneghini Fauth
3f587ccce4
Improve unit test for ResponseRenderer::setAjax() 
Also tests the setAjax() method of Header, Footer and Console classes.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-31 00:26:48 -03:00
Maurício Meneghini Fauth
50bca5c1cb
Fix duplicate query params in the SQL message card 
Adds tests for the Html\Generator::getMessage() method.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-17 16:06:36 -03:00
Maurício Meneghini Fauth
5ed8e65b90
Fix list of users of an user group not showing up 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-08 16:56:47 -03:00
Maurício Meneghini Fauth
6875680de9
Fix double encoding on User Groups pages 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-07 17:52:26 -03:00
Liviu-Mihail Concioiu
175d01f0e0 Add CVE link to allowed domains 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2023-05-06 01:07:04 +02:00
Liviu-Mihail Concioiu
4951bc7fea Update CVE link with the new one 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2023-05-06 01:06:11 +02:00
Liviu-Mihail Concioiu
e4615acccf Revert "Add CVE MITRE link to allowed domains" 
This reverts commit 8c068dda1d.
 2023-05-06 01:04:17 +02:00
Liviu-Mihail Concioiu
8c068dda1d Add CVE MITRE link to allowed domains 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2023-05-05 22:50:41 +02:00
William Desportes
4a5180c901
Merge #18252 - Fix #17654 - Unprivileged user cannot change password on MySQL >= 5.7.37 
Pull-request: #18252
Fixes: #17654

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-05-04 18:47:24 +02:00
William Desportes
99881debb5
Fix lint route not working correctly 
Related to 5a2baf607f
Related to https://github.com/phpmyadmin/sql-parser/pull/438

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-04-22 14:52:35 +02:00
William Desportes
a88c9a3dc0
Fix functions/routines modal contents truncated 
Related to 5a2baf607f
Related to https://github.com/phpmyadmin/sql-parser/pull/438

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-04-22 14:52:14 +02:00
Maurício Meneghini Fauth
3e7cf7cfab
Fix failing RelationTest test 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-12 16:35:28 -03:00
Maurício Meneghini Fauth
8c7c87f524
Merge pull request #18308 from win20/navigation-panel-settings-icon-issues 
Fix issues with settings icon in nav panel
 2023-04-12 16:17:48 -03:00
MoonE
0ff3f10134
Fix editing GEOMETRYCOLLECTION EMPTY (#18189) 
* Test editing empty geometry collection

- 'GEOMETRYCOLLECTION()'
- 'GEOMETRYCOLLECTION EMPTY'

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>

* Fix editing GEOMETRYCOLLECTION EMPTY

Instead of searching for first parenthesis look for word end.
Parsing was and is somewhat unsafe, though it works with the data
received from ST_AsText.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>

---------

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-04-08 15:12:40 -03:00
Maurício Meneghini Fauth
d0997e0377
Merge pull request #18188 from MoonE/qa-fix-gis-insert-form 
Fix inserting gis-data via insert/edit form
 2023-04-08 15:09:44 -03:00