Commit Graph

737 Commits

Author SHA1 Message Date
Kamil Tekiela
a01eefc4c2 Remove $timestampSeen which was always false
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-23 11:20:05 +01:00
Kamil Tekiela
36481a0dca Change if into its short form
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-23 11:20:05 +01:00
Kamil Tekiela
ae5b5a1a86 Remove $jsvkey and $vkey
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-23 11:20:05 +01:00
Kamil Tekiela
fbb185e7a9 Remove globals
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-23 11:20:05 +01:00
Kamil Tekiela
9124c19539 Remove $GLOBALS['columns_cnt']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-23 11:20:05 +01:00
Kamil Tekiela
bfe1f4facf Remove redundant argument
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-23 11:20:05 +01:00
Kamil Tekiela
b2357568a1 Use str_ends_with and str_starts_with
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-23 11:20:05 +01:00
Kamil Tekiela
269535a7a5 Change $tabindex into a private property
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-23 11:20:05 +01:00
Kamil Tekiela
a8070b5498 $tabindexForValue was always 0
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-23 11:20:05 +01:00
Kamil Tekiela
62459b33e5 Change RW param into a private property
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-23 11:20:05 +01:00
Kamil Tekiela
747941ece1 Move $returnToSqlQuery out of the method
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-23 11:20:04 +01:00
Kamil Tekiela
5cd6c16684 Instead of returning array, use array cast
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-20 16:53:19 +01:00
Kamil Tekiela
25b24966c1 Move getParamsForUpdateOrInsert into controller
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-20 16:53:19 +01:00
Kamil Tekiela
a852acb3e9 Move $isInsertignore out of getParamsForUpdateOrInsert
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-20 16:53:19 +01:00
Kamil Tekiela
8367af19be Remove unused $biggestMaxFileSize param
Not sure if it should have been a global, but judging by the rest of the code, I believe it's no longer needed.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-20 16:53:19 +01:00
Kamil Tekiela
9800c3574f Move urlParamsInEditMode to ChangeController
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-20 16:53:18 +01:00
Evgeny Skorlov
4530585ad3
Replace superglobals with serverrequest in controllers
Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-12 15:49:31 -03:00
Maurício Meneghini Fauth
514ed287c6
Merge pull request #18328 from MoonE/fieldmetadata
Refactor DbiDummy and improve FieldMetadata
2023-04-12 14:13:20 -03:00
Maurício Meneghini Fauth
4c15ace946
Merge pull request #18327 from kamil-tekiela/More-Tracking-refactoring
More tracking refactoring
2023-04-12 11:10:00 -03:00
Maurício Meneghini Fauth
7f1cddaf33
Merge pull request #18335 from kamil-tekiela/18332
Fix boolean condition
2023-04-09 18:59:30 -03:00
Kamil Tekiela
5d0de52112 Fix boolean condition
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-08 22:58:50 +01:00
Kamil Tekiela
bca265b82b Cast POST values to expected types
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-08 22:27:24 +01:00
Maximilian Krög
abf49ce9d4
Bettery types for DbiDummy / DummyResult
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-04-07 21:47:07 +02:00
Maximilian Krög
3228a19c2d
Improve FieldMetadata
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-04-07 21:46:19 +02:00
Kamil Tekiela
0be1d58b62 Move the code around
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-07 13:46:26 +01:00
Kamil Tekiela
ed586ac9cb Remove report_export param
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-07 13:46:26 +01:00
Kamil Tekiela
a89cedbed9 Fix bug introduced cca381a
cca381a415

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-07 13:46:26 +01:00
Kamil Tekiela
8e88585f69 Merge if statements
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-07 13:46:26 +01:00
Kamil Tekiela
74a0c26129 Create DTO for TrackedData
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-07 13:46:26 +01:00
Kamil Tekiela
ce35872738 Reload data instead of modifying in place
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-06 00:01:11 +01:00
Kamil Tekiela
57f4fa7583 Remove $GLOBALS['msg']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-06 00:01:11 +01:00
Kamil Tekiela
62bd41870f Remove $GLOBALS['entries']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-06 00:00:49 +01:00
Kamil Tekiela
4f0a618187 Remove useless assignment
Psalm incorrectly complains.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

sa
2023-04-06 00:00:49 +01:00
Kamil Tekiela
15885ea495 Remove $GLOBALS['filter_users']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-05 17:34:46 +01:00
Kamil Tekiela
711cb95264 Remove $_POST
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-05 17:25:05 +01:00
Kamil Tekiela
bca99f1e4d Remove deleteTrackingReportRows()
It's a hyperlink so it can't be both.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-05 17:05:50 +01:00
Kamil Tekiela
218d59c661 Move getTrackedData to Tracking
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-04 23:13:18 +01:00
Maurício Meneghini Fauth
6a2c12bdc8
Add missing traversable type hints
Replace array type hint with mixed[] type hint, since it means the same.
This way it's possible to require traversable type hint for new code.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-02 01:32:12 -03:00
Liviu-Mihail Concioiu
d9e0b9d7e7
Fix move columns (#18271)
Fix #18232 - Fix issues when moving a column

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-29 17:23:52 -03:00
Maurício Meneghini Fauth
dd885dc7b8
Use single-line arrays when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-27 17:39:17 -03:00
Maurício Meneghini Fauth
52c14a1911
Fix wrong global variable name
Introduced by 437215cab2

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-27 12:42:13 -03:00
Maurício Meneghini Fauth
e5698c85e9
Require single line for function calls
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-26 23:10:10 -03:00
Maurício Meneghini Fauth
437215cab2
Rename variables to use camel case format
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-26 21:47:50 -03:00
Maurício Meneghini Fauth
802d8f13b6
Merge pull request #18203 from kamil-tekiela/first-class-callable
Use first class callables
2023-03-25 15:16:07 -03:00
Kamil Tekiela
8eb023bcce Remove last public use of Tracker::isTracked
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 22:36:25 +00:00
Kamil Tekiela
ebbf2e8d01 Remove unused params
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 22:35:34 +00:00
Kamil Tekiela
c0b367cc57 Create Tracking namespace
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 22:35:32 +00:00
Kamil Tekiela
3ecf14df34 Fixing erroneous params
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 12:47:43 +00:00
Kamil Tekiela
3774c29604 Fix implicit nulls
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 12:45:18 +00:00
Kamil Tekiela
555c6798eb Add native param types
Includes TypeHints.UnionTypeHintFormat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 12:45:18 +00:00