Commit Graph

45 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
a256228264
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-08 17:09:46 -03:00
Maurício Meneghini Fauth
5ed8e65b90
Fix list of users of an user group not showing up
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-08 16:56:47 -03:00
Maurício Meneghini Fauth
86ea50336b
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-07 18:13:26 -03:00
Maurício Meneghini Fauth
6875680de9
Fix double encoding on User Groups pages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-07 17:52:26 -03:00
Maurício Meneghini Fauth
835fc2715d
Redesign the User Groups form page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-07 16:44:14 -03:00
Maurício Meneghini Fauth
3e7cf7cfab
Fix failing RelationTest test
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-12 16:35:28 -03:00
Maurício Meneghini Fauth
51d00adc43
Fix failing RelationTest test
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-11 20:04:18 -03:00
Maurício Meneghini Fauth
2dd7b751a1
Fix failing RelationTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-11 19:18:23 -03:00
Maurício Meneghini Fauth
e104f66d97
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-11 15:46:30 -03:00
William Desportes
4cec0f1163
Stop pmadb database detection when all features are disabled
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-04-08 13:42:44 +02:00
William Desportes
b3138ff282
Fix tests for relation
Ref: e0dc515638

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-04-07 13:02:04 +02:00
William Desportes
e0dc515638
Add tests for #18266 - unable to disable a feature
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-04-05 19:19:03 +02:00
Maurício Meneghini Fauth
656474179d
Merge pull request #18318 from kamil-tekiela/refactor-relation
Refactor relation
2023-04-05 10:43:03 -03:00
Kamil Tekiela
357680474e Memoize Relation
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-04 11:59:29 +01:00
Kamil Tekiela
9fcafd2504 Improve method name
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-02 23:50:46 +01:00
Maurício Meneghini Fauth
dd885dc7b8
Use single-line arrays when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-27 17:39:17 -03:00
Maurício Meneghini Fauth
437215cab2
Rename variables to use camel case format
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-26 21:47:50 -03:00
Kamil Tekiela
a6cfa894be Use quoteString in UserGroups
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-02 21:47:16 +00:00
Maurício Meneghini Fauth
16a0660a78
Add native property types to test classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-27 01:17:22 -03:00
Maurício Meneghini Fauth
556594b4cd
Fix coding standard spacing issues
- Fixes one line doc comments
- Fixes parent call spacing
- Fixes constant spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-24 21:06:17 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-24 20:48:46 -03:00
Maurício Meneghini Fauth
1ffd881fb4
Refactor ConfigStorage\RelationCleanup::user()
- Replaces escapeString() with quoteString()

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-21 18:22:39 -03:00
Maurício Meneghini Fauth
b4f9063ceb
Refactor ConfigStorage\RelationCleanup::database()
- Replaces escapeString() with quoteString()

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-21 17:54:20 -03:00
Maurício Meneghini Fauth
bddaa399af
Refactor ConfigStorage\RelationCleanup::table()
- Replaces escapeString() with quoteString()

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-21 17:19:10 -03:00
Maurício Meneghini Fauth
c4a5440cf0
Refactor ConfigStorage\RelationCleanup::column()
- Replaces escapeString() with quoteString()

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-21 15:51:24 -03:00
Maurício Meneghini Fauth
0ba371f921
Refactor ConfigStorage\UserGroups::delete()
- Extracts dbi global variable
- Replaces escapeString with quoteString

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-21 14:40:25 -03:00
Maurício Meneghini Fauth
0ab9e4ac77
Change PHPUnit data providers to use static methods
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-14 12:42:16 -03:00
Maurício Meneghini Fauth
346923e20a
Set dbi only when the test needs it
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17637

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-14 02:21:45 -03:00
Maurício Meneghini Fauth
4fdd7f6011
Refactor ConfigStorage\RelationTest test class
Inline the dbi and dbiDummy properties.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-17 04:32:18 -03:00
Maurício Meneghini Fauth
99fee58b0d Improve RelationCleanupTest class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-15 01:18:32 -03:00
Maurício Meneghini Fauth
1faab7119d
Fix bug when renaming tables with config storage enabled
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17359

Introduced by https://github.com/phpmyadmin/phpmyadmin/pull/17256

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-09 13:58:35 -03:00
Kamil Tekiela
f5bb90ebb9 Move queryAsControlUser - Dbal refactoring pt.3
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-06 19:31:27 +00:00
Kamil Tekiela
47a039d70c Implement ResultInterface & MysqliResult
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-31 23:59:24 +00:00
Maurício Meneghini Fauth
feca48cc76
Change return type of DatabaseInterface::getError method
Now, it returns last error message or an empty string instead of false
if no errors occurred.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-27 14:43:14 -03:00
Maurício Meneghini Fauth
fb1a7c1a52
Improve RelationParameters tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-26 19:17:59 -03:00
Maurício Meneghini Fauth
d84af02945
Create VO classes for each RelationParameters features
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
7b21d2af24
Remove RelationParameters::$version property
It is only used to save to the Session.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
c4e2582e56
Use TableName for RelationParameters tables
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-26 19:17:57 -03:00
Maurício Meneghini Fauth
44fe103b9c
Remove @access annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-22 11:43:45 -03:00
Maurício Meneghini Fauth
bf49480160
Populate relation Session with RelationParameters class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:15 -03:00
Maurício Meneghini Fauth
42e4dd519e
Refactor Relation::getRelationParameters method
Makes checkRelationsParam method private.
Saves 'relation' to Session from RelationParameters class

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:14 -03:00
Maurício Meneghini Fauth
ce18740be4
Remove passing null to Relation's constructor
Related to d296860a67.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:14 -03:00
Maurício Meneghini Fauth
cb3f7fbb16
Move Server\UserGroups to ConfigStorage namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:14 -03:00
Maurício Meneghini Fauth
995ec44d13
Move DatabaseInterface::initRelationParamsCache method to Relation class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:13 -03:00