gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
125,722 Commits 12 Branches 481 Tags 2.4 GiB
d96c061013
Commit Graph

226 Commits

Author SHA1 Message Date
Kamil Tekiela
276577ca2a
Remove $GLOBALS['PMA_PHP_SELF'] (#18149) 
* Remove $GLOBALS['PMA_PHP_SELF']

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove $GLOBALS['PMA_PHP_SELF'] from tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Moved cleanupPathInfo to Routing

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove parse_url from getRootPath

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove invalid tests

Surely, we never expect PATH to be backslash delimited. The code is not designed to handle this and the tests for this don't make much sense.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix trailing slash in path

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-27 17:56:27 -03:00
Maurício Meneghini Fauth
f9c8035768
Add native parameter types to test classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-27 01:54:03 -03:00
Maurício Meneghini Fauth
16a0660a78
Add native property types to test classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-27 01:17:22 -03:00
Maurício Meneghini Fauth
556594b4cd
Fix coding standard spacing issues 
- Fixes one line doc comments
- Fixes parent call spacing
- Fixes constant spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 21:06:17 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 20:48:46 -03:00
Maurício Meneghini Fauth
cb67fa306d
Remove Reflection's setAccessible() method 
This method is no-op since PHP 8.1.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-21 20:35:45 -03:00
Maurício Meneghini Fauth
4ff3724c3f
Use union with null instead of short nullable type 
Since union type are now possible, using union with null makes more
clear that it is a union type.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 21:48:19 -03:00
Maurício Meneghini Fauth
0ab9e4ac77
Change PHPUnit data providers to use static methods 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-14 12:42:16 -03:00
Kamil Tekiela
78de670d61 Fix incomplete test after previous PR 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-01-28 14:01:26 +00:00
Maurício Meneghini Fauth
fdf474abf9
Merge pull request #17981 from kamil-tekiela/getTables-investigation 
Improve some type inference in various places

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-12-24 13:44:45 -03:00
Kamil Tekiela
2bda275524 Add better type inference 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-20 18:55:03 +00:00
Kamil Tekiela
6735938f12 Remove dependancy in Table/StructureController 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-16 20:58:48 +00:00
Maurício Meneghini Fauth
13890a947a
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-12-16 11:53:18 -03:00
MoonE
4e529ae399
Refactor gis color (#17895) 
* Use int srid in gis tests

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>

* Typecheck gis color

Only use array<int> as color

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2022-11-30 14:49:06 -03:00
Maurício Meneghini Fauth
95c9fa430c
Merge pull request #17889 from kamil-tekiela/Index-controllers 
Refactor Index controllers
 2022-11-30 13:58:56 -03:00
William Desportes
420485a41b
Fix tests after e28bc2d8f6 
Ref: e28bc2d8f6

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-20 18:29:07 +01:00
Maurício Meneghini Fauth
ca489f3b41
Improve type of DatabaseInterface::getLowerCaseNames() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-19 15:50:14 -03:00
Maurício Meneghini Fauth
b2eb6bf4c9
Extract config load and check from Config's constructor 
This allows better handling of the user's config loading and validation.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-15 13:20:13 -03:00
Maurício Meneghini Fauth
d0d90551c3 Remove the dblist global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-13 21:08:00 -03:00
Kamil Tekiela
ff2e7f6334 Move methods to Indexes.php 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-11 22:24:27 +00:00
Maurício Meneghini Fauth
0bd9391476
Merge pull request #17862 from kamil-tekiela/Refactor-displayHtmlForColumnChange 
Refactor ChangeController and use ServerRequest
 2022-11-05 12:49:55 -03:00
Kamil Tekiela
b3d97a47ef Refactor ChangeController and use ServerRequest 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-02 21:57:31 +00:00
Kamil Tekiela
15915a45e0 Send DBI to SqlQueryForm using DI 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-02 15:15:58 +00:00
Maurício Meneghini Fauth
25fe766a26
Fix tests marked as incomplete 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-31 20:22:54 -03:00
Sebastian Walther
edfe8a5881
Replace POST-var access with Serverrequest object - pt 2 (#17787) 
* Use ServerRequestObject to access POST-vars

Signed-off-by: Sebastian Walther <swalther@complex-it.de>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-19 22:06:35 -03:00
Kamil Tekiela
3e5f101d6f Make Triggers a dependency 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-18 13:53:14 +01:00
Kamil Tekiela
f2a83311ae Simplify onchange in InsertEdit.php 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-17 21:28:57 +01:00
Jesper Skytte Marcussen
23995b3c73
Adding inputmode numeric to integer fields (#17753) 
* Adding inputmode numeric to integer fields

To easier use phpMyAdmin on touch devices with virtual keyboards, adding the inputmode ensures that the correct virtual keyboard is shown per default when focusing the field.

See https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inputmode for more information.

Related to #17745.

Signed-off-by: Jesper Skytte <jesper@skytte.it>
 2022-10-09 15:26:32 -03:00
Maurício Meneghini Fauth
135cd76d3b
Fix exception for invalid db and table names for the privileges page 
Related to #17729

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-30 20:49:21 -03:00
Maurício Meneghini Fauth
bb97ed988f
Reduce usage of the containerBuilder global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-29 22:36:46 -03:00
Maurício Meneghini Fauth
f54cc49f86
Remove loadContainerBuilder call from AbstractTestCase::setUp method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-29 20:22:31 -03:00
Maurício Meneghini Fauth
9d2350d28c
Extract dbi global variable from Index::loadIndexes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-07 21:59:03 -03:00
Maurício Meneghini Fauth
c36dd24b59
Add unit tests for Table\Structure\SpatialController class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-20 18:21:07 -03:00
Maurício Meneghini Fauth
ec03bac629
Add unit tests for Table\Structure\UniqueController class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-20 17:23:15 -03:00
Maurício Meneghini Fauth
3c618c22a9
Add ServerRequest parameter to all controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-28 01:00:08 -03:00
Maurício Meneghini Fauth
b0c4426a43
Add basic tests for Controllers\Table\Partition classes 
Adds better message for invalid partition name.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-27 15:29:02 -03:00
Maurício Meneghini Fauth
c6c28498e4
Add basic tests for Controllers\Table\Maintenance classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-26 20:55:36 -03:00
Maurício Meneghini Fauth
31bfbbe816
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-20 20:57:41 -03:00
Maurício Meneghini Fauth
dbe3db564e
Fix Enum/Set editor error when creating a new column 
Fixes #17551

https://github.com/phpmyadmin/phpmyadmin/issues/17551#issuecomment-1136074722

Co-authored-by: William Desportes <williamdes@wdes.fr>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-20 20:54:07 -03:00
Maurício Meneghini Fauth
cba9b38a28
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-19 15:51:12 -03:00
Ankush Patil
987cb5043d
fixed find replace regex issue if no matching result set found 
When find and replace searching used with regex, at the time of replace
empty CASE END condition was causing issue.

Fixes #17388
Closes #17641

Signed-off-by: Ankush Patil <aspraz2658@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-19 15:28:43 -03:00
Maurício Meneghini Fauth
346923e20a
Set dbi only when the test needs it 
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17637

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-14 02:21:45 -03:00
Maurício Meneghini Fauth
63d57b1f1c
Push dbi and dummyDbi members down 
The idea is to only load the DBI when needed.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-13 00:15:53 -03:00
Maurício Meneghini Fauth
72a69471e8
Remove the AbstractTestCase::assertAllSelectsConsumed method 
Uses the DummyDbi method instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-11 16:38:37 -03:00
Maurício Meneghini Fauth
8543e0abe5
Load DBI into container only when needed by the test 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-11 13:42:22 -03:00
Maurício Meneghini Fauth
8116903ba6
Create dbi for each test in Table\ReplaceControllerTest 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-08 19:54:14 -03:00
Maurício Meneghini Fauth
3ac11ffa75
Introduce the ServerRequest object to ChangeController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-08 19:12:19 -03:00
Maurício Meneghini Fauth
eb3703882b
Move Routing::getCurrentRoute to ServerRequest 
The route is retrieved from the request, so it makes sense to move the
method to the Http\ServerRequest class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-06 23:36:57 -03:00
Maurício Meneghini Fauth
27bdd0d64d
Extract InsertEdit dependencies to constructor params 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-01 23:42:47 -03:00
Maurício Meneghini Fauth
dc5bf0074c
Extract Table\PrivilegesController from Server\PrivilegesController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-27 16:25:39 -03:00