Deven Bansod
02eeb21df8
Add missing Doc comment
...
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-09-26 21:51:22 +05:30
Michal Čihař
61d8dc4791
Merge branch 'QA_4_6'
2016-09-19 10:47:31 +02:00
Michal Čihař
3546bed47e
Avoid using mb_strlen for checking whether string is empty
...
Using strlen produces same results here, just way faster.
Fixes #12397
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-09-16 10:29:21 +02:00
Deven Bansod
a52597f048
Include explaning statements near related code
...
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-09-16 13:56:15 +05:30
Deven Bansod
023ced3552
Don't use PMA_DROP_IMPORT on Table insert if it has Blob field
...
If we force PMA_DROP_IMPORT on all pages, users can't use Chrome's drag-drop-files feature
on Table Insert page with blob field
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-09-16 13:55:46 +05:30
Michal Čihař
d3222bd925
Merge branch 'QA_4_6'
2016-08-17 11:22:07 +02:00
Pavel Rochnyack
c660c627f0
When editing table records, display readonly inputs for fields without write access .
...
Signed-off-by: Pavel Rochnyack <pavel2000@ngs.ru>
2016-08-14 19:51:51 +01:00
Pavel Rochnyack
c274f193a1
Revert "fixed checking of user rights to make it look for database privileges"
...
This reverts commit df137f2410 .
Signed-off-by: Pavel Rochnyack <pavel2000@ngs.ru>
2016-08-14 18:14:34 +01:00
Michal Čihař
a7cd193554
Make it clear whether addMessages expects string or Message object
...
With this, it's way easier to anaylize code for potential problems with
escaping.
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-16 14:56:41 +02:00
Isaac Bennetch
e6db8e18ee
Fix some CodeSniffer warnings and errors
...
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2016-06-12 23:12:23 -04:00
sfobiwahn
df137f2410
fixed checking of user rights to make it look for database privileges
...
Signed-off-by: Florian Steenblock <florian.steenblock@gmail.com>
2016-05-26 17:10:57 +02:00
Madhura Jayaratne
6b84c576c7
Merge branch 'QA_4_6'
...
Conflicts:
ChangeLog
README
doc/conf.py
libraries/Config.php
2016-03-24 17:54:22 +11:00
Madhura Jayaratne
7a444c2f17
Fix #12120 PMA_Util not found in insert_edit.lib.php
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2016-03-24 17:47:47 +11:00
Durgesh
6650f7b07d
Refactor text sanitization and javascript escaping, Issue #11989 , #11988
...
Signed-off-by: Durgesh <007durgesh219@gmail.com>
2016-02-22 14:45:19 +05:30
Durgesh
0b64827930
Refactored url parmeters generating, Issue #11990
...
Signed-off-by: Durgesh <007durgesh219@gmail.com>
2016-02-22 14:36:41 +05:30
Madhura Jayaratne
f1dbd56798
Merge branch 'QA_4_5' into QA_4_6
2016-02-12 19:43:25 +11:00
Madhura Jayaratne
04181fb2b9
Fix #11911 Inserts via tbl_change.php in VARBINARY columns does not allow using HEX() and MD5()
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2016-02-12 19:32:52 +11:00
Madhura Jayaratne
59342451ab
Fix #11909 Can't insert row into table that contains generated column
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
Conflicts:
ChangeLog
2016-02-11 21:11:16 +11:00
Madhura Jayaratne
cab738cbed
Fix #11909 Can't insert row into table that contains generated column
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2016-02-11 21:02:33 +11:00
Michal Čihař
4a3f055527
Free result only if it exists
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 09:12:19 +01:00
Michal Čihař
55b317c699
Remove /*overload*/ prefix from mb_* calls
...
I believe this was temporary flagging to see which code is migrated and
can be safely removed now.
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-04 16:35:28 +01:00
Hugues Peccatte
eda2816c70
Replace font tags by span.
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-12-11 23:04:12 +01:00
Hugues Peccatte
08cdf6f2fd
Merge branch 'master' into psr1_master
2015-11-08 16:16:05 +01:00
Hugues Peccatte
c3e1c981c0
Make PHPCS happy.
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-11-08 16:05:25 +01:00
Hugues Peccatte
f9d582bd09
Make PHPCS happy.
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-11-08 15:58:48 +01:00
Hugues Peccatte
dffc8c34e9
Remove logic code in declaration files.
...
Move declaration out of logic file.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-10-27 18:56:39 +01:00
Michal Čihař
1169c0ef9e
Be a bit more consistent in using full stop
...
Move full stop to end of sentence or add it to sentences where it is
missing. This just fixes common places where translators tend to use
sentence with full stop but we don't.
Signed-off-by: Michal Čihař <michal@cihar.com>
2015-10-15 11:46:33 +02:00
Hugues Peccatte
857c8a92cf
Move abstract transformation plugins to abs folder.
...
Update templates.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-12 14:13:31 +02:00
Hugues Peccatte
42c0ebac85
Merge branch 'master' into useNamespaces_master
2015-09-09 22:05:00 +02:00
Madhura Jayaratne
93bfdbe371
Remove more references to Drizzle
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-09-10 01:06:58 +10:00
Hugues Peccatte
178a6edd38
Add namespace on part of plugins classes.
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-05 00:33:42 +02:00
Hugues Peccatte
f0ba28fc1d
Set namespace on Advisor, Config, Console and Util classes.
...
Set namespace on DbQbe.
Set namespace to 'DbSearch'.
Split Advisor.class.php file.
Change Advisor namespace.
Rename DbQbe class and file.
Set namespace on DisplayResults.
Set namespace on Error.
Use namespace for ErrorHandler.
Add class autoloader.
Change ErrorHandler filename.
Remove some require.
Update Config namespace path.
Update PMA_Util to PMA\libraries\Util.
Rename Font and File classes files.
Use namespace for Footer.
Set namespace in all libraries classes.
Namespace OutputBuffering.
Export SubPartition.
Rename Partition file.
Namespace PDF.
Namespace RecentFavoriteTable.
Replace PMA_Response by Response and PMA_Message by Message.
Update uses and calls.
Fix unit tests.
Fix SqlParser autoload.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:22:52 +02:00
Marc Delisle
16c5137ee7
Remove unneeded code
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-08-30 08:25:09 -04:00
Hugues Peccatte
bd707b871d
Update PHPDoc.
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-08-24 23:34:50 +02:00
Madhura Jayaratne
0a5163826f
Remove the hidden field having the same name as the enum select
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-08-11 15:49:02 +05:30
Madhura Jayaratne
c21377d2da
Fix #10307 Replication broken when using cross-database master/slave config and phpmyadmin
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-07-29 08:29:25 +05:30
Dan Ungureanu
cb9cc68fe9
Fixed more issues.
...
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
2015-07-25 19:39:33 +03:00
Madhura Jayaratne
05dca3d776
More column types
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-07-21 13:58:03 +05:30
Dan Ungureanu
91b97fadc2
Remove unneeded closing tags.
...
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
2015-07-19 00:18:38 +03:00
Dan Ungureanu
c34cf9ff29
More refactoring.
...
Updated sql-parser library.
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
2015-07-10 23:18:16 +03:00
Madhura Jayaratne
926e310a59
Workaround for column privileges for Drizzle
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-06-24 11:58:17 +05:30
Madhura Jayaratne
ff1592483a
rfe #689 Column privileges and update
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-06-24 11:51:29 +05:30
Jason
cb771052c8
Finish refactoring tbl_*.lib.php
...
Signed-off-by: Jason <jason.daurus@gmail.com>
2015-06-17 01:14:27 +08:00
Marc Delisle
0740c4b2b6
Clarify variable
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-06-10 08:41:48 -04:00
Marc Delisle
0eb78a8ff2
Use strict comparison
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-06-09 17:22:34 -04:00
Marc Delisle
37df4b7715
Fix loose comparison
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-06-09 17:08:14 -04:00
Madhura Jayaratne
758ec7b5ae
Performance improvements: Avoid expensive PMA_Table::analyzeStructure() call
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-06-05 20:20:02 +05:30
Madhura Jayaratne
096535fa8a
Remove trailing white spaces
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-05-08 21:09:41 +05:30
Marc Delisle
375f6cb954
Clarify variable name and doc
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-05-07 13:31:48 -04:00
Marc Delisle
468346df20
Merge branch 'QA_4_4'
2015-05-05 14:33:03 -04:00