Michal Čihař
3546bed47e
Avoid using mb_strlen for checking whether string is empty
...
Using strlen produces same results here, just way faster.
Fixes #12397
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-09-16 10:29:21 +02:00
Michal Čihař
c2ca1c8c22
Merge branch 'QA_4_6-security' into master-security
2016-07-12 16:58:46 +02:00
Michal Čihař
80b03a4f16
Ensure page number is integer
...
Even if somebody decides to change configuration storage structure.
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-12 16:57:35 +02:00
Michal Čihař
1277bc4666
Remove unused parameter
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-16 14:06:18 +02:00
Michal Čihař
9348d0cb16
Separate adding HTML markup to message from others
...
We really want this to be explicit for easier review and hiding this in
second parameter of addParam doesn't make it.
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-16 13:41:35 +02:00
Madhura Jayaratne
46dee5d1eb
Merge branch 'QA_4_6'
2016-03-16 20:50:16 +11:00
Madhura Jayaratne
2f1c996409
Fix #12099 Undefined index: controllink
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2016-03-16 20:44:32 +11:00
Durgesh
0b64827930
Refactored url parmeters generating, Issue #11990
...
Signed-off-by: Durgesh <007durgesh219@gmail.com>
2016-02-22 14:36:41 +05:30
Michal Čihař
2a9fb73f92
Remove PmaAbsoluteUri from redirects
...
This is no longer needed as per RFC 7231.
Issue #11412
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-03 14:32:14 +01:00
Michal Čihař
9586b8c142
Add missing space to separate two strings
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-22 10:38:54 +01:00
Michal Čihař
125ad7c7c5
Remove trailing space from a string
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-22 10:20:44 +01:00
Marc Delisle
6fd7fc443d
Improve message
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2016-01-09 07:50:24 -05:00
Marc Delisle
8ef3213f09
Merge branch 'QA_4_5'
2016-01-08 10:13:26 -05:00
Marc Delisle
b8b58486cc
Fixes #11804 Misleading message for configuration storage
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2016-01-08 10:13:01 -05:00
Michal Čihař
55b317c699
Remove /*overload*/ prefix from mb_* calls
...
I believe this was temporary flagging to see which code is migrated and
can be safely removed now.
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-04 16:35:28 +01:00
Hugues Peccatte
eda2816c70
Replace font tags by span.
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-12-11 23:04:12 +01:00
Hugues Peccatte
22d93ba92f
Merge remote-tracking branch 'origin/master' into psr1_master
2015-11-15 17:08:12 +01:00
Madhura Jayaratne
870c2c448b
Fix notices about undefined indexes
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-11-12 22:17:10 +11:00
Madhura Jayaratne
407b68441d
Fix #11641 Ability to disable the navigationhiding Feature
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-11-12 17:41:11 +11:00
Hugues Peccatte
08cdf6f2fd
Merge branch 'master' into psr1_master
2015-11-08 16:16:05 +01:00
Hugues Peccatte
f9d582bd09
Make PHPCS happy.
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-11-08 15:58:48 +01:00
Hugues Peccatte
dffc8c34e9
Remove logic code in declaration files.
...
Move declaration out of logic file.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-10-27 18:56:39 +01:00
Hugues Peccatte
42c0ebac85
Merge branch 'master' into useNamespaces_master
2015-09-09 22:05:00 +02:00
Madhura Jayaratne
e4fcf439f9
Remove references to data_dictionary
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-09-10 01:06:54 +10:00
Madhura Jayaratne
c196b189af
Remove Drizzle support from table related functionalities
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-09-10 01:02:44 +10:00
Hugues Peccatte
7f8f34e89d
Remove classes require_once.
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:22 +02:00
Hugues Peccatte
0761fb1801
Rename classes files.
...
Rename classes.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:21 +02:00
Hugues Peccatte
f0ba28fc1d
Set namespace on Advisor, Config, Console and Util classes.
...
Set namespace on DbQbe.
Set namespace to 'DbSearch'.
Split Advisor.class.php file.
Change Advisor namespace.
Rename DbQbe class and file.
Set namespace on DisplayResults.
Set namespace on Error.
Use namespace for ErrorHandler.
Add class autoloader.
Change ErrorHandler filename.
Remove some require.
Update Config namespace path.
Update PMA_Util to PMA\libraries\Util.
Rename Font and File classes files.
Use namespace for Footer.
Set namespace in all libraries classes.
Namespace OutputBuffering.
Export SubPartition.
Rename Partition file.
Namespace PDF.
Namespace RecentFavoriteTable.
Replace PMA_Response by Response and PMA_Message by Message.
Update uses and calls.
Fix unit tests.
Fix SqlParser autoload.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:22:52 +02:00
Marc Delisle
93d0534439
Fix return type
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-08-23 09:55:19 -04:00
Hugues Peccatte
6a93a350cc
Templating ul tag.
...
Templating li tag.
Use li template in getHtmlTab.
Use ul/li templates in libraries/user_preferences.inc.php.
Add/update PHPDoc of templates.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-08-09 14:24:44 +02:00
Hugues Peccatte
56c07e6f35
Make PHPCS happy.
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-07-25 22:51:02 +02:00
Jason
6636153071
Resolve conflicts from upstream
...
Signed-off-by: Jason <jason.daurus@gmail.com>
2015-07-23 11:29:53 +08:00
Dan Ungureanu
91b97fadc2
Remove unneeded closing tags.
...
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
2015-07-19 00:18:38 +03:00
Madhura Jayaratne
1599481faa
bug #4984 Undefined <feature>work upon upgrade to new version
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-07-17 09:38:09 +05:30
Madhura Jayaratne
90b5983ddf
Add a method to get CREATE TABLE statement to PMA_Table class
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-07-13 18:10:12 +05:30
Dan Ungureanu
3c9aeef364
Updated sql-parser library.
...
Refactoring and coding style fixes.
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
2015-07-10 23:18:14 +03:00
Dan Ungureanu
484d456f59
Use new parser for relations.
...
Updated sql-parser library.
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
2015-07-10 23:18:14 +03:00
Madhura Jayaratne
b0ae16fcd6
These are also internal directives. Remove underscore to match with other similar ones
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-07-09 17:15:10 +05:30
Madhura Jayaratne
f0664e7875
This is an internal directive. Use without underscore to match other similar ones
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-07-09 17:12:21 +05:30
Madhura Jayaratne
8c6261c73f
Underscores are preferred to separate words in configuration storage table names/directives
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-07-09 17:06:28 +05:30
Madhura Jayaratne
545db4a443
rfe #812 store export definitions for reuse
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-07-02 21:03:57 +05:30
Isaac Bennetch
bb435183a3
Merge pull request #1737 from devenbansod/rfe1060_new
...
Designer settings saved in a new table in configuration storage
2015-06-22 22:42:52 -04:00
Deven Bansod
54a480e8eb
Designer settings saved in a new table in configuration storage
...
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2015-06-21 15:44:39 +05:30
Madhura Jayaratne
0065c7c452
Remove unused variables
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-06-18 11:47:21 +05:30
Madhura Jayaratne
115607abb2
bug #4510 QBE generates wrong query
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-06-11 21:27:06 +05:30
Madhura Jayaratne
ce304b3157
Remove database name for consistency
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-06-11 13:53:02 +05:30
Hugues Peccatte
18625f3bbf
Update PHPDoc and minor coding style modifications.
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-05-17 13:15:08 +02:00
Madhura Jayaratne
a22bb26d7e
Remove extra space after doc comments
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-04-28 10:42:21 +05:30
Madhura Jayaratne
8b1cbaf988
rfe #1635 Have ZeroConf create phpmyadmin DB if possible
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-04-03 15:32:36 +05:30
Marc Delisle
dd6cbe9c66
Fix typo
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-02-08 06:38:29 -05:00