Commit Graph

84 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
77518d341e Remove unused use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
f6a17433a2 Use null coalesce operator when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 20:16:58 -03:00
Maurício Meneghini Fauth
301835e9a6 Create SqlAutoCompleteController
Moves database sql autocomplete entry point logic to the
Database\SqlAutoCompleteController and removes the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 18:22:52 -03:00
Maurício Meneghini Fauth
fa6fc404fe Create Table\TriggersController
Moves database|table triggers entry point logic to
Database|Table\TriggersController and removes the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 17:53:18 -03:00
Maurício Meneghini Fauth
8a800070bd Moves db routines entry point logic to the controller
Removes the database routines entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 11:38:32 -03:00
Maurício Meneghini Fauth
958ba8822d Create Database\OperationsController
Moves database operations entry point logic to the
Database\OperationsController controller and removes the entry point
file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-09 18:12:00 -03:00
Maurício Meneghini Fauth
2f3f768357 Refactor Controller\Database\EventsController
Moves database events entry point logic to the Database\EventsController
controller and remove the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-08 16:57:07 -03:00
Maurício Meneghini Fauth
351e34ecf5 Upgrade PHPStan to version 0.12.0
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-07 20:26:39 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Maurício Meneghini Fauth
a0a44fd01e Move db search entry point logic to a new controller
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-30 18:49:57 -03:00
Maurício Meneghini Fauth
fcde861b97 Move db qbe entry point logic to a new controller
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-28 20:43:56 -03:00
Maurício Meneghini Fauth
b3b3d5efd2 Move db designer entry point logic to a controller
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-26 20:57:50 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567)
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
Maurício Meneghini Fauth
acd62791b8 Move database structure entry point to routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-03 21:01:00 -03:00
Maurício Meneghini Fauth
5227fbf26b Move database multi table query entry point to routes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-02 21:54:09 -03:00
Oleg Abrazhaev
43e1d4cade use twig in Structure and Variables controller and add missing tests #14801 (#15534)
* use twig in Structure and Variables controller and add missing tests #14801

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>

* fix lint

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>

* Update templates/database/structure/overhead.twig

fix code review

Co-Authored-By: Maurício Meneghini Fauth <mauricio@fauth.dev>

* Update libraries/classes/Controllers/Database/StructureController.php

fix code review

Co-Authored-By: Maurício Meneghini Fauth <mauricio@fauth.dev>

* fix code review

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>
2019-10-29 22:48:29 -03:00
Maurício Meneghini Fauth
998d833c0c Move database data dictionary to routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-27 19:53:21 -03:00
Maurício Meneghini Fauth
672aee2d8a Create Database\PrivilegesController
Extracts Server\Privileges::getHtmlForSpecificDbPrivileges method to a
controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-29 21:09:24 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
208b0e25e1 Use the router for the sql pages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-03 21:25:27 -03:00
Maurício Meneghini Fauth
efe576cdc0 Fix double encoding in database struture page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-22 23:24:52 -03:00
Maurício Meneghini Fauth
aec0402679 Use the router for table structure page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-19 20:18:06 -03:00
Maurício Meneghini Fauth
682e7a160e Use the router for database structure page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-18 14:33:43 -03:00
Maurício Meneghini Fauth
064e5eef0a Use Collation value object when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-28 23:01:30 -03:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
0feae32056 Rename Sanitize::sanitize to Sanitize::sanitizeMessage
...to avoid the PHP 4 constructor format

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 15:21:48 -03:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00
William Desportes
96fc4d45af
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-03 21:29:07 +02:00
Hugues Peccatte
9abd308837 Inject dependencies (#15271)
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-01 15:13:41 -03:00
Eugene Kazakov
9edcc5e43a Bug #10846 TypeError: Cannot read property 'substring' of undefined
Signed-off-by: Eugene Kazakov <ekazakov@plesk.com>
2019-05-31 18:21:30 +02:00
Maurício Meneghini Fauth
dfd49d16b8 Fix ESLint warnings in js/functions.js
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-30 17:30:16 -03:00
Hugues Peccatte
380707fbcd Define controllers as services in an external configuration file
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-19 01:54:44 +02:00
Hugues Peccatte
3243a9158d Remove use of unexisting variables
Remove useless variables

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-11 00:34:57 +02:00
Nitish Bahl
2b0a36eb21 Fix #14926 - Filling existing fields form while editing a view
Fix: #14926
See: #14916
Signed-off-by: Nitish Bahl <nitishbahl24@gmail.com>
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-25 22:31:29 +01:00
Maurício Meneghini Fauth
4d9da96469 Create server, database and table SqlControllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-23 22:41:29 -03:00
Maurício Meneghini Fauth
f1f109ac26 Create Database\MultiTableQueryController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-22 12:22:27 -03:00
Maurício Meneghini Fauth
a9115725b2 Create database RTE controllers
- Create PhpMyAdmin\Controllers\Database\RoutinesController
- Create PhpMyAdmin\Controllers\Database\TriggersController
- Create PhpMyAdmin\Controllers\Database\EventsController
- Remove libraries/rte/rte_main.inc.php

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-22 02:35:45 -03:00
Maurício Meneghini Fauth
c9371d3a91 Rename Controller to AbstractController
Rename PhpMyAdmin\Controllers\Controller to
PhpMyAdmin\Controllers\AbstractController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-11 15:57:14 -03:00
Maurício Meneghini Fauth
0305c0a2c2 Rename Database\Controller to Database\AbstractController
Rename PhpMyAdmin\Controllers\Database\Controller to PhpMyAdmin\Controllers\Database\AbstractController

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-11 15:04:28 -03:00
Maurício Meneghini Fauth
50ec2c0e2b Create Controllers\Database\CentralColumnsController
Moves db_central_columns.php logic to the controller

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-03-05 02:12:12 -03:00
Maurício Meneghini Fauth
e700760685 Refactor Controllers\Database\StructureController
Move request and response handling to db_structure.php

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-03-03 23:20:48 -03:00
Maurício Meneghini Fauth
35fafd773a Create Controllers\Database\DataDictionaryController
- Extracts db_datadict.php logic to the controller
- Extracts HTML to database/data_dictionary/index template

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-03-01 23:06:13 -03:00
Maurício Meneghini Fauth
4c93203904 Rename DatabaseController and TableController
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-27 22:52:36 -03:00
Maurício Meneghini Fauth
067a6bfa0b Rename DatabaseStructureController to StructureController
Renames PhpMyAdmin\Controllers\Database\DatabaseStructureController to
PhpMyAdmin\Controllers\Database\StructureController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-13 21:58:47 -02:00
Hugues Peccatte
f06883d2a7 Remove useless parenthesis
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-20 01:23:53 +01:00
Maurício Meneghini Fauth
76fbe019da
Merge pull request #14856 from Tithugues/fix/escape-also-delimiter
Escape also delimiter
2019-01-16 02:19:24 -03:00
Hugues Peccatte
9406e922cc Update PHPDoc
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-13 09:52:46 +01:00
Hugues Peccatte
280926e3f3 Escape also delimiter
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 23:38:39 +01:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00