Maurício Meneghini Fauth
|
dd885dc7b8
|
Use single-line arrays when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2023-03-27 17:39:17 -03:00 |
|
Maurício Meneghini Fauth
|
437215cab2
|
Rename variables to use camel case format
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2023-03-26 21:47:50 -03:00 |
|
Maurício Meneghini Fauth
|
77957a69a5
|
Add trailing comma for multi-line functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2023-02-24 20:48:46 -03:00 |
|
Maurício Meneghini Fauth
|
785f8c1c00
|
Use constructor property promotion where possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2023-02-20 19:39:02 -03:00 |
|
Maurício Meneghini Fauth
|
613678f8f5
|
Replace assignments with null coalesce equal operator
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2023-02-20 17:03:05 -03:00 |
|
Maurício Meneghini Fauth
|
0fa4ebdc59
|
Fix coding standard issues and update SA baselines
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2023-02-20 12:50:47 -03:00 |
|
Evgeny Skorlov
|
673882b281
|
libraries/classes/Controllers/Database/ExportController.php
Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>
|
2023-02-20 12:29:09 -03:00 |
|
Kamil Tekiela
|
8a1d6f1eaa
|
Convert var annotations to typed properties
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
|
2023-02-12 21:31:04 +00:00 |
|
Kamil Tekiela
|
7a22334167
|
Designer controller globals (#17985)
* Remove globals from DesignerController
* Remove $GLOBALS['params'] in ManageController
* Remove $GLOBALS['params']
* Remove $GLOBALS['total_num_tables']
* Remove $GLOBALS['tooltip_truename']
* Remove $GLOBALS['tooltip_aliasname']
* Remove $GLOBALS['pos']
* Remove $GLOBALS['tables'] (partially)
* Remove $GLOBALS['num_tables'] (partially)
* Remove redundant calls to Util::getDbInfo()
* Move unrelated functionality out of getDbInfo()
* Extract new method getTableListPosition()
* Code style changes
* Update phpstan-baseline.neon
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
|
2023-01-26 22:58:24 -03:00 |
|
Maurício Meneghini Fauth
|
f103bdc1e2
|
Replace $_REQUEST with ServerRequest in Util::getDbInfo()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2022-11-08 00:06:25 -03:00 |
|
Maurício Meneghini Fauth
|
97aac39a40
|
Remove the sub_part global variable
It's only used inside Util::getDbInfo() for pagination when not
exporting.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2022-11-07 22:06:59 -03:00 |
|
Maurício Meneghini Fauth
|
3c618c22a9
|
Add ServerRequest parameter to all controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2022-07-28 01:00:08 -03:00 |
|
Maurício Meneghini Fauth
|
5950693fb3
|
Fix possible undefined globals
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2022-03-10 18:05:21 -03:00 |
|
Maurício Meneghini Fauth
|
f940693c75
|
Move Util::checkParameters method to the AbstractController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2022-03-07 22:59:33 -03:00 |
|
Maurício Meneghini Fauth
|
1438cb211e
|
Replace global keyword with $GLOBALS
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2022-03-07 17:31:11 -03:00 |
|
Maurício Meneghini Fauth
|
5a34a3bb04
|
Remove db and table properties from controllers
Replaces them with their respective globals.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2022-02-02 14:48:43 -03:00 |
|
Kamil Tekiela
|
253b08330d
|
Make $subPart non-nullable and remove redundant ?? when it's not null
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
|
2021-12-03 19:36:06 +00:00 |
|
Maurício Meneghini Fauth
|
f00d70cccb
|
Remove useless whitespaces
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-09-15 17:05:40 -03:00 |
|
Maurício Meneghini Fauth
|
3531775b7c
|
Add type declarations to the controllers contructors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-09-11 17:32:22 -03:00 |
|
Maurício Meneghini Fauth
|
96adfe37f4
|
Extract actions from controllers to new ctrls
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-09-06 18:30:21 -03:00 |
|
Maurício Meneghini Fauth
|
9adaa912e1
|
Rename Response class to ResponseRenderer
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-06-30 12:35:22 -03:00 |
|
Maurício Meneghini Fauth
|
1c084de30b
|
Fix coding standard errors
Related to 62f142c9fa.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-06-03 16:50:33 -03:00 |
|
Maurício Meneghini Fauth
|
44bdd1d390
|
Rename $url_params global to $urlParams
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-03-24 22:48:14 -03:00 |
|
Maurício Meneghini Fauth
|
91bd0df2e5
|
Rename $err_url global to $errorUrl
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-03-24 19:39:28 -03:00 |
|
William Desportes
|
993a6aa8a0
|
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
2021-03-23 01:13:58 +01:00 |
|
Saksham Gupta
|
04d72a8291
|
Fix #16703 No SQL option on Export of rows from a table
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Add null fallback
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Update yarn.lock
|
2021-03-22 22:34:06 +05:30 |
|
Maurício Meneghini Fauth
|
d83abf63e7
|
Use PSR-12 for control structures spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-03-05 15:27:03 -03:00 |
|
Maurício Meneghini Fauth
|
0b8edc5bde
|
Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-03-05 14:18:35 -03:00 |
|
Maurício Meneghini Fauth
|
c2bec44e23
|
Fix an error found by PHPStan
Cherry-pick: 89b09159d0
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-01-13 23:06:14 +01:00 |
|
Maurício Meneghini Fauth
|
89b09159d0
|
Fix an error found by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-01-06 16:59:04 -03:00 |
|
Maurício Meneghini Fauth
|
3c6955fed5
|
Move tables export to Database\ExportController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-12-06 14:08:36 -03:00 |
|
Maurício Meneghini Fauth
|
c11e8d5f64
|
Remove Common::database method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-11-02 18:56:58 -03:00 |
|
Maurício Meneghini Fauth
|
ef62d7a9f5
|
Remove is_system_schema PHP global variable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-11-02 18:48:23 -03:00 |
|
Maurício Meneghini Fauth
|
71c2f2d99a
|
Remove is_show_stats PHP global variable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-11-02 18:48:23 -03:00 |
|
Maurício Meneghini Fauth
|
e7bdd39ae6
|
Remove DBI dep from Database\AbstractController
Moves the DatabaseInterface class dependency to the classes that use it.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-10-12 10:46:27 -03:00 |
|
Maurício Meneghini Fauth
|
bb32ba6d9c
|
Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-10-04 12:31:43 -03:00 |
|
Maurício Meneghini Fauth
|
3c21cf1853
|
Remove url_query PHP global
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-09-08 13:32:25 -03:00 |
|
Maurício Meneghini Fauth
|
65b79af29e
|
Refactor Plugins::getPlugins method
Replaces parameters with explicit methods.
- Plugins::getExport
- Plugins::getImport
- Plugins::getSchema
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-08-19 01:40:27 -03:00 |
|
Maurício Meneghini Fauth
|
6cf316bde8
|
Use DI for Export\Options class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-08-04 15:43:06 -03:00 |
|
Maurício Meneghini Fauth
|
75397c913d
|
Refactor Display\Export class
- Uses template inheritance for the export templates.
- Renames Display\Export to Export\Options.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-08-03 23:56:20 -03:00 |
|
Maurício Meneghini Fauth
|
879ae32edc
|
Extract HTML from server, db and table export controllers
- Controllers\Server\ExportController::index
- Controllers\Database\ExportController::index
- Controllers\Table\ExportController::index
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-08-01 14:08:51 -03:00 |
|
Maurício Meneghini Fauth
|
1dccc10493
|
Extract method for adding script files
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-07-12 16:58:33 -03:00 |
|
Maurício Meneghini Fauth
|
f8320956ee
|
Remove Config\PageSettings::showGroup method
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-07-12 16:01:18 -03:00 |
|
Maurício Meneghini Fauth
|
3ae05c785d
|
Use short list syntax and single line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-05-26 03:32:59 -03:00 |
|
Maurício Meneghini Fauth
|
3baad2eb1c
|
Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-05-25 22:42:37 -03:00 |
|
Maurício Meneghini Fauth
|
a64393e7f5
|
Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-05-13 00:23:28 -03:00 |
|
Maurício Meneghini Fauth
|
4a0bce1d53
|
Extract db structure bulk actions from mult_submits
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-04-22 23:13:35 -03:00 |
|
Hugues Peccatte
|
b0460d3aa3
|
Fix #15995 database export
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
|
2020-04-15 20:56:40 +02:00 |
|
William Desportes
|
a7a7b73b55
|
Support return back from raw export
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
2020-01-27 21:16:37 +01:00 |
|
Saurabh Srivastava
|
1b56c8e0ed
|
Fix 15064 - instead of using free_query parameter, now updating export_type to raw -- more modular approach
Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
|
2020-01-27 21:16:31 +01:00 |
|