Commit Graph

330 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
b2a51c4d84
Create the RelationParameters value object
Replaces the $cfgRelation array with the RelationParameters value
object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-14 18:22:36 -03:00
Maurício Meneghini Fauth
a835d7cfcc
Remove array support from Util::backquote
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-10 19:33:09 -03:00
Daniel Tiringer
a8eaee326d
Extract Server/Privileges/getUserLink html to twig (#17156)
Extract HTML from libraries/classes/Server/Privileges.php's getUserLink function to Twig templates

Related to #14801

Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
2021-10-26 19:03:09 -03:00
Maurício Meneghini Fauth
3e0856c77b
Remove useless string concatenations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
9f3510d11a
Add bool return type where possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-14 20:11:51 -03:00
Maurício Meneghini Fauth
7f6472b2c2
Add void return type where possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-13 15:29:11 -03:00
Maurício Meneghini Fauth
f61d3183fb
Inline some phpcs ignores and remove deprecated annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-12 11:59:39 -03:00
Maurício Meneghini Fauth
38fda677bd
Extract Processes class from ProcessesController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-10 15:52:48 -03:00
Maurício Meneghini Fauth
5f4fd07483
Remove some assignments to the $_POST global
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-03 15:49:39 -03:00
Maurício Meneghini Fauth
8f2f3eff40
Remove the Core::isValid method
This improves the type checking and simplifies the code.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-02 13:20:50 -03:00
Maurício Meneghini Fauth
5725516656
Inline Core::ifSetOr method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-01 13:29:05 -03:00
Maurício Meneghini Fauth
f7fc4177af
Add support for account locking
- https://dev.mysql.com/doc/refman/en/account-locking.html
- https://mariadb.com/kb/en/account-locking/

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-21 00:55:33 -03:00
William Desportes
8aa4e30512
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-29 03:16:09 +02:00
William Desportes
4b9a9628f3
Merge #17045 - Fix #11834 - Fixing the issues regarding granting/showing priv from priv tab
Pull-request: #17045
Fixes: #11834

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-29 02:52:09 +02:00
Fawzi E. Abdulfattah
3f985e2124 Fixing the issues regarding granting and showing the privileges from the privileges tab
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
2021-07-28 17:26:01 +02:00
Fawzi E. Abdulfattah
84e9b611a6 fixing the links when granting privileges on tables or routines
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
2021-07-28 03:42:02 +02:00
William Desportes
c5a1dd2ec7
Merge #16925 - Replace Export privileges group dialog with a modal
Pull-request: #16925

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-27 03:26:32 +02:00
William Desportes
cbe4eae632
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-22 18:46:28 +02:00
William Desportes
b55029da74
Fix #16842 - Compare MySQL same as PerconaDB
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-22 17:49:08 +02:00
William Desportes
50913de8fe
Ref #16842 - Enable new password modes on PerconaDB
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-22 17:49:08 +02:00
William Desportes
ab2e5358f7
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-21 18:49:19 +02:00
Fawzi E. Abdulfattah
68981b78d7 Fixing all the issues related to assigning privileges
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
2021-07-17 02:49:07 +02:00
Maurício Meneghini Fauth
1835ebb4fc
Replace mb_strpos !== false with str_contains
See: https://wiki.php.net/rfc/str_contains#case-insensitivity_and_multibyte_strings

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-10 13:43:40 -03:00
Maurício Meneghini Fauth
6ae07c96fb
Replace strpos !== false with str_contains
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-09 22:30:42 -03:00
Maurício Meneghini Fauth
a0d91ec153
Move common.inc.php to classes/Common.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-06 14:00:44 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
21431578db
Fix some errors found by PHPStan and Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-24 18:03:14 -03:00
Maurício Meneghini Fauth
468c0498d1
Suppress current Psalm's ForbiddenCode errors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-19 16:49:03 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
Saksham Gupta
25005d30e8 Replace Export privileges group dialog with a modal
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add functionality for table and database

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add line

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Code fix

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Code fix 2

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Convert export priviliege user specific

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Cleanup reused code

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fix lint

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add parameter types

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Remove $ from $msgbox variable

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Comment fix

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Remove redundant functions

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Remove else condition

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fix race condition

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fix race condition

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2021-06-01 19:52:13 +05:30
Maurício Meneghini Fauth
9928882de3
Fix some errors found by Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-23 00:24:59 -03:00
Maurício Meneghini Fauth
cd1b8a9b77
Fix some errors found by PHPStan and Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-22 15:14:24 -03:00
Maurício Meneghini Fauth
6197f1a5c4
Merge branch 'QA_5_1'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-12 13:18:01 -03:00
Maurício Meneghini Fauth
0d382bb2a9
Remove leading slash from template names
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-12 13:05:47 -03:00
Daniel Tiringer
debb6af80f Move html from server/select to template
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>

Factor out logic from server listing

Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>

Create the base twig skeleton

Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>

Insert template and variables to form part

Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>

Insert list view template part

Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>

Insert just options fork

Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>

Factor out repeating code into server_options template

Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>

Render the template

Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>

Comment out test parts that don't work due to translate

Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>

Fix the typos in the translatable elements

Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>

Refactor the test into separate scenarios

Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>

Remove indentation spaces

Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>

Codesniffer cleanup

Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>

Add test for fieldset existence

Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>

Code style fixes

Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>

Reorder lines in test

Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>

Replace include function with tag

Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>

Removing the escape calls

Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
2021-05-05 16:17:20 +02:00
William Desportes
d005ea8041
Remove some else conditions by using early exits or moving code
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-29 01:30:25 +02:00
William Desportes
c51af5a003
Fix phpstan reported errors
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-28 23:48:27 +02:00
William Desportes
9487604a42
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-28 02:12:17 +02:00
William Desportes
c21738dbf0
Documentation updates
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-28 02:04:48 +02:00
Maurício Meneghini Fauth
5750dfb1bb
Extract method to get edit user group modal form
Creates a new route: /server/user-groups/edit-form

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-26 22:59:09 -03:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-20 22:35:21 -03:00
William Desportes
41e0d4dfb7
Use the Query\Compatibility class to simply and remove duplicate checks
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-20 20:57:10 +02:00
William Desportes
e46cbf6519
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-20 20:19:08 +02:00
David Sinquin
86f239ca44
Fix password management for Percona Server.
Simply stick to what is done for Oracle MySQL.

Signed-off-by: David Sinquin <david.sinquin@gandi.net>
2021-04-20 18:34:17 +02:00
William Desportes
8fbb01a684
Merge branch 'origin/QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-19 21:51:45 +02:00
Maurício Meneghini Fauth
59e4dae52a
Remove invalid inline doc comments
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-18 14:49:28 -03:00
Saksham Gupta
9a9b7ad335 Fix #16404 Password generation fix after new user creation failure
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Check error on SQL query

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Lint fix

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add comments

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2021-04-15 20:34:35 +05:30
Maurício Meneghini Fauth
4273634c17
Extract getActiveAuthPlugins method to Plugins class
Extracts the getActiveAuthPlugins method from the
PhpMyAdmin\Server\Privileges class to the PhpMyAdmin\Server\Plugins
class, rename it to getAuthentication and adds tests.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-14 16:07:40 -03:00
Maurício Meneghini Fauth
14532f2f07
Rename variables to use camelCase in Server\Privileges
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-25 14:03:26 -03:00