Commit Graph

183 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
0d81b2166a
Add test for Sql::executeQueryAndSendQueryResponse
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-15 19:51:16 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
9f3510d11a
Add bool return type where possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-14 20:11:51 -03:00
Maurício Meneghini Fauth
7f6472b2c2
Add void return type where possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-13 15:29:11 -03:00
Maurício Meneghini Fauth
6ae07c96fb
Replace strpos !== false with str_contains
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-09 22:30:42 -03:00
William Desportes
4f74043e1a
Merge branch 'origin/QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-08 15:39:08 +02:00
William Desportes
65d262c170
Fix #17001 - adjust function signatures and handle no table name case
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-08 14:52:18 +02:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
21431578db
Fix some errors found by PHPStan and Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-24 18:03:14 -03:00
William Desportes
0a1f083990
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-23 20:36:21 +02:00
William Desportes
897f07d50d
Implement error management for #16977
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-23 13:18:40 +02:00
Maurício Meneghini Fauth
8f992a4fbf
Fix some errors found by PHPStan and Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-15 18:49:37 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
William Desportes
3706c1fcd1
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-05-29 21:30:42 +02:00
Maurício Meneghini Fauth
cd1b8a9b77
Fix some errors found by PHPStan and Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-22 15:14:24 -03:00
Maurício Meneghini Fauth
5faf95016f
Use DatabaseName VO for db names in Table\Partition
- Adds DatabaseName support for DatabaseInterface::selectDb method

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-21 21:30:37 -03:00
William Desportes
6c81fa2879
Fix #16734 - SQL group by count results are not accurate
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-05-14 14:46:41 +02:00
William Desportes
d20f7f7d0a
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-24 19:01:26 +02:00
William Desportes
64331802cb
Fix #16734 - Use SQL count instead of fetch and count results
Ref: #15652

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-24 18:29:53 +02:00
Maurício Meneghini Fauth
44bdd1d390
Rename $url_params global to $urlParams
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-24 22:48:14 -03:00
Maurício Meneghini Fauth
caa3337411
Extract FK related methods from Util class
Creates the PhpMyAdmin\Utils\ForeignKey class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-21 15:25:45 -03:00
Maurício Meneghini Fauth
d3ce67593d
Fix some errors found by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-09 17:22:03 -03:00
Maurício Meneghini Fauth
33d711215d
Remove the PMA_VERSION constant
Uses the PhpMyAdmin\Version::VERSION constant instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 22:22:55 -03:00
Maurício Meneghini Fauth
1a9ecb6d76
Rename variables to use camel case format
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-07 13:03:12 -03:00
William Desportes
7bd3ec6b35
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-06 21:25:54 +01:00
William Desportes
4d78b3e6f9
Desactivate session functions for test suite in Sql.php
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-06 19:11:48 +01:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
William Desportes
c5155ecae9
Refactor field flags to use an object an not strpos
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-24 23:56:33 +01:00
Maurício Meneghini Fauth
1e5fbd57fc
Create Twig\AssetExtension and image Twig function
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-28 16:09:17 -03:00
Maurício Meneghini Fauth
cb842fd079
Fix some errors found by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-14 14:44:05 -03:00
Saksham Gupta
6cdb3779d2
Fix #15652 - Remove deprecated FOUND_ROWS()
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2020-11-12 12:49:46 +01:00
Maurício Meneghini Fauth
bb32ba6d9c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-04 12:31:43 -03:00
William Desportes
aecdfc80cb
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-10-04 00:29:04 +02:00
Petr Duda
661af18061 Fix #16377 Uncaught ReferenceError: Stickyfill is not defined
Signed-off-by: Petr Duda <petrduda@seznam.cz>
2020-10-01 21:39:49 +02:00
Maurício Meneghini Fauth
3c21cf1853 Remove url_query PHP global
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-08 13:32:25 -03:00
Maurício Meneghini Fauth
c57dda7315 Use DI for Sql class constructor
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-05 15:31:39 -03:00
Maurício Meneghini Fauth
992af332a0 Extract Sql::parseAndAnalyze method to SqlTest class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-05 13:58:51 -03:00
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
7936909dbd Move Operations::getMaintenanceActions to the view
Uses Table\MaintenanceController to handle the maintenance actions in
the table operations page.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-28 15:25:14 -03:00
Maurício Meneghini Fauth
c112bfd6d6 Create a new page for Check Table
Instead of only showing the query results.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-27 14:22:22 -03:00
Maurício Meneghini Fauth
03d8314bba Create the PhpMyAdmin\Profiling class
Extracts Profiling related methods to the Profiling class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-26 16:02:30 -03:00
Maurício Meneghini Fauth
3e71690a0b Extract profiling methods from Sql::executeTheQuery
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-25 22:00:55 -03:00
Maurício Meneghini Fauth
622241c15f Fix profiling table not incrementing calls
Fixes #16318

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-25 20:54:45 -03:00
Maurício Meneghini Fauth
e7e9bd770f Remove the Sql::getHtmlForProfilingChart method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-25 20:31:15 -03:00
Maurício Meneghini Fauth
99abf3ab3c Remove the Sql::getHtmlForSetColumn method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-24 22:59:17 -03:00
Maurício Meneghini Fauth
dd8eb261f8 Remove the Sql::getHtmlForBookmark method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-24 20:47:33 -03:00
Maurício Meneghini Fauth
3a5ad0a011 Extract HTML from query results operations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-21 20:53:09 -03:00
Maurício Meneghini Fauth
f6215b6f7a Extract HTML from Sql::getQueryResponseForNoResultsReturned
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-20 17:27:09 -03:00
William Desportes
e97d82061d
Coding standard fixes after #14340
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-22 17:52:51 +02:00