Commit Graph

152 Commits

Author SHA1 Message Date
William Desportes
a2268169ae
Use strict compare for count function
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:44:49 +02:00
William Desportes
64c1b26bac
Use strict compare for booleans
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:41:54 +02:00
William Desportes
6cc352ac12
phpstan level 3 fixes
21 errors left

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:37:38 +02:00
William Desportes
418b50dd4e
Merge branch 'QA_4_9'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:28:19 +02:00
William Desportes
aab50ab37a
Replace $_REQUEST by $_GET and $_POST for GIS visualisation
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:16:42 +02:00
William Desportes
bbac072fb5
Fix #15334 - export of GIS visualisation not working
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:14:52 +02:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
c8f84fc748 Replace is_null with identical comparison with null
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 13:28:22 -03:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00
Maurício Meneghini Fauth
efe77cdf06 Rename js/tbl_*.js to js/table/*.js
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-07 04:09:05 -03:00
Hugues Peccatte
9abd308837 Inject dependencies (#15271)
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-01 15:13:41 -03:00
William Desportes
de4bc0751b
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-19 20:20:57 +02:00
William Desportes
d0cb22a819
Fix #13854 - Column options are ignored for GENERATED/VIRTUAL/STORED columns
Fixes: #13854
Pull-request: #15278
Pull-request: #15275
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-19 20:10:57 +02:00
Maurício Meneghini Fauth
1a846baa0f
Merge pull request #15266 from Tithugues/feature/DI
External dependency injection system
2019-05-19 11:55:56 -03:00
Michael Voříšek
b09bd204c9 Fix generate field SQL for MySQL virtual columns
Fix issue #13854, based on official syntax:
column_definition: https://dev.mysql.com/doc/refman/5.7/en/create-table.html

Signed-Off-By: Michael Voříšek <mvorisek@mvorisek.cz>
2019-05-19 14:10:52 +02:00
Hugues Peccatte
380707fbcd Define controllers as services in an external configuration file
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-19 01:54:44 +02:00
William Desportes
ae39ea5cbd
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-19 01:14:00 +02:00
William Desportes
35fcea7df6
Fix #14621 - add "Propose table structure" on MariaDB
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-19 00:33:11 +02:00
Maurício Meneghini Fauth
4e5bd7cb85 Remove $sql_query global from PHPStan ignore list
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-16 19:17:58 -03:00
Hugues Peccatte
ff3325870f Remove unused variables
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-14 21:59:57 +02:00
Hugues Peccatte
91e9acb263 Update PHPDoc
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-14 21:59:57 +02:00
Maurício Meneghini Fauth
620afff0ea
Merge pull request #15256 from Tithugues/feature/replace-regexp-by-replace
Replace regexp by str_replace when possible
2019-05-08 14:18:06 -03:00
Hugues Peccatte
d28894d9ba Change "tbl_partition_definition.inc.php" file as a class
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-07 23:29:30 +02:00
Hugues Peccatte
fc1ffb1413 Replace regexp by str_replace when possible
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-07 23:26:01 +02:00
Nitish Bahl
8d875747c7 added optimize for innodb engine
Signed-off-by: Nitish Bahl <nitishbahl24@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-04 14:49:07 -03:00
William Desportes
fbd89fb882
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-01 17:53:24 +02:00
William Desportes
c745aab360
Fix php notice Undefined index: mysqlVersion
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-16 13:21:30 +02:00
William Desportes
3399e5babd
Fix spatial functions
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-16 11:11:28 +02:00
William Desportes
9ed068aacb
Fix #14383 #12865 - Fix GIS functions for mysql 8.0
Fixes: #14383
Fixes: #12865
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-16 11:11:28 +02:00
William Desportes
1e403f76d9
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-01 23:28:40 +02:00
William Desportes
ab748e2fac
Fix some potential php notices after merge of #15040
[ci skip]
See: 3d3d1a2b08
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-01 23:27:15 +02:00
William Desportes
76dca69460
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-01 22:29:25 +02:00
William Desportes
292d2db727
Merge branch 'QA_4_8' 2019-04-01 20:46:54 +02:00
apoorv
bca847f227 Fix #15010 - Sql preview show empty modal
Signed-off-by: apoorv <apoorvkhare007@gmail.com>
2019-03-26 23:48:58 +01:00
William Desportes
0988f9cf1b
Fix style issues
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-26 19:28:02 +01:00
William Desportes
79840be362
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-25 23:21:35 +01:00
Nitish Bahl
2b0a36eb21 Fix #14926 - Filling existing fields form while editing a view
Fix: #14926
See: #14916
Signed-off-by: Nitish Bahl <nitishbahl24@gmail.com>
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-25 22:31:29 +01:00
Maurício Meneghini Fauth
4d9da96469 Create server, database and table SqlControllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-23 22:41:29 -03:00
Maurício Meneghini Fauth
525a436162 Fix some PHPStan errors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-19 16:48:54 -03:00
Maurício Meneghini Fauth
e575d4a739 Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-19 14:38:16 -03:00
Maurício Meneghini Fauth
75eb905727 Fix wrong property name on TableStructureController
Introduced by 963ace6ada

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-19 14:31:10 -03:00
Maurício Meneghini Fauth
c9371d3a91 Rename Controller to AbstractController
Rename PhpMyAdmin\Controllers\Controller to
PhpMyAdmin\Controllers\AbstractController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-11 15:57:14 -03:00
Maurício Meneghini Fauth
5ea75f4144 Rename Table\Controller to Table\AbstractController
Rename PhpMyAdmin\Controllers\Table\Controller to
PhpMyAdmin\Controllers\Table\AbstractController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-11 15:15:31 -03:00
Maurício Meneghini Fauth
50ec2c0e2b Create Controllers\Database\CentralColumnsController
Moves db_central_columns.php logic to the controller

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-03-05 02:12:12 -03:00
Maurício Meneghini Fauth
4c93203904 Rename DatabaseController and TableController
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-27 22:52:36 -03:00
Maurício Meneghini Fauth
b97460a320 Rename TableStructureController to StructureController
Renames PhpMyAdmin\Controllers\Table\TableStructureController to
PhpMyAdmin\Controllers\Table\StructureController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-14 16:30:49 -02:00
Maurício Meneghini Fauth
505af51a1c Rename TableSearchController to SearchController
Renames PhpMyAdmin\Controllers\Table\TableSearchController to
PhpMyAdmin\Controllers\Table\SearchController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-14 16:08:18 -02:00
Maurício Meneghini Fauth
6c29e58ef7 Rename TableRelationController to RelationController
Renames PhpMyAdmin\Controllers\Table\TableRelationController to
PhpMyAdmin\Controllers\Table\RelationController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-14 15:43:07 -02:00
Maurício Meneghini Fauth
a440e52541 Rename TableIndexesController to IndexesController
Renames PhpMyAdmin\Controllers\Table\TableIndexesController to
PhpMyAdmin\Controllers\Table\IndexesController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-14 14:45:57 -02:00
Maurício Meneghini Fauth
cb8060ef4b Rename TableGisVisualizationController to GisVisualizationController
Renames PhpMyAdmin\Controllers\Table\TableGisVisualizationController to
PhpMyAdmin\Controllers\Table\GisVisualizationController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-14 14:04:10 -02:00