Commit Graph

764 Commits

Author SHA1 Message Date
Marc Delisle
f9a0e1e8e9 Unused code or parameter
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-29 12:39:36 -04:00
Hugues Peccatte
d5b53ae9b8 Fix unit test.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-05-25 12:21:20 +02:00
Marc Delisle
9373e1b204 Fix merge conflict
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-23 10:21:37 -04:00
Ann + J.M
5ddd0c1990 Code style fixes
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-05-21 20:56:01 +02:00
Chirayu Chiripal
85390a7169 rfe-982: Support for editing binary fields in hexadecimal
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-05-21 21:42:21 +05:30
Marc Delisle
49f1bdd822 Merge commit '0ee881d' 2014-05-16 12:20:52 -04:00
Marc Delisle
0ee881da71 bug #4395 BLOB link transformation is broken
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-16 09:56:47 -04:00
Michal Čihař
329deddbfd Let's have just one PMA_mimeDefaultFunction
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-10 14:53:49 +02:00
Michal Čihař
71c0eba99f Add test for NavigationTree::renderPath
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-10 12:48:16 +02:00
Madhura Jayaratne
d0fd5acc0f Revert 33a30ad7ae. Those funcitons are infact used.
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-05-10 12:04:36 +02:00
Madhura Jayaratne
33a30ad7ae These functions do not seem to be used anywhere, removing...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-05-10 11:51:03 +02:00
Michal Čihař
72d180afd8 Add basic test for navigation tree
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-10 11:23:33 +02:00
Michal Čihař
725073709c Use token directly for session
There is no need to have intermediate global variable to store the token
once we have it in the session data.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-10 11:23:33 +02:00
Michal Čihař
3eccb9eb26 Improve signon-script example
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 18:07:39 +02:00
Michal Čihař
b1915bade0 The storeResult needs mysqli lin parameter to operate
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 16:29:56 +02:00
Michal Čihař
8bc5e560e8 Uset errno before testing
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 16:19:59 +02:00
Michal Čihař
2a66d750a4 Use correct mock value
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 16:11:30 +02:00
Michal Čihař
0f39a811ce The DBI->getError is no longer called twice
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 16:03:00 +02:00
Michal Čihař
514e1c6356 Include missing parameter
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 14:08:58 +02:00
Michal Čihař
1f669982f8 Adjust test to new API
Also mark as incomplete tests which really did not test anything.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 12:46:22 +02:00
Michal Čihař
1590e23868 We no longer need to mock the dbi object
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 11:56:45 +02:00
Michal Čihař
302bda9961 Fix typo in method name
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 11:27:55 +02:00
Michal Čihař
4631131cbc We default to TCP connection, so I believe this is correct value here
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 10:33:02 +02:00
Michal Čihař
6e6c513eed Fix typo in type name
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 18:04:07 +02:00
Michal Čihař
7996bd1c21 Move hex encoding back to getContent method
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 15:17:55 +02:00
Michal Čihař
708d058b63 Fix text expectations
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 14:46:47 +02:00
Michal Čihař
9f5d592ff3 Add method for getting transoformations options
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-06 15:35:58 +02:00
Michal Čihař
a679b8c476 Adjust expectations
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-06 14:32:56 +02:00
Hugues Peccatte
9870cb5142 Update DB group queries format.
Update DB group test.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-04-23 21:30:12 +02:00
Hugues Peccatte
ebc2739c89 Update documentation.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-04-22 21:36:26 +02:00
Marc Delisle
507fa83e7f Merge branch 'QA_4_1' 2014-04-07 13:09:32 -04:00
Marc Delisle
81ed4c9c83 bug #4355 Precision specifier for DOUBLE type is truncated
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-04-07 13:08:41 -04:00
Chanaka Indrajith
70c3ad7c27 Remove unneccessary tests
Signed-off-by: Chanaka Indrajith <pe.chanaka.ck@gmail.com>
2014-04-05 23:20:50 +05:30
Michal Čihař
7233657d4d Remove support for SQL validator
The SOAP service seems to be down for quite some time and it is not
mentioned anywhere on Mimer website.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-04-02 12:10:52 +02:00
Michal Čihař
c6cc2f70b1 Merge branch 'QA_4_1' 2014-04-02 09:15:25 +02:00
Michal Čihař
b80e73979b Fixed PHP Parse error in Advisor
There is one rule which needs to pass more values to format string and
the code did not properly handle this. Now evaluating params and passing
them to vsprintf to process the format string.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-04-02 09:14:15 +02:00
Michal Čihař
58fcc7bb32 Add test for double format values
bug #4347

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-04-02 09:09:19 +02:00
Michal Čihař
a40ce0eda7 Support AES_DECRYPT as well
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-25 13:59:29 +01:00
Michal Čihař
8dd5df2a7f Merge pull request #1077 from ganeshaditya1/multicolumn
Multicolumn sorting feature request(1507)
2014-03-24 15:21:54 +01:00
Aditya Sastry
a05ab9640b Multicolumn sorting feature request(1507)
This patch completely implements the feature requested and it modifies 4
existing files and adds one extra Javascript file. The existing system for
one column sorting has been refactored to be used for multicolumn sort.

Files messages.php and makegrid.js where modified to add the tool tip.

File sql.php was modified to add the import statement for the newly added JS
file.

The newly added columndelete.js is responsible for shift deleting the columns.
It gets the url of the link that was shift clicked and removes the name of the
column which we want to remove from the order by clause.

Finally, most of the crux of this feature request is implemented through
changes to the DisplayResult.class.php. 4 methods of this class have been
refactored to accomodate the required change. getsortparams() which process
the order by clause text remains the same, just the output parameters have
been turned into a array for each order by clause column. isInSort() has been
modified to check multiple order by clauses. The smart ordering feature in
to form a new function makeURL, which makes the url for multiple sorted table's
header's button's targets.

Signed-off-by: Aditya Sastry <ganeshaditya1@gmail.com>
2014-03-24 02:17:54 +05:30
Michal Čihař
d559fa6a21 Remove trailing whitespace from the code
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-20 09:36:48 +01:00
Michal Čihař
3ba249176a Remove incomplete @covers annotations
PHPUnit now uses these to list code which is covered and was not listed
in @covers, what produces quite a lot of errors. I don't think we really
need to explicitely list those directives.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-19 16:04:20 +01:00
Hugues Peccatte
cbc966c03d PHPCS updates.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-03-15 12:29:31 +01:00
Michal Čihař
40f9df6fcc Merge pull request #1067 from jeffchan/fix-tests
Fix unit test running individually by file
2014-03-15 08:26:49 +01:00
Hugues Peccatte
9b1f025fb7 PHPCS updates.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-03-14 23:06:46 +01:00
Jeff Chan
3e65f88dee Fix AuthenticationCookieTest::testAuth to have proper includes
Also change testAuthSetUserWithHeaders to have more flexible assertion

Signed-off-by: Jeff Chan <jefftchan@gmail.com>
2014-03-14 19:28:17 +00:00
Jeff Chan
719babd2c6 Import dependencies to make tests friendlier to running independently
The HHVM test runner runs the unit tests in parallel. Currently some tests
fail because not all the dependencies are properly included.

Signed-off-by: Jeff Chan <jefftchan@gmail.com>
2014-03-14 18:59:18 +00:00
Jeff Chan
69e2f227ab Move slow tests in HHVM to medium group
Signed-off-by: Jeff Chan <jefftchan@gmail.com>
2014-03-14 18:59:13 +00:00
Jeff Chan
581f8e4d94 Define MYSQL_VERSION string constant if not already defined
These tests were failing when run individually since the constant was
not defined. This patch defines the constant if it doesn't exist.

Signed-off-by: Jeff Chan <jefftchan@gmail.com>
2014-03-14 18:59:07 +00:00
Michal Čihař
3d0f237031 Fix expected message to match code
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-14 13:05:48 +01:00