Commit Graph

48 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
09e8144e97
Refactor Util::formatNumber()
Trim whitespace and add more unit prefixes.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-07-24 10:41:36 -03:00
Maurício Meneghini Fauth
86d9028a8d
Add more unit tests for Util::formatNumber()
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-07-22 12:10:40 -03:00
Maurício Meneghini Fauth
9c576fcc9c
Refactor Twig extensions to use Twig's AttributeExtension
This allows to remove most extensions.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-07-08 13:23:34 -03:00
Maurício Meneghini Fauth
e7765efd63
Make some comparisons stricter
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-07-06 15:44:31 -03:00
Kamil Tekiela
0797f9c44b Rector: small improvements
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-06-11 14:43:20 +01:00
Kamil Tekiela
0e5b3968b2 Synchronize routines UX
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-04-18 13:22:01 +01:00
Kamil Tekiela
59d1f8331d Drop Util::processIndexData
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-02-06 00:36:48 +00:00
Kamil Tekiela
2484cba839 Create unquoteDefaultValue()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-29 14:46:53 +00:00
Kamil Tekiela
1af9a6ca13 Create Util::getUploadSizeInBytes()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:12:24 +00:00
Kamil Tekiela
b96a86dc3a Add return type hint to extractColumnSpec
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-16 22:23:35 +00:00
Kamil Tekiela
b62ffe17c7 Merge the logic into Settings
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-16 19:31:50 +00:00
Kamil Tekiela
287ad9c8ec Use match statements
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-16 16:42:12 +00:00
Kamil Tekiela
44e7e5ab34 Remove old values that are handled in Settings
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-16 16:26:07 +00:00
Liviu-Mihail Concioiu
0fa9721ed4 Replace selected="selected" with selected
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2025-01-12 03:11:39 +01:00
Kamil Tekiela
8015e4de72 Move DatabaseInterface to Dbal
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 18:34:53 +00:00
William Desportes
57a56f1aa7
Merge branch 'QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2024-12-18 03:00:58 +01:00
Maurício Meneghini Fauth
dc1bd60dd1
Fix boolean usage of the return value of preg_match()
preg_match() and preg_match_all() returns the number of pattern matches
(which might be zero), or false on failure. However, preg_match() always
returns 1 when a pattern is matched as it stops searching after the
first match.

- https://www.php.net/manual/en/function.preg-match.php
- https://www.php.net/manual/en/function.preg-match-all.php

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-07-13 14:43:05 -03:00
Maurício Meneghini Fauth
12e1bf6425
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-07-13 13:19:30 -03:00
Maurício Meneghini Fauth
dbda4cf483
Change Util::localisedDate() to use DateTimeImmutable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-06-12 17:01:35 -03:00
Maurício Meneghini Fauth
1db76c69f1
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-06-03 22:04:18 -03:00
Kamil Tekiela
54b5464ec2 Replace function casts with normal casts
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-03 15:07:57 +01:00
Maurício Meneghini Fauth
a82c7fcb6f
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-03 00:46:10 -03:00
Kamil Tekiela
8e4443b17b
Applying suggestions from static analysis tools (#19013)
* Drop array keys from lists

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Import UrlTest

When it doesn't exist in Prod, the code will still work the same.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Drop redundant return [];

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix object access checks

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use strict comparison

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Int keys should be specified as integers

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use empty string check instead of strlen

Potential null deprecations are replaced with loose condition.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use stripos instead of *substr

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify substr's 3rd param

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary defaults

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace isZeroBasedArray with array_is_list

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify texEscape()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify exportZeroBasedArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for loop with array_diff

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for with foreach

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove nullable param in backquoteCompat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-coalescing operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Inline $result variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Turn $event into a constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Move selectDb outside the loop

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix code style order of operation

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary isset argument

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove line break

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use foreach instead of for

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-02-27 12:29:02 -03:00
Kamil Tekiela
ef34bd1289 Refactor getMenuTabList()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-01-31 15:49:26 +01:00
Kamil Tekiela
fce0249841 Revert removed line of code
This reverts commit 7dc661c96c. This code is important for performance. I have misread this line of code at the time which caused performance issues.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-01-13 00:11:54 +01:00
Kamil Tekiela
822ebbfe59 Remove unnecessary parentheses
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-01-12 15:26:31 +01:00
Kamil Tekiela
f150ed40a9 Update PHPDoc comments
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-01-12 14:57:46 +01:00
Kamil Tekiela
bccbda7249 Small code quality fixes
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-01-12 14:57:46 +01:00
Kamil Tekiela
5ce27be6ac Replace mb_substr
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-01-12 03:01:17 +01:00
Kamil Tekiela
7dc661c96c Remove $tables variable
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-21 15:33:22 +01:00
Kamil Tekiela
c2179c9482 Use count outside of getDbInfo()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 23:57:09 +01:00
Kamil Tekiela
26bb95f4fd Refactor getTablesWhenOpen
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 23:56:44 +01:00
Kamil Tekiela
bb68c5f87c Privatize method
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 23:56:44 +01:00
Kamil Tekiela
2501d77bd3 Use first-class function for strnatcasecmp
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-19 21:43:41 +01:00
Kamil Tekiela
982b5bb4d0 Simplify Util::getValueByKey()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-17 22:16:45 +01:00
Maurício Meneghini Fauth
ef6c30c865
Replace table global var with static class property
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-17 15:51:29 -03:00
Maurício Meneghini Fauth
711f6c0f14
Replace db global variable with static class property
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-17 14:58:59 -03:00
Maurício Meneghini Fauth
93c45f9657
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-08 17:58:23 -03:00
Kamil Tekiela
4fb335e960 Make in_array strict
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-07 17:11:48 +01:00
Kamil Tekiela
9d18c3d5e6 Fix type hint for getSupportedDatatypes()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

uyi
2023-12-07 02:15:44 +01:00
Kamil Tekiela
1995c4f312 Revert commit 0e344b6
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-07 02:15:44 +01:00
Kamil Tekiela
d769f77891 Remove useless getValueByKey()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-04 15:12:46 +01:00
Kamil Tekiela
2e81a808f7 Create UniqueCondition class
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-10-21 21:18:48 +01:00
Kamil Tekiela
b230b1ae31 Remove 1st param in getUniqueCondition()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-10-21 19:56:08 +01:00
Maurício Meneghini Fauth
dd5f087aa5
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-10-03 17:31:12 -03:00
Maurício Meneghini Fauth
1ae995b9f1
Refactor the Core::getenv() method
Renames it to getEnv() and adds unit tests for it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-09-28 16:09:46 -03:00
Kamil Tekiela
8c260bc654 Refactor expandUserString()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-09-02 16:15:58 +01:00
Maurício Meneghini Fauth
c2955cc2b2
Rename the directory libraries/classes/ to src/
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-30 15:59:28 -03:00