Commit Graph

455 Commits

Author SHA1 Message Date
William Desportes
6ecf6ec93e
Fixed most of deprecated Jquery calls
\.(blur|focus|focusin|focusout|resize|scroll|click|dblclick|mousedown|mouseup|mousemove|mouseover|mouseout|mouseenter|mouseleave|change|select|submit|keydown|keypress|keyup|contextmenu)\(\)

Ref:  #13173

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-24 21:54:23 +02:00
Maurício Meneghini Fauth
3b50a194e7 Remove unused variables in JavaScript files
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-06 22:31:33 -03:00
Maurício Meneghini Fauth
c8dd8660a0 Replace jQuery .bind() with .on()
As of jQuery 3.0, .bind() has been deprecated.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-31 14:46:23 -03:00
Maurício Meneghini Fauth
db3a59b6f1 Fix undefined variables in some JavaScript files
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-30 23:14:25 -03:00
Maurício Meneghini Fauth
6ed803588a Fix ESLint warnings in js/ajax.js
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-30 02:00:51 -03:00
Maurício Meneghini Fauth
7ee9ae2608 Rename js/microhistory.js variables to use camel case
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-29 16:35:44 -03:00
Maurício Meneghini Fauth
806b0ce582 Rename js/sql.js variables to use camel case
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-29 15:08:17 -03:00
Maurício Meneghini Fauth
1ca7fb31e4 Add Sql module to js/sql.js
To reduce the number of global variables

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-28 17:52:43 -03:00
Maurício Meneghini Fauth
5390a80b12 Add Navigation module to js/navigation.js
To reduce the number of global variables

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-27 20:43:19 -03:00
Maurício Meneghini Fauth
23463d0161 Rename js/makegrid.js variables to use camel case
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-27 01:36:06 -03:00
Maurício Meneghini Fauth
0b3014207d Use camel case for most of the js/functions.js variables
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-27 00:55:10 -03:00
Maurício Meneghini Fauth
d99991f43f Rename PMA_confirm and PMA_sort_table jQuery functions
Renames to confirm and sortTable.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-26 20:59:59 -03:00
Maurício Meneghini Fauth
70d2295f58 Remove unnecessary escape usage
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-24 22:31:15 -03:00
Maurício Meneghini Fauth
923e3fb050 Replace Array constructors with literal notation
Use of the Array constructor to construct a new array
is generally discouraged in favor of array literal
notation because of the single-argument pitfall and
because the Array global may be redefined. The exception
is when the Array constructor is used to intentionally
create sparse arrays of a specified size by giving
the constructor a single numeric argument.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-24 21:53:11 -03:00
Maurício Meneghini Fauth
ce71901de5 Refactor js/functions.js to use a module
Adds Functions module in js/functions.js to reduce the number of global variables.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-22 17:44:21 -03:00
Maurício Meneghini Fauth
562b5a48f0 Remove PMA_ from PMA_commonParams and PMA_commonActions names
PMA_commonParams => CommonParams
PMA_commonActions => CommonActions

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-21 00:18:44 -03:00
Maurício Meneghini Fauth
ea2d5a0d87 Rename PMA_messages JS global variable to Messages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-20 23:58:23 -03:00
William Desportes
b6b9926a08
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-01 16:27:24 +02:00
Nupur Agrawal
4902d080e7
Fix #12729 - Sticky table header over dropdown menu
Fixes: #12729
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
2019-04-01 16:18:04 +02:00
William Desportes
c793b998a7
ESLINT fixes
Make eslint green for CI
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-30 08:30:48 +01:00
William Desportes
c112ba4da8
Merge branch 'QA_4_8'
Closes: https://github.com/phpmyadmin/phpmyadmin/pull/14876
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-02 12:07:40 +01:00
nmilo
68d81fa210 Fix: #14503 - JavaScript events not activating on input
Fixes: #14503
Signed-off-by: nmilo <nemanjamilosevic29@yahoo.com>
2019-03-02 11:47:34 +01:00
Hugues Peccatte
e175464301 Syntax error in JQuery selector
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 01:36:48 +01:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 21:04:19 -02:00
Lakshay arora
2b065133a2 Adds features discussed in #13023
1. Show ajax errors at the bottom of the page, instead of showing them in a popup.
2. Add copy query button for errors in processing sql queries.

Signed-off-by: Lakshay arora <arora.lakshya123@gmail.com>
2018-11-14 23:20:12 -02:00
Maurício Meneghini Fauth
e7e7d56c75 Retrieve parameters from $_POST in browse foreigners
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Bob Terrell
0861e05531 Fix several issues with table headers in Safari
The width += 1 does not apply to Safari, either.

Safari requires min-width and max-width to be set. “width” is not honored.

Add a line break to template so comments stay on separate line.

Moved browser checks to higher scope; the user agent only needs to be checked once, not once per cell.

Signed-off-by: Bob Terrell <bob.terrell@acordex.com>
2018-08-23 14:59:57 -04:00
Lakshay arora
f05bce1e94 Some minor bug fixes
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
2018-07-12 12:53:13 +05:30
Piyush Vijay
bf0198938c Remember table's sorting broken in 4.8.0 issue: #14189 fixed
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

(cherry picked from commit e58dd74c40)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-12 04:53:08 -03:00
Maurício Meneghini Fauth
1f76f859fb
Merge pull request #14204 from Piyush3079/PMA_14189
Remember table's sorting broken in 4.8.0 issue: #14189 fixed
2018-05-12 04:51:29 -03:00
Maurício Meneghini Fauth
2936492555 Revert "Replace .focus() with .on()"
This reverts commit d18076eb96.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-12 02:40:33 -03:00
Maurício Meneghini Fauth
d18076eb96 Replace .focus() with .on()
.focus() event shorthand is deprecated

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-12 02:17:51 -03:00
Maurício Meneghini Fauth
3bf83954a0 Replace .keyup() with .on()
.keyup() event shorthand is deprecated

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-12 01:28:32 -03:00
Maurício Meneghini Fauth
8f8e3c26c9 Replace .click() with .on()
.click() event shorthand is deprecated

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-11 23:58:35 -03:00
Maurício Meneghini Fauth
f4fedc20ee Replace .change() with .on()
.change() event shorthand is deprecated

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-11 20:45:36 -03:00
Piyush Vijay
9c7c5ca951 Changes to make Get auto saved query and show this query here again button functional (#14166)
* Handling of autosaved query and making get auto-saved query button functional
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* Basic functionality of show this query here again added
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* Show this query here again checkbox working properly
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* deleting auto_saved_sql on clicking submit query button
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* javascript error handled
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* javascript error of JSON undefined removed
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-03 16:50:38 -03:00
Piyush Vijay
e58dd74c40
Remember table's sorting broken in 4.8.0 issue: #14189 fixed
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
2018-04-16 19:33:28 +05:30
Maurício Meneghini Fauth
bec8888e7c Revert "Merge pull request #14046 from shucon/login"
This reverts commit 5a1ceef67d, reversing
changes made to 063f380639.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-06 18:07:17 -03:00
Maurício Meneghini Fauth
7a6b3cbba8 Revert "Cannot read property sql_query of undefined: #14104 issue fix (#14105)"
This reverts commit ad86eab974.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-06 18:06:53 -03:00
Piyush Vijay
ad86eab974 Cannot read property sql_query of undefined: #14104 issue fix (#14105)
Fix #14101
Fix #14104

* Cannot read property sql_query of undefined: #14104 issue fix
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* Cannot read property sql_query of undefined: #14104 issue fix
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
2018-03-26 13:25:33 -03:00
Michal Čihař
5a1ceef67d
Merge pull request #14046 from shucon/login
Restore SQL query after session expire
2018-03-16 13:07:20 +01:00
Saksham Gupta
0eaf1b108c Add cookie restore and empty save error
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2018-03-02 11:50:13 +05:30
Michal Čihař
f4026f60a4 Merge branch 'QA_4_7' 2018-03-01 16:02:57 +01:00
Michal Čihař
984c6a0054 Honor arg_separator in AJAX requests
Fixes #13940

Signed-off-by: Michal Čihař <michal@cihar.com>
2018-03-01 15:50:41 +01:00
Saksham Gupta
8537d0125a Fix whitespaces
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2018-03-01 02:20:53 +05:30
Saksham Gupta
e5ff7f34fe Restore SQL query after session expire
Partially Fixes: https://github.com/phpmyadmin/phpmyadmin/issues/13654

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2018-03-01 02:17:28 +05:30
Michal Čihař
1f00c99be9 Share code for parsing data-post attribute
It can include leading question mark and we should deal with it in all
locations.

Fixes #13913

Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit 1fc566fd90)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-22 16:01:00 -03:00
Michal Čihař
be7d5ee738 Simplify handling of long URLs in Util::linkOrButton
We no longer create form, but rather rather tag the link to be handled
as POST on the client side.

This way the code is way simpler without need on any special case
handling on server side.

Fixes #13649

Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit 3b9fb2b664)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-22 13:02:58 -03:00
Michal Čihař
1fc566fd90 Share code for parsing data-post attribute
It can include leading question mark and we should deal with it in all
locations.

Fixes #13913

Signed-off-by: Michal Čihař <michal@cihar.com>
2018-01-08 17:35:32 +01:00