Commit Graph

468 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
2d58411bee Some coding style fixes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 21:30:06 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
af148ad92b Enable strict mode in PHP files
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 04:36:04 -03:00
Isaac Bennetch
c580f7e06b Slight language improvement
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2018-05-03 16:05:52 -04:00
Piyush Vijay
9c7c5ca951 Changes to make Get auto saved query and show this query here again button functional (#14166)
* Handling of autosaved query and making get auto-saved query button functional
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* Basic functionality of show this query here again added
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* Show this query here again checkbox working properly
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* deleting auto_saved_sql on clicking submit query button
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* javascript error handled
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* javascript error of JSON undefined removed
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-03 16:50:38 -03:00
Piyush Vijay
6700b2d56f Designer: "Add options" dialog doesn't reset when canceling: #14110 issue fixed (#14117)
* Designer: "Add options" dialog doesn't reset when canceling: Fix #14110
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* Designer: Add option dialogue error handling needs to be modified Fix #14126
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
2018-03-30 18:45:19 -03:00
Maurício Meneghini Fauth
fcfa31a51f Rename js/pmd directory to js/designer
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-24 16:58:58 -03:00
Saksham Gupta
ff06650269 Prompt before reducing number of rows (#13987)
Fixes #13952

* Prompt before reducing number of rows
* Edit Error Message
* Changed code location
* Fix minor bug
* Improve code quality
* Codacy Fix
* Minor Bug fix
* Travis Rerun
* Requested Changes
* Fix code quality

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2018-02-14 19:35:22 -02:00
Juvenildo Vaz
4e0d1331fd Remove inline styles from messages.php #12262
Signed-off-by: Juvenildo Vaz <juvenildo1511@yahoo.com.br>
2017-12-25 16:14:09 -03:00
Michal Čihař
540b78dc2e Add support for FIDO U2F authentication
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-01 16:34:31 +01:00
Michal Čihař
811d124503 Merge branch 'QA_4_7' 2017-09-04 16:58:11 +02:00
Michal Čihař
04add7c918 Better report connection errors
Provide verbose error description when we can't connect to the server
from client.

Fixes #13183

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-04 16:57:27 +02:00
Isaac Bennetch
c7264e5858 Merge pull request #13455 from Achilles-96/Issue-#5827
Allow Designer to show tables from other databases
2017-08-14 14:10:25 -04:00
HIMANSHU AGRAWAL
b63a39f806 Show warning if no users are selected
Fixes #13538

Signed-off-by: Himanshu Agrawal <himanshuagrawal1998@gmail.com>
2017-08-07 07:19:53 -04:00
Raghuram Vadapalli
7fc7e5aa76 Allow designer to show tables from other DB
Signed-off-by: Raghuram Vadapalli <raghuram.4350@gmail.com>
2017-07-22 23:04:17 +05:30
Michal Čihař
51fb18612a Move Theme object out of session
Honestly I don't see good reason for storing Theme in session as loading
it from the session will take about same time as loading it from the
disk.

Additionally it seems that current code really didn't really use the
object stored in session, it was constructed with every request anyway
(by ThemeManager::initializeTheme).

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-07-17 14:18:35 +02:00
Maurício Meneghini Fauth
ca910e8de8 Move classes to PhpMyAdmin namespace
- Move Table to PhpMyAdmin namespace
- Move Template to PhpMyAdmin namespace
- Move ThemeManager to PhpMyAdmin namespace
- Move Theme to PhpMyAdmin namespace
- Move Tracker to PhpMyAdmin namespace
- Move Transformations to PhpMyAdmin namespace
- Move TypesMySQL to PhpMyAdmin namespace
- Move Types to PhpMyAdmin namespace
- Move Util to PhpMyAdmin namespace
- Move VersionInformation to PhpMyAdmin namespace
- Move Url to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-08 10:54:21 -03:00
Maurício Meneghini Fauth
8f943ae1c0 Move classes to PhpMyAdmin namespace
- Move Sanitize to PhpMyAdmin namespace
- Move SavedSearches to PhpMyAdmin namespace
- Move Scripts to PhpMyAdmin namespace
- Move ServerStatusData to PhpMyAdmin namespace
- Move Sql to PhpMyAdmin namespace
- Move StorageEngine to PhpMyAdmin namespace
- Move SubPartition to PhpMyAdmin namespace
- Move SysInfoLinux to PhpMyAdmin namespace
- Move SysInfoSunOS to PhpMyAdmin namespace
- Move SysInfoWINNT to PhpMyAdmin namespace
- Move SysInfo to PhpMyAdmin namespace
- Move SystemDatabase to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-07 01:46:08 -03:00
Maurício Meneghini Fauth
119563b7ea Move classes to PhpMyAdmin namespace
- Move OpenDocument to PhpMyAdmin namespace
- Move OutputBuffering to PhpMyAdmin namespace
- Move Partition to PhpMyAdmin namespace
- Move Pdf class to PhpMyAdmin namespace
- Move RecentFavoriteTable to PhpMyAdmin namespace
- Move Response to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-06-30 23:44:10 -03:00
Michal Čihař
c065224d1c Merge branch 'QA_4_7' 2017-06-13 17:03:42 +02:00
Michal Čihař
358d2fd1f1 Rewrite export alias defining
The old code did load all colums for all tables in all databases in
export. This can easily explode for server wide exports or exports on
database with lot of tables.

It has been rewritten in a way to load required data on demand from
server. This will make aliases defining slightly slower, but I think
it's acceptable price for making the export work on larger databases.

Fixes #13008

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-06-13 17:02:45 +02:00
Michal Čihař
027ca3d33d Remove no longer needed validation
This is done by browser now.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-05-23 11:38:24 +02:00
Deven Bansod
d833ba5655 Merge branch 'QA_4_6'
Conflicts:
	js/db_search.js
	libraries/DbSearch.php
	test/classes/DbSearchTest.php
2016-11-15 22:26:11 +05:30
Deven Bansod
a3f52751bd Change get ajax request to post to avoid long request URIs
Also, move HTML-embedded JS function calls into JQuery event handlers

Fix #12299

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-11-14 10:45:49 +05:30
Michal Čihař
eb731c91ff Merge remote-tracking branch 'origin/pull/12363' into tmp 2016-11-10 09:45:31 +01:00
Michal Čihař
c48f2a6830 Merge branch 'QA_4_6' 2016-11-08 14:48:48 +01:00
Deven Bansod
11575ad959 Add tooltip for acceptance of additional values
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-10-26 21:44:07 +05:30
Raghuram
0ec33f1052 Localized strings
Signed-off-by: Raghuram Vadapalli<raghuram.vadapalli@research.iiit.ac.in>
2016-10-25 15:38:19 +05:30
Michal Čihař
7ea746fb66 Merge branch 'QA_4_6' 2016-10-25 10:25:46 +02:00
Deven Bansod
c367f93aa8 Allow for all MySQL values of TIME data type
We show slider only for occasionally used times from 00:00:00 to 23:59:59,
but allow for other times when entered by inputting directly in the textbox.

Fix #12637

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-10-20 14:13:00 +05:30
Michal Čihař
7fc28626fd Merge branch 'QA_4_6' 2016-09-19 10:51:50 +02:00
Deven Bansod
f8ea67f2bc Fix #12530: Show enabled links for Edit and Execute after proper priv checks
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-09-16 13:51:34 +05:30
Michal Čihař
3debfa5d1f Merge branch 'QA_4_6' 2016-09-06 11:33:32 +02:00
Deven Bansod
715403c0e7 Fix #12531 : Properly flag queries as DROP DATABASE
Parser recognizes various DROP statements correctly, but the flags set by SQL Parser are incorrectly used.
In js/functions.js, removed the Regex-based matching, rather handle it in PHP as we have correct flags available from SQL Parser

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-09-06 14:20:19 +05:30
Gregory-Buhler
e1eed3ed43 Fixes #12233 Error message improved when user tries to rename database to
same name. Added new functionality to PMA_ajaxShowMessage() allowing for
different notification types.

Signed-off-by: Gregory-Buhler <webmaster@gregorybuhler.com>
2016-05-26 09:54:39 -06:00
Durgesh
6650f7b07d Refactor text sanitization and javascript escaping, Issue #11989, #11988
Signed-off-by: Durgesh <007durgesh219@gmail.com>
2016-02-22 14:45:19 +05:30
Michal Čihař
b5b869419f Avoid nested output buffer problems in test
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-12 15:28:22 +01:00
Atul Pratap Singh
f03d49e674 Merge commit '0f23dd5'
Signed-off-by: Atul Pratap Singh <atulpratapsingh05@gmail.com>

Conflicts:
	js/messages.php
2016-01-12 18:43:15 +05:30
Atul Pratap Singh
0f23dd51d8 Add localStorage availability checks, update the error message
Signed-off-by: Atul Pratap Singh <atulpratapsingh05@gmail.com>
2016-01-12 18:30:04 +05:30
Marc Delisle
6089849fcc Merge commit '66d7c50bee6986c5ff308bca288c01b673a2f69f' 2016-01-10 07:30:26 -05:00
Achilles-96
66d7c50bee Fixes #11796
Signed-off-by: Raghuram Vadapalli <raghuram.vadapalli@research.iiit.ac.in>
2016-01-10 14:48:39 +05:30
Michal Čihař
d6546473c0 Add basic test for js messages
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 15:37:24 +01:00
Michal Čihař
43aa000bdd Merge branch 'QA_4_5' 2015-12-27 10:23:48 +01:00
Michal Čihař
218f13d8e0 Avoid syntax error in javascript messages
If max_input_vars is set to invalid value (eg. 1000M), the generated
javascript is invalid. We fix this by forcing the value to be integer,
what should do the same thing as PHP is doing when parsing this.

Fixes #11783

Signed-off-by: Michal Čihař <michal@cihar.com>
2015-12-27 10:21:35 +01:00
Marc Delisle
06d22e636e Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-07 09:41:46 -05:00
Marc Delisle
9ee3931c09 Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-03 10:43:10 -05:00
Achilles-96
f72864cb2b Fixes issue 11504
Signed-off-by: Achilles-96 <raghuram.vadapalli@research.iiit.ac.in>
2015-11-29 15:44:56 +05:30
Marc Delisle
9d381167f8 Merge branch 'QA_4_5' 2015-11-21 21:08:47 -05:00
Marc Delisle
348c7d734a Fix incorrect message calling
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-11-21 21:06:31 -05:00