Commit Graph

24 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
244d4e8e81 Replace Template::get calls in libraries/classes
Uses Template::render() instead of Template::get().

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 18:18:24 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
0998a50e9e Enable strict mode in Plugins classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 01:09:16 -03:00
Maurício Meneghini Fauth
d15dbea63c Refactor PhpMyAdmin\IpAllowDeny::allowDeny() method
Simplifies the method by separating it into two new methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-03 14:28:37 -03:00
Maurício Meneghini Fauth
d23ed47666 Refactor PhpMyAdmin\IpAllowDeny static methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-03 14:06:13 -03:00
Gabriel Caruso
a8bd364e02 Clean elses
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
2017-12-14 22:02:17 -02:00
Maurício Meneghini Fauth
c930c7a030 Fix coding standard errors
Automatic fixes by phpcbf.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-04 13:40:36 -02:00
Michal Čihař
8f27080d72 Fix php5 compatibility
Issue #13832

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-28 07:53:22 +01:00
Michal Čihař
b8fb7f254b Fix referenceding twofactor attribute
Fixes #13832

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-27 22:24:06 +01:00
Michal Čihař
c7e0782201 Do not show verify button on invalid 2fa
Fixes #13832

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-27 16:17:12 +01:00
Michal Čihař
49a1b0e743 Move session cleanup to post login
It was really misplaced in 951e8ac753
it did cleanup session with every request.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-27 13:14:58 +01:00
Michal Čihař
80db5c457a Merge branch 'QA_4_7' 2017-11-27 09:26:41 +01:00
Michal Čihař
951e8ac753 Consistent session handling across plugins
We want all auth plugins to behave same, there is no reason to secure
session only in the cookie plugin.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-27 09:14:52 +01:00
Michal Čihař
5acd64f84d Use two-factor authentication instead fo second authentication factor
This is probably more widely used naming.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-02 09:05:18 +01:00
Michal Čihař
a646d4314e Add generic interface for second authentication factor
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-01 16:34:14 +01:00
Michal Čihař
8e8f4bd3bb Avoid using PHP_AUTH_USER and PHP_AUTH_PW globals for auth
Use object attributes to store the actual credentials and avoid
messing up with global variables.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-20 19:44:28 +02:00
Michal Čihař
62535ea5b9 Pass failure reason to showFailure
This way we can avoid relying on global variables to check it.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-20 19:44:28 +02:00
Michal Čihař
2327dbf3c3 Move allow/deny rules check to AuthenticationPlugin
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-20 18:14:56 +02:00
Michal Čihař
9bc5bfd74c Move authentication logic to AuthenticationPlugin
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-20 18:14:56 +02:00
Michal Čihař
026d722178 Rationalize AuthenticationPlugin API
Make the API more consistent, remove not needed auth prefix and stop
talking about advanced authentication which has been there about 10
years ago.

API changed:

- authCheck is now readCredentials
- authSetUser is now storeCredentials
- auth is now showLoginForm
- authFails is now showFailure
- storeUserCredentials is now rememberCredentials

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-20 18:14:56 +02:00
Michal Čihař
13d2ff1f5b Consistely use no return value for AuthenticationPlugin::authFails
It really does not return in the end, so make the docs consistent
with the code.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-20 18:14:56 +02:00
Michal Čihař
56c1c9fc5c Share base code for AuthenticationPlugin::authSetUser
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-20 18:14:56 +02:00
Maurício Meneghini Fauth
2631bcedba Move plugins classes to PhpMyAdmin namespace
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-20 11:50:12 -03:00