Commit Graph

26 Commits

Author SHA1 Message Date
William Desportes
e816e45c18 phpstan level 0 (#14405)
* Fix phpdoc @return

- Fixed @return typehint

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix incorrect case on function calls

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Type hint + typo fix

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fixes

- @return fix
- @var fix
- Class names
- Throws fix
- test/classes/Plugins/Export/ExportSqlTest.php any() invoked with 1 parameter, 0 required
-  libraries/classes/Controllers/Table/TableStructureController.php Array has 2 duplicate keys with value 'columns_list'
- Call parent constructor  libraries/classes/Error.php

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Access to an undefined property

- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\PdfRelationSchema::$diagram_row
- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\Pdf::$cMargin
- Undefined properties

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix bootstrap-phpstan

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix typos and phpstan config

Fixes: #14399
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-25 20:34:46 -03:00
Maurício Meneghini Fauth
2005cca77f Fix methods and properties visibility issues
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 21:02:26 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
4bff9256de Remove 'Undefined index' PHP notice
- libraries/classes/Plugins/Export/ExportXml.php
- libraries/classes/Plugins/Import/ImportLdi.php

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-29 00:39:40 -03:00
Maurício Meneghini Fauth
3c12c9efb4
Merge pull request #14119 from meteorlxy/patch-tmp
fix: AUTO_INCREMENT error when only exporting table structure in database-level exports; issue #14066
2018-05-16 14:52:46 -03:00
Maurício Meneghini Fauth
0998a50e9e Enable strict mode in Plugins classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 01:09:16 -03:00
Maurício Meneghini Fauth
2f824e5508
Merge pull request #14216 from Piyush3079/PMA_14212
Fix XML Export fatal error and add Move columns preview SQL
2018-05-04 02:40:54 -03:00
Gabriel Caruso
c1786eee96
Use array_key_exists instead of in_array + array_keys
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
2018-04-22 22:39:55 -03:00
Piyush Vijay
5b35dba67d
XML Export from single table throws fatal error (PHP 7.2): #14212 issue fixed
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
2018-04-20 14:22:20 +05:30
Rijas Ahammed PK
d6ca2d249e Enable columns names by default for CSV in issue #14007 solved (#14076)
* Enable columns names by default for CSV

* Improve formatting

Signed-off-by: “Rijas <“Rijas.Ahammed@icfoss.in”>

* Follow formatting standard

Enclosed body of if statement within braces
Add space between if keyword and paranthesis

Signed-off-by: Rijas Ahammed PK <Rijaspk5195@gmail.com>
2018-04-04 22:28:38 -03:00
Maurício Meneghini Fauth
c73e72e7ca Refactor PhpMyAdmin\Transformations static methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-01 01:34:17 -03:00
Maurício Meneghini Fauth
2638eb9207 Refactor PhpMyAdmin\Export static methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-31 19:28:25 -03:00
Maurício Meneghini Fauth
d98658187a Replace PhpMyAdmin\Relation static calls
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-25 19:32:13 -03:00
Xinyu Liu
f1fa924f5f fix: AUTO_INCREMENT error when only exporting table structure in database-level exports; issue #14066
Signed-off-by: Xinyu Liu <meteor.lxy@foxmail.com>
2018-03-24 09:19:57 +00:00
Gabriel Caruso
6ff73257e2 Simplify returns
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
2018-01-16 10:16:56 -02:00
Gabriel Caruso
a8bd364e02 Clean elses
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
2017-12-14 22:02:17 -02:00
Michal Čihař
99e47a90d9 Always define correct connection type
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-25 10:21:18 +02:00
Michal Čihař
4fe87fb592 Remove usage of $GLOBALS['controllink']
This is now stored internally inside DatabaseInterface instance.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-25 10:21:18 +02:00
Maurício Meneghini Fauth
1d4125f15c Add array type declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-24 23:49:59 -03:00
Maurício Meneghini Fauth
54cfbc5eda Refactor export functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-05 12:07:49 -03:00
Maurício Meneghini Fauth
e2c83b954b Refactor relation functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-08-22 20:51:27 -03:00
Michal Čihař
87ec560346 Merge branch 'QA_4_7' 2017-08-21 11:47:34 +02:00
Michal Čihař
c146127b73 Merge branch 'QA_4_7' 2017-07-31 16:36:09 +02:00
Maurício Meneghini Fauth
6e53b22991 Move properties classes to PhpMyAdmin namespace
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-20 12:08:58 -03:00
Maurício Meneghini Fauth
2631bcedba Move plugins classes to PhpMyAdmin namespace
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-20 11:50:12 -03:00