Commit Graph

44 Commits

Author SHA1 Message Date
William Desportes
e816e45c18 phpstan level 0 (#14405)
* Fix phpdoc @return

- Fixed @return typehint

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix incorrect case on function calls

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Type hint + typo fix

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fixes

- @return fix
- @var fix
- Class names
- Throws fix
- test/classes/Plugins/Export/ExportSqlTest.php any() invoked with 1 parameter, 0 required
-  libraries/classes/Controllers/Table/TableStructureController.php Array has 2 duplicate keys with value 'columns_list'
- Call parent constructor  libraries/classes/Error.php

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Access to an undefined property

- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\PdfRelationSchema::$diagram_row
- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\Pdf::$cMargin
- Undefined properties

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix bootstrap-phpstan

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix typos and phpstan config

Fixes: #14399
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-25 20:34:46 -03:00
Maurício Meneghini Fauth
0912a1f178 Fix missing parameter comment on RTE classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-20 23:20:25 -03:00
Maurício Meneghini Fauth
3516f4d410 Remove $GLOBALS['dbi'] from Rte\General
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-19 21:53:08 -03:00
Maurício Meneghini Fauth
96dc767efb Remove $GLOBALS['dbi'] from Rte\Footer
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-19 21:46:35 -03:00
Maurício Meneghini Fauth
19476eab73 Remove $GLOBALS['dbi'] from Rte\Export
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-19 21:32:33 -03:00
Maurício Meneghini Fauth
bc2d5ea0d2 Remove $GLOBALS['dbi'] from Rte\RteList
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-19 21:05:36 -03:00
Maurício Meneghini Fauth
43d5c5db66 Remove $GLOBALS['dbi'] from Rte\Triggers
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-19 20:27:21 -03:00
Maurício Meneghini Fauth
510c11b039 Remove $GLOBALS['dbi'] from Rte\Routines
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-19 20:14:48 -03:00
Maurício Meneghini Fauth
66bd8b4a86 Remove $GLOBALS['dbi'] from Rte\Events
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-19 12:44:02 -03:00
Maurício Meneghini Fauth
2d58411bee Some coding style fixes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 21:30:06 -03:00
Maurício Meneghini Fauth
244d4e8e81 Replace Template::get calls in libraries/classes
Uses Template::render() instead of Template::get().

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 18:18:24 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
56ce176752 Enable strict mode in Rte classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 03:20:45 -03:00
Maurício Meneghini Fauth
374b2379ad
Merge pull request #14179 from rijaspk/master
Remove Inline Styles from Ruotines.php
2018-04-24 00:47:33 -03:00
“Rijas
01692acc72 Remove Inline Styles from Ruotines.php
Signed-off-by: Rijas Ahammed PK <rijaspk5195@gmail.com>
2018-04-19 14:25:31 +05:30
Maurício Meneghini Fauth
f6bf0dba3c Refactor PhpMyAdmin\Rte\General methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-11 06:15:07 -03:00
Maurício Meneghini Fauth
f078ed6b9f Refactor PhpMyAdmin\Rte\Words methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-11 06:15:07 -03:00
Maurício Meneghini Fauth
604441575a Refactor PhpMyAdmin\Rte\RteList methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-11 06:15:07 -03:00
Maurício Meneghini Fauth
67313b5e9d Refactor PhpMyAdmin\Rte\Footer static methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-11 06:15:07 -03:00
Maurício Meneghini Fauth
9775d43b35 Refactor PhpMyAdmin\Rte\Export static methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-11 06:15:07 -03:00
Maurício Meneghini Fauth
c0ed262b11 Refactor PhpMyAdmin\Rte\Triggers static methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-11 06:15:07 -03:00
Maurício Meneghini Fauth
7adffc0bc6 Refactor PhpMyAdmin\Rte\Events static methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-11 06:15:07 -03:00
Maurício Meneghini Fauth
ba00b51ad8 Refactor PhpMyAdmin\Rte\Routines methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-06 03:39:13 -03:00
Michal Čihař
e991d18654 Coding style fixes for #13892
Signed-off-by: Michal Čihař <michal@cihar.com>
2018-02-20 05:42:38 +01:00
William Desportes
71e304720f Patch for issue #13889
Fixes the issue #13889

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-02-12 18:49:39 +01:00
Michal Čihař
2bc87216f0 Adjust RTE oprations to use POST
Issue #13866

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-12-15 12:35:00 +01:00
Michal Čihař
4f14bccbfe Remove ajax_class global from RTE
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-12-15 12:28:20 +01:00
Maurício Meneghini Fauth
01fd301003 Use 'elseif' keyword istead of 'else if'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-04 13:31:25 -02:00
Maurício Meneghini Fauth
3d44419cbd Use lowercase for PHP booleans and null
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-04 13:14:40 -02:00
Michal Čihař
14e78f79bb Avoid error when event is not really added
This can easily happen when it was scheduled in past, MySQL then just ignores it.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-29 12:44:41 +01:00
Michal Čihař
bed6fb4ebd Avois passing extension to Util::getImage
We do not use it anyway for quite some time and this way it's less
processing to generate the img tag.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-27 14:24:42 +01:00
Maurício Meneghini Fauth
cc2c4fc36d Replace globals with DI in Charsets class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-09 11:31:42 -02:00
Michal Čihař
98964e2f59 Remove is_superuser superglobal
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-10 12:28:00 +02:00
Michal Čihař
d574aede08 Bind Types to DatabaseInterface
This wayt it's automatically passed with DBI.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-10 12:05:02 +02:00
Maurício Meneghini Fauth
1d4125f15c Add array type declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-24 23:49:59 -03:00
Maurício Meneghini Fauth
bd81fa1543 Refactor rte_triggers functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-08 23:19:30 -03:00
Maurício Meneghini Fauth
1eac7bb3a2 Refactor rte_routines functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-08 22:03:07 -03:00
Maurício Meneghini Fauth
7a054c72e6 Refactor rte_words function to a static method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-08 18:54:57 -03:00
Maurício Meneghini Fauth
6be2bfebf0 Refactor rte_list functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-08 18:39:46 -03:00
Maurício Meneghini Fauth
fe1ac3b343 Refactor rte_general functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-08 16:37:37 -03:00
Maurício Meneghini Fauth
532f821463 Refactor rte_footer functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-08 16:24:22 -03:00
Maurício Meneghini Fauth
385942f7bd Refactor rte_export functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-08 14:52:34 -03:00
Maurício Meneghini Fauth
2e52c0f1f8 Refactor rte_events functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-08 13:09:13 -03:00