Commit Graph

663 Commits

Author SHA1 Message Date
Atul Pratap Singh
b756cc66de update js for add/remove modify columns in multi sort
Signed-off-by: Atul Pratap Singh <atulpratapsingh05@gmail.com>
2014-07-02 00:37:14 +05:30
Chanaka Indrajith
39b5f07dfb Fixed some documentation issues raised by scrutinizer
Signed-off-by: Chanaka Indrajith <pe.chanaka.ck@gmail.com>
2014-05-18 00:14:27 +05:30
Ashutosh Dhundhara
5ea6345adb Filter rows option on "Browse" table page.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Filter rows feature on "Browse" table page.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Included table filter plugin in tbl_select.php.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-03-31 17:52:48 +05:30
Aditya Sastry
a05ab9640b Multicolumn sorting feature request(1507)
This patch completely implements the feature requested and it modifies 4
existing files and adds one extra Javascript file. The existing system for
one column sorting has been refactored to be used for multicolumn sort.

Files messages.php and makegrid.js where modified to add the tool tip.

File sql.php was modified to add the import statement for the newly added JS
file.

The newly added columndelete.js is responsible for shift deleting the columns.
It gets the url of the link that was shift clicked and removes the name of the
column which we want to remove from the order by clause.

Finally, most of the crux of this feature request is implemented through
changes to the DisplayResult.class.php. 4 methods of this class have been
refactored to accomodate the required change. getsortparams() which process
the order by clause text remains the same, just the output parameters have
been turned into a array for each order by clause column. isInSort() has been
modified to check multiple order by clauses. The smart ordering feature in
to form a new function makeURL, which makes the url for multiple sorted table's
header's button's targets.

Signed-off-by: Aditya Sastry <ganeshaditya1@gmail.com>
2014-03-24 02:17:54 +05:30
Marc Delisle
effa00f209 Bug #4135 When searching, error "No database selected" 2013-10-15 15:36:13 -04:00
Madhura Jayaratne
71950aaf08 Make these long parameter lists a bit easier to read 2013-10-15 07:03:14 +05:30
Atul Pratap Singh
ec6f20fac9 Database was being set at wrong place 2013-10-15 00:08:50 +05:30
Michal Čihař
40a0aec442 Fix typo 2013-08-07 19:53:52 +02:00
Michal Čihař
b2e1f81c0c Use PMA_URL_getCommon for generating all params 2013-08-07 17:00:52 +02:00
Michal Čihař
0a3d1d5be8 Better names for URL generating functions 2013-08-07 10:58:17 +02:00
Marc Delisle
76ba0b03cd No longer needed 2013-07-22 15:33:54 -04:00
Marc Delisle
e186cffe2d Clarify code path 2013-07-22 06:03:03 -04:00
Spun Nakandala
36a4ba240a corrected error display shown when browsing a table for the first time after logging 2013-07-20 21:13:50 +05:30
Spun Nakandala
d15028ead2 sorted column not remembering error corrected 2013-07-19 21:42:35 +05:30
Spun Nakandala
f31bb7a196 renamed methods to better reflect their usage. 2013-07-18 20:39:43 +05:30
Spun Nakandala
e8994364a8 added methods PMA_executeQueryAndSendResponse, PMA_sendResponse 2013-07-18 19:35:06 +05:30
Marc Delisle
55746b58ec Clarify the origin of $text_dir (text direction) global 2013-07-16 09:33:05 -04:00
Spun Nakandala
0fee81639e extracted method PMA_sendResponseForResultsReturned 2013-07-16 14:01:56 +05:30
Spun Nakandala
76de6049d6 unset variable notice corrected 2013-07-15 20:52:59 +05:30
Spun Nakandala
c60b65abd6 removed redundant parameter 2013-07-15 20:15:35 +05:30
Marc Delisle
8ce9acb65b Merge pull request #503 from scnakandala/gsoc_2013_2
Refactoring SQL executor
2013-07-14 13:05:14 -07:00
Marc Delisle
22884539af No need for this to be a global variable 2013-07-14 15:55:44 -04:00
Spun Nakandala
6c9da035ff check for CALL transferred to the sql parser 2013-07-14 21:19:28 +05:30
Spun Nakandala
116687e873 phpcs coding standard violations corrected 2013-07-14 17:29:42 +05:30
Spun Nakandala
c7feab8dc5 bookmarking error corrected 2013-07-14 17:18:55 +05:30
Spun Nakandala
3bbcd64df4 default $sql_limit_to_append transfered to the else condition. 2013-07-14 14:36:11 +05:30
Spun Nakandala
ec35836b41 print view bookmark form display error corrected 2013-07-14 12:53:13 +05:30
Spun Nakandala
e96b7d6b27 error corrected 2013-07-09 23:05:24 +05:30
Spun Nakandala
cc6da648c7 error corrected 2013-07-09 22:38:04 +05:30
Spun Nakandala
503df0a6a7 removed redundant methods 2013-07-09 22:32:02 +05:30
Spun Nakandala
4acc14051e error corrected 2013-07-09 21:35:26 +05:30
Spun Nakandala
07cd7234cf removed method PMA_getHtmlForPrintView and changed the method PMA_getHtmlForPrintViewHeader 2013-07-09 21:12:00 +05:30
Spun Nakandala
419876ee4c changed method PMA_getHtmlForProfilingChart 2013-07-09 21:03:16 +05:30
Spun Nakandala
765a3e464a changed PMA_getHtmlForBookmark function 2013-07-09 19:32:33 +05:30
Spun Nakandala
9c14ce3ee8 added method PMA_getHtmlForPrintView 2013-07-09 18:27:24 +05:30
Spun Nakandala
e5f3f7e0ac added methods PMA_getHtmlForPrintButton, PMA_getHtmlForIndexesProblems, PMA_getMessageIfMissingColumnIndex, PMA_getHtmlForPreviousUpdateQuery, PMA_getHtmlForSqlQueryResultsTable, PMA_getBookmarkCreatedMessage 2013-07-09 18:05:17 +05:30
Spun Nakandala
ebef06fa0d added method PMA_getHtmlForSqlQueryResults 2013-07-09 16:27:34 +05:30
Spun Nakandala
f2b268b137 All the requests will be ajax 2013-07-09 15:03:10 +05:30
Spun Nakandala
27859550cf added methods PMA_getHtmlForTableMaintenanceResponse, PMA_sendResponseOrGetHtmlForTableMaintenance 2013-07-09 14:17:08 +05:30
Spun Nakandala
bc055fe4b7 can be done only once 2013-07-09 11:55:41 +05:30
Spun Nakandala
4c912a6ae7 added method PMA_sendResponseForGridEdit 2013-07-09 11:29:48 +05:30
Spun Nakandala
ab0b933c44 removed dead code from PMA_sendResponseForNoResultsReturned 2013-07-05 23:10:08 +05:30
Spun Nakandala
b02a22cc24 added methods PMA_sendResponseForNoResultsReturned, PMA_sendAjaxResponseForNoResultsReturned, PMA_getMessageForNoRowsReturned, PMA_deleteTransformationInfo to the libraries/sql.lib.php 2013-07-02 19:48:20 +05:30
Spun Nakandala
b267d59012 statement transferred to the else condition 2013-07-01 20:02:00 +05:30
Spun Nakandala
7cdf9ebeb8 removed unused parameters and code 2013-07-01 19:56:37 +05:30
Spun Nakandala
8045c7ef6c Added methods PMA_cleanupRelations, PMA_countQueryResults, PMA_executeTheQuery 2013-06-30 21:14:04 +05:30
Spun Nakandala
07a5ace900 bookmark creation error corrected 2013-06-28 23:48:40 +05:30
Spun Nakandala
2ecc1d3d69 the method name is straight forward 2013-06-28 22:26:26 +05:30
Spun Nakandala
fe5ae9f04f not valid for current master 2013-06-28 22:23:55 +05:30
Spun Nakandala
70a58bcfd0 unwanted parameters removed 2013-06-28 20:19:50 +05:30
Spun Nakandala
c86d80b8c7 irrelevant for current master. So removed. 2013-06-27 22:53:20 +05:30
Spun Nakandala
d3e6df82d3 function renamed 2013-06-27 22:43:56 +05:30
Spun Nakandala
5a2b0b2581 added method PMA_hasCurrentDBChanged 2013-06-27 19:29:10 +05:30
Spun Nakandala
e40d24f52f created method PMA_getNumberOfRowsAffectedOrChanged 2013-06-27 19:18:50 +05:30
Spun Nakandala
67ff3aee1b Added methods PMA_getDefaultSqlQueryForBrowse, PMA_goBackFurtherPage, PMA_handleQueryExecuteError, PMA_storeTheQueryAsBookmark, PMA_executeQueryAndStoreResults 2013-06-27 15:50:50 +05:30
Spun Nakandala
c349581d9a typo corrected 2013-06-26 16:23:01 +05:30
Spun Nakandala
b05a0fdfe8 indentation corrected. comment corrected 2013-06-26 16:18:16 +05:30
Spun Nakandala
88e3e5fc04 Added the methods PMA_setColumnOrder, PMA_setColumnVisibility, PMA_setColumnOrderOrVisibility, PMA_addBookmark,PMA_findRealEndOfRows, PMA_getRelationalValues, PMA_getEnumOrSetValues, PMA_appendLimitClaues 2013-06-25 21:21:56 +05:30
Spun Nakandala
2da3c58b44 Undefined index: is_superuser corrected 2013-06-25 19:00:33 +05:30
Spun Nakandala
afcf5da9f7 wrapped lines 2013-06-24 03:00:25 +05:30
Spun Nakandala
44858bb4bd removed unwanted comment 2013-06-24 02:58:30 +05:30
Spun Nakandala
c00d25b02d PMA_hasNoRightsToDropDatabase, PMA_isDeleteTransformationInfo, PMA_isJustBrowsing, PMA_isAppendLimitClause, PMA_isRememberSortingOrder methods added to the libraries/sql.lib.php 2013-06-24 02:57:58 +05:30
Spun Nakandala
8d12cbb14d extra space removed 2013-06-21 14:03:26 -04:00
Spun Nakandala
561983aff4 "Show all" feature no longer works problem corrected 2013-06-21 14:03:08 -04:00
Spun Nakandala
93c2f414cd removed the redundant variable $bkm_user 2013-06-19 17:52:57 +05:30
Spun Nakandala
e3298a12d3 Error relating to the uninitialized variable $cfg corrected 2013-06-19 10:58:13 +05:30
Spun Nakandala
4bc178bbd2 USE database reloads the respective database 2013-06-18 23:07:47 +05:30
Spun Nakandala
c1bd633a8a This bug is not relevant to the current master 2013-06-18 13:11:06 +05:30
Spun Nakandala
9d654bc172 PMA_getHtmlForBookmark method added to the sql.lib.php 2013-06-17 23:28:45 +05:30
Spun Nakandala
480f3062aa long if conditions transfered to the parser_analyzer.inc.php to initialize variables 2013-06-17 22:53:57 +05:30
Marc Delisle
c4883127c7 This file should not end in .lib.php 2013-06-16 08:08:07 -04:00
Spun Nakandala
7cecc2f23d code related to analyzing the sql query transferred to the sql analyzer 2013-06-15 14:50:31 +05:30
Spun Nakandala
ae9ff0a8be check for drop database transfered to sql parser 2013-06-13 23:00:06 +05:30
Spun Nakandala
653bc9bd2c Checking for reload the navigation transfered to the sql parser 2013-06-13 23:00:04 +05:30
Marc Delisle
25a3a03e0c Merge pull request #415 from scnakandala/gsoc_2013
Refactoring SQL executor
2013-06-13 09:20:43 -07:00
Spun Nakandala
3fabd7728f $_POST['fields'][...] variables renamed such that they better reflect their intended purpose 2013-06-13 11:31:29 +05:30
Spun Nakandala
ca8d81b95c PMA_isDropDatabase($sql_query) method added to sqlparser.lib.php 2013-06-12 22:05:24 +05:30
Spun Nakandala
e32064bcd2 code for displaying confirm page removed. 2013-06-12 19:54:44 +05:30
Spun Nakandala
9ef591e69e space added before elseif 2013-06-12 17:21:51 +05:30
Marc Delisle
cca17c031d Merge branch 'QA_4_0' 2013-06-12 06:42:09 -04:00
Marc Delisle
f5d631dbf6 bug #3976 Number of pages 2013-06-12 06:40:20 -04:00
Spun Nakandala
96bf1782d3 PMA_getHtmlForConfirmPage method added to sql.lib.php to create html for the confirm page. 2013-06-11 21:55:39 +05:30
Spun Nakandala
7f80aa2971 Avoided the use of global variables by directly accessing super global variables. 2013-06-11 20:42:07 +05:30
Dieter Adriaenssens
738caedafb RFE 1432, add table name to message 2013-06-04 17:18:21 +02:00
Dieter Adriaenssens
c6fd32f85d Merge branch 'QA_4_0'
Conflicts:
	sql.php
2013-06-04 10:54:04 +02:00
Dieter Adriaenssens
7a3c15724a fix bug #3966, only display 'table has no unique column' when table is defined 2013-06-04 10:45:53 +02:00
Madhura Jayaratne
2baf473ad7 Merge branch 'master' into OOP_DBI
Conflicts:
	libraries/database_interface.lib.php
2013-05-26 21:43:33 +05:30
Madhura Jayaratne
3dd99512f0 These constants are better as a part of DatabaseInterface class 2013-05-26 21:15:24 +05:30
Marc Delisle
b8e4f346a5 Clarify function name 2013-05-26 11:34:43 -04:00
Atul Pratap Singh
8cd420ac94 Remove duplicate code, profiling scripts already included 2013-05-25 16:47:32 +05:30
Madhura Jayaratne
ce85ebd950 Merge branch 'master' into OOP_DBI 2013-05-24 19:06:45 +05:30
Marc Delisle
be31655c38 Fix merge conflicts 2013-05-24 08:59:13 -04:00
Madhura Jayaratne
650a8cdda3 Convert database interface to a class 2013-05-24 17:30:59 +05:30
Atul Pratap Singh
c88762e386 Include profiling scripts initially, bug#3639 in QA_4_0 2013-05-23 23:54:29 +05:30
Madhura Jayaratne
f7d6517f0f Coding style fixes 2013-05-23 22:54:40 +05:30
Atul Pratap Singh
dbb0ed3e6a Include profiling scripts initially, bug#3639 2013-05-23 18:07:24 +05:30
Atul Pratap Singh
435dc9c74a left while fixing bug#3936 2013-05-17 10:42:45 +05:30
Brad Jorgensen
5ba39c172a Merge branch 'master' of https://github.com/phpmyadmin/phpmyadmin.git into profiler3 2013-05-15 10:06:08 -05:00
Brad Jorgensen
4d79fabac3 implementation of feature request #1363 2013-05-15 09:54:18 -05:00
Marc Delisle
e28f3c064d Merge branch 'QA_4_0' 2013-05-14 12:19:58 -04:00