Commit Graph

29 Commits

Author SHA1 Message Date
William Desportes
e816e45c18 phpstan level 0 (#14405)
* Fix phpdoc @return

- Fixed @return typehint

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix incorrect case on function calls

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Type hint + typo fix

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fixes

- @return fix
- @var fix
- Class names
- Throws fix
- test/classes/Plugins/Export/ExportSqlTest.php any() invoked with 1 parameter, 0 required
-  libraries/classes/Controllers/Table/TableStructureController.php Array has 2 duplicate keys with value 'columns_list'
- Call parent constructor  libraries/classes/Error.php

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Access to an undefined property

- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\PdfRelationSchema::$diagram_row
- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\Pdf::$cMargin
- Undefined properties

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix bootstrap-phpstan

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix typos and phpstan config

Fixes: #14399
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-25 20:34:46 -03:00
Maurício Meneghini Fauth
2005cca77f Fix methods and properties visibility issues
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 21:02:26 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
dc8c92bfd8 Enable strict mode in test files
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 04:36:04 -03:00
Maurício Meneghini Fauth
cbfbb3adaf Remove incomplete tests
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-30 00:31:37 -03:00
Maurício Meneghini Fauth
c73e72e7ca Refactor PhpMyAdmin\Transformations static methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-01 01:34:17 -03:00
Maurício Meneghini Fauth
f45d4a566b Refactor PhpMyAdmin\Display\Export class
The static methods are replaced with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-13 23:51:16 -02:00
Maurício Meneghini Fauth
11c43ef980 Use template for getHtmlForExportOptionsOutputSaveDir
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-10 17:30:00 -02:00
Maurício Meneghini Fauth
ccacfb018f Fix Display/ResultsTest global dependencies
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-20 19:08:45 -02:00
Maurício Meneghini Fauth
7a62f03edd Fix Display/ExportTest global dependencies
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-20 19:06:07 -02:00
Michal Čihař
3b6a994dcd Move collation connection setting to user preferences
It is now handled same way as other user settings.

Issue #11688
Issue #13466

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-29 14:16:31 +01:00
Michal Čihař
bed6fb4ebd Avois passing extension to Util::getImage
We do not use it anyway for quite some time and this way it's less
processing to generate the img tag.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-27 14:24:42 +01:00
Maurício Meneghini Fauth
bdb35e5769 Use template for _buildNullDisplay method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-19 00:28:44 -02:00
Maurício Meneghini Fauth
70e9ec0fcd Use template for _buildValueDisplay
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-18 23:40:56 -02:00
Maurício Meneghini Fauth
dfa796be07 Use template for _getTableNavigationButton
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-18 20:27:02 -02:00
Maurício Meneghini Fauth
dba5237520 Use template for _getShowAllCheckboxForTableNavigation
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-18 20:27:02 -02:00
Michal Čihař
99e9854473 Always use POST for links containing SQL query
This way the SQL queries will not apper in the web server logs.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-16 15:33:53 +01:00
Michal Čihař
22efbd263e Fix typo in transformation
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-14 10:48:43 +01:00
Gabriel Caruso
45828153b6 Use PSR-1 for PHPUnit TestCase
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
2017-11-06 06:29:04 -02:00
Maurício Meneghini Fauth
c00245fa0a Move PMATestCase to PhpMyAdmin\Tests\PmaTestCase
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-30 16:34:53 -03:00
Maurício Meneghini Fauth
1d4125f15c Add array type declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-24 23:49:59 -03:00
Maurício Meneghini Fauth
df30240015 Add namespace to test classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-20 13:03:50 -03:00
Maurício Meneghini Fauth
700e081833 Refactor plugin_interface functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-12 17:36:39 -03:00
Maurício Meneghini Fauth
512d81cb29 Refactor display_create_table to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-07 09:37:02 -03:00
Maurício Meneghini Fauth
2217b4c960 Refactor change password function to static method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-06 21:42:18 -03:00
Maurício Meneghini Fauth
82dc32305b Rename DisplayResults to Display/Results
Move libraries/classes/DisplayResults.php to libraries/classes/Display/Results.php

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-06 21:13:54 -03:00
Michal Čihař
a82f8fc768 Move databaase interface load to static method
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 14:46:56 +02:00
Maurício Meneghini Fauth
43ff4566d0 Refactor display_export to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-04 10:15:47 -03:00