Commit Graph

102 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
41d401b95e Extract save action from table structure index method
Closes #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-08 19:57:28 -03:00
Maurício Meneghini Fauth
2529824c23 Extract change column action from table structure index method
Related to #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-08 18:20:48 -03:00
Maurício Meneghini Fauth
5df2c41d67 Extract add-key action from table structure index method
Related to #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-06 19:35:52 -03:00
Maurício Meneghini Fauth
4446963b5a Extract partitioning actions from index method
Extracts from Table/StructureController::index method.

Related to #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-06 17:20:10 -03:00
Maurício Meneghini Fauth
2937e9796d Remove underscore prefix from some method names
Related to #16149

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-30 17:20:43 -03:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
3ae05c785d Use short list syntax and single line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 20:22:18 -03:00
William Desportes
6d123fe452
Some minor codebase fixes and improvements
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-24 15:25:56 +02:00
Maurício Meneghini Fauth
e638ac2104 Extract table structure reserved word check action
Related to #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-23 15:24:16 -03:00
Maurício Meneghini Fauth
1d17c55f36 Extract table structure move columns action
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-22 20:20:47 -03:00
Maurício Meneghini Fauth
7902e28652 Remove duplicated code in Table\StructureController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-22 19:46:26 -03:00
Maurício Meneghini Fauth
3bf3fd5c36 Extract browse action from table structure index method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-22 19:36:07 -03:00
Maurício Meneghini Fauth
a6d9818b3a Extract the change action from table structure index method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-22 19:36:07 -03:00
Maurício Meneghini Fauth
765059def4 Extract central columns actions from index method
Extracts the /table/structure/central-columns-add and
/table/structure/central-columns-remove routes from the /table/structure
route.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-22 17:15:15 -03:00
Maurício Meneghini Fauth
7b5ed8634a Extract the ftext action from table structure index method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-22 15:43:09 -03:00
Maurício Meneghini Fauth
3551dc3eaa Extract spatial action from table structure index method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-22 03:22:14 -03:00
Maurício Meneghini Fauth
2eceedb05c Extract unique action from table structure index action
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-22 02:12:36 -03:00
Maurício Meneghini Fauth
4913980970 Extract add index action from table structure index method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-21 15:29:36 -03:00
Maurício Meneghini Fauth
115f79c959 Extract primary action from table structure index method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-20 19:59:55 -03:00
Maurício Meneghini Fauth
04590f5b4f Extract drop fields action from index action
Extracts the /table/structure/drop route from the /table/structure
route.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-19 13:37:16 -03:00
Maurício Meneghini Fauth
ff86a0b6d6 Extract drop confirmation action from index action
Extracts the /table/structure/drop-confirm route from the
/table/structure route.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-19 11:21:42 -03:00
William Desportes
a72203c514
Remove some unused code
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-16 23:51:43 +02:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 18:08:20 -03:00
William Desportes
9bc55b2bc9
Remove some unused variable assignements
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-15 22:44:50 +02:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
b7af1364c6
Psalm auto fixes manualy reviewed and edited
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-28 23:18:59 +02:00
Maurício Meneghini Fauth
4a0bce1d53 Extract db structure bulk actions from mult_submits
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-22 23:13:35 -03:00
Maurício Meneghini Fauth
ca40546bd2 Extract table field actions from mult_submits
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-22 19:41:52 -03:00
Maurício Meneghini Fauth
9b7c4931d3 Add AbstractController::render method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-16 20:15:42 -03:00
Maurício Meneghini Fauth
db642ab19e Extract HTML from Index:getHtmlFromIndexes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-29 23:43:18 -03:00
Maurício Meneghini Fauth
eb2804540f Extract HTML from Index::getHtmlForDisplayIndexes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-29 16:09:50 -03:00
Maurício Meneghini Fauth
558226d78e Extract HTML from StorageEngine::getHtmlSelect()
Renames the method to StorageEngine::getArray().

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-27 19:31:35 -03:00
Maurício Meneghini Fauth
c8c2e9d793 Refactor tbl_columns_definition_form.inc.php
Extracts the tbl_columns_definition_form.inc.php logic to the
PhpMyAdmin\Table\ColumnsDefinition::displayForm static method.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-17 02:55:20 -03:00
William Desportes
01cd7dc33b
Some code improvements suggested by Scrutinizer
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-14 22:23:16 +01:00
William Desportes
517222ff59
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-13 00:07:11 +01:00
William Desportes
0b2937dd6a
Fix #15781 - Illegal string offset error on structure page of 'information_schema'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-12 23:11:41 +01:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67 Remove useless comments in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
50bc4ab37f Remove useless PHP docs for functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 00:38:34 -03:00
William Desportes
ae0577ab1e
Merge #15820 - Fix #15797 - Relation view broken
Fixes: #15797
Pull-request: #15820
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-19 15:43:59 +01:00
Jayati Shrivastava
5a03410cfa fixes url.
fixes #15797

Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
2020-01-19 20:06:03 +05:30
William Desportes
fd036d7f4a
Merge #15808 - Fix #15312 - added LOCK=NONE to ALGORITHM=INPLACE
Fixes: #15312
Pull-request: #15808
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-19 13:53:25 +01:00
Maurício Meneghini Fauth
77d5b1d8d8 Remove extract functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-17 19:44:00 -03:00