gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
127,065 Commits 12 Branches 481 Tags 2.4 GiB
e8ebb663cc
Commit Graph

77 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
63e6410728
Refactor the DbTableExists class 
- Changes static methods to instance methods
- Extract response handling to the controllers
- Add unit tests for the DbTableExists class
- Remove the AbstractController::hasDatabase() method

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-06 01:42:06 -03:00
Kamil Tekiela
0be1d58b62 Move the code around 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-07 13:46:26 +01:00
Kamil Tekiela
ed586ac9cb Remove report_export param 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-07 13:46:26 +01:00
Kamil Tekiela
a89cedbed9 Fix bug introduced cca381a 
cca381a415

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-07 13:46:26 +01:00
Kamil Tekiela
8e88585f69 Merge if statements 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-07 13:46:26 +01:00
Kamil Tekiela
74a0c26129 Create DTO for TrackedData 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-07 13:46:26 +01:00
Kamil Tekiela
ce35872738 Reload data instead of modifying in place 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-06 00:01:11 +01:00
Kamil Tekiela
57f4fa7583 Remove $GLOBALS['msg'] 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-06 00:01:11 +01:00
Kamil Tekiela
62bd41870f Remove $GLOBALS['entries'] 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-06 00:00:49 +01:00
Kamil Tekiela
4f0a618187 Remove useless assignment 
Psalm incorrectly complains.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

sa
 2023-04-06 00:00:49 +01:00
Kamil Tekiela
15885ea495 Remove $GLOBALS['filter_users'] 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-05 17:34:46 +01:00
Kamil Tekiela
711cb95264 Remove $_POST 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-05 17:25:05 +01:00
Kamil Tekiela
bca99f1e4d Remove deleteTrackingReportRows() 
It's a hyperlink so it can't be both.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-05 17:05:50 +01:00
Kamil Tekiela
218d59c661 Move getTrackedData to Tracking 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-04 23:13:18 +01:00
Maurício Meneghini Fauth
e5698c85e9
Require single line for function calls 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-26 23:10:10 -03:00
Maurício Meneghini Fauth
802d8f13b6
Merge pull request #18203 from kamil-tekiela/first-class-callable 
Use first class callables
 2023-03-25 15:16:07 -03:00
Kamil Tekiela
8eb023bcce Remove last public use of Tracker::isTracked 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 22:36:25 +00:00
Kamil Tekiela
ebbf2e8d01 Remove unused params 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 22:35:34 +00:00
Kamil Tekiela
c0b367cc57 Create Tracking namespace 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 22:35:32 +00:00
Kamil Tekiela
3774c29604 Fix implicit nulls 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 12:45:18 +00:00
Kamil Tekiela
555c6798eb Add native param types 
Includes TypeHints.UnionTypeHintFormat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 12:45:18 +00:00
Kamil Tekiela
e71b8c2030 Use first class callables 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-02 23:00:43 +00:00
Maurício Meneghini Fauth
556594b4cd
Fix coding standard spacing issues 
- Fixes one line doc comments
- Fixes parent call spacing
- Fixes constant spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 21:06:17 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 20:48:46 -03:00
Maurício Meneghini Fauth
785f8c1c00
Use constructor property promotion where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 19:39:02 -03:00
Maurício Meneghini Fauth
613678f8f5
Replace assignments with null coalesce equal operator 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 17:03:05 -03:00
Kamil Tekiela
8433f66447 Remove unused variable in catch 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-14 12:10:23 +00:00
Kamil Tekiela
8a1d6f1eaa Convert var annotations to typed properties 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-12 21:31:04 +00:00
Maurício Meneghini Fauth
5df50f6a11
Refactor Tracking export download to remove exit 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-10 16:18:26 -03:00
Maurício Meneghini Fauth
a1c8769fab
Refactor $dateFrom and $dateTo to use DateTimeImmutable 
Uses the DateTimeImmutable object to validate the datetime values of the
$dateFrom and $dateTo variables in the Tracking class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-07 16:50:18 -03:00
Maurício Meneghini Fauth
d9fcd3555b
Remove filter_ts_* global variables 
Replaces them with $dateFrom and $dateTo variables.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-07 16:03:22 -03:00
Maurício Meneghini Fauth
17d9855420
Remove $_POST variables from Table\TrackingController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-06 14:25:09 -03:00
Maurício Meneghini Fauth
4044c3bc3c
Remove unnecessary global variable 'data' 
Replaces it with a regular varible.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-06 13:22:46 -03:00
Maurício Meneghini Fauth
789a7e441d
Remove usage of $_POST['logtype'] 
- Replaces with variable get from ServerRequest object
- Renames it log_type for readability

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-06 11:45:07 -03:00
Maurício Meneghini Fauth
0f2ff29d9d
Remove tracking's selection_* global variables 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-05 17:24:18 -03:00
Maurício Meneghini Fauth
db75ac370d
Add method to validate logtype request param 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-05 16:46:48 -03:00
Maurício Meneghini Fauth
0cc6340d29
Fix error after #17819 merge 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-05 15:37:45 -03:00
Kamil Tekiela
959849f446
Introduce ServerRequest::hasBodyParam() (#17870) 
* Drop Sql::setUiProp()
* Remove ternary operator
* Improve array guard
* Remove redundant isset
* Implement hasBodyParam()
* Add has() and hasQueryParam()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-05 13:04:45 -03:00
Maurício Meneghini Fauth
4bd3a1c423
Fix some issues and update SA baselines 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-29 17:27:51 -03:00
Luca Perna
4540d6ead0
Ref #16276 - Reduce the usage of SuperGlobals in Tracking and UserPassword (#17820) 
* 16276 - Reduce the usage of SuperGlobals in Tracking and UserPassword

Signed-off-by: Luca Perna <luca@perna.rocks>

* 16276 - minor code style refactorings

Signed-off-by: Luca Perna <luca@perna.rocks>

Signed-off-by: Luca Perna <luca@perna.rocks>
Co-authored-by: Luca Perna <luca@perna.rocks>
 2022-10-29 13:24:19 -03:00
Luca Perna
cca381a415
#17769 Use ServerRequest Object to access POST-vars (#17819) 
* 17769 - use Request object instead of SuperGlobals

Signed-off-by: Luca Perna <luca@perna.rocks>
 2022-10-29 11:57:47 -03:00
Luca Perna
d1b5cb6987
16276 - Reduce the usage of SuperGlobals (#17795) 
Signed-off-by: Luca Perna <luca@perna.rocks>
 2022-10-20 01:52:38 -03:00
Maurício Meneghini Fauth
4bda7899ab
Fix coding standard issues after #17794 merge 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-14 08:44:52 -03:00
Luca Perna
40adf927c5
Move superglobals access to controllers (#17794) 
Related to #16276

Signed-off-by: Luca Perna <luca@perna.rocks>
 2022-10-14 08:34:42 -03:00
Maurício Meneghini Fauth
3c618c22a9
Add ServerRequest parameter to all controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-28 01:00:08 -03:00
Maurício Meneghini Fauth
f5d738db59
Move input.sqlbutton event listener to sql.js file 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-19 16:48:10 -03:00
Maurício Meneghini Fauth
5950693fb3
Fix possible undefined globals 
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
f940693c75
Move Util::checkParameters method to the AbstractController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 22:59:33 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
5a34a3bb04
Remove db and table properties from controllers 
Replaces them with their respective globals.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-02 14:48:43 -03:00