Commit Graph

39 Commits

Author SHA1 Message Date
Michal Čihař
a6a78a2517 Merge branch 'QA_4_6' 2016-06-17 14:22:51 +02:00
Michal Čihař
61b4e28faf Sanitize page and formset before using
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-17 14:21:53 +02:00
Michal Čihař
dce94f229f More consistency for URL::getCommon
Now URL::getCommon always returns HTML encoded string, if you want
unencded one, use URL::getCommonRaw. This makes it easier to review the
code if uses correct variant.

Also I've fixed several wrong uses of the HTML encoded variant in
Location header.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-17 12:44:29 +02:00
Durgesh
0b64827930 Refactored url parmeters generating, Issue #11990
Signed-off-by: Durgesh <007durgesh219@gmail.com>
2016-02-22 14:36:41 +05:30
Marc Delisle
06d22e636e Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-07 09:41:46 -05:00
Marc Delisle
9ee3931c09 Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-03 10:43:10 -05:00
Hugues Peccatte
e5e447e937 Set namespace on config classes.
Update config classes.
Add @noinspection tag.
Update documentation and script.
Set ConfigGenerator in a namespace.
Rename ConfigGenerator filename.
Remove ConfigGenerator requires.
Fix namespaces of mock objects.
Remove useless require.
Add missing 'use'.
Add missing require.
Update PHPDoc.
Fix class test typo.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:23 +02:00
Dan Ungureanu
91b97fadc2 Remove unneeded closing tags.
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
2015-07-19 00:18:38 +03:00
Madhura Jayaratne
31c21b070a Adding token would not harm
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-05-15 07:25:36 +05:30
Nisarg Jhaveri
431847b39e Return HTML instead of echo-ing directly in FormDisplay
Signed-off-by: Nisarg Jhaveri <nisargjhaveri@gmail.com>
2015-05-15 00:56:26 +05:30
Madhura Jayaratne
3addba490c Do not break the urls in the middle. Update tests
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-05-14 08:09:43 +05:30
Madhura Jayaratne
d6afe6ccf6 bug #4899 [security] CSRF vulnerability in setup
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-05-13 11:28:19 -04:00
Marc Delisle
b809e36836 Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-03-03 08:10:24 -05:00
Hugues Peccatte
6b01f835cb Rename too short variables.
Remove useless initializations.
Rename too long variables.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-01-04 20:46:18 +01:00
Marc Delisle
17b370248e Fix typos
Signed-off-by: Marc Delisle <marc@infomarc.info>
2013-12-28 06:33:07 -05:00
Hugues Peccatte
ef49eff205 Standardize names of functions.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2013-12-27 13:49:57 +01:00
Hugues Peccatte
bf3ce05675 Reduce nested levels.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2013-12-26 21:06:19 +01:00
Piotr Przybylski
a67e41a646 Refactored ConfigFile class so that it is no longer a singleton
Fixes bug #4123 Double config including
2013-11-03 12:54:20 +01:00
Michal Čihař
0a3d1d5be8 Better names for URL generating functions 2013-08-07 10:58:17 +02:00
ayushchd
a39b7330f6 Remove debug message 2013-07-11 22:50:53 +05:45
ayushchd
f7e9e262c1 Tests for setup/* and user_prefs* 2013-07-11 13:59:49 +05:45
Michal Čihař
3e050ff9d9 Various docblocks improvements 2012-09-19 15:05:26 +02:00
Dieter Adriaenssens
43b41a8cbb cleanup package tags 2012-03-14 15:37:36 +01:00
Michal Čihař
e56949f160 Use package name PhpMyAdmin
Needed to match phpdoc rules as package name must begin with upper case.
2011-10-25 10:13:17 +02:00
Michal Čihař
1ec0b69e6b Coding style, function definitions 2011-08-05 14:49:23 +02:00
Michal Čihař
d55306252b Replace tabs with spaces, cleanup identation 2011-07-22 10:15:08 +02:00
Marc Delisle
baf339f802 Continue to replace warning level with error level 2011-05-04 06:14:28 -04:00
Michal Čihař
d17fba309c Fix permissions.
Most files were made executable somewhere in ninadsp tree, reverting
this.
2010-08-30 09:53:37 +02:00
ninadsp
9c34a0eec9 Merged branch official/master. Resolved merge conflicts introduced due to merging of Piotr and Martynas's branches 2010-08-28 01:53:52 +05:30
Crack
4a5ffa7a12 File comments:
- remove @license and @version from comments
- add vim settings
- change descriptions in form definition files
2010-08-03 00:55:57 +02:00
Crack
d63fa35c0f finished messages.inc.php cleanup 2010-07-04 00:18:04 +02:00
Crack
a90b0a21f2 removed some messages from messages.inc.php (validation, some other error messages)
User preferences:
added translations and values for some fields
validation for DefaultPropDisplay
2010-06-13 15:01:37 +02:00
ninadsp
bed1948d04 testing git setup - no major change made in code yet
only added a few comments
2010-05-23 01:22:01 +05:30
Marc Delisle
25f7b89443 gettext conversion 2010-05-14 12:43:23 -04:00
Marc Delisle
819324ede6 remove author names, as discussed at the 2010 developer meeting and according to the book Producing Open Source Software 2010-03-06 18:04:17 +00:00
Piotr Przybylski
cd9da66ffb Setup script: move language strings to global variables, prefix them with "$strSetup" 2008-10-14 10:31:07 +00:00
Piotr Przybylski
38734a3e16 Setup script:
- language strings cleanup
- removed import defaults
- add query window default tab setting
- added checks for zip/gzip/bzip avability
- fixed error icon
2008-10-09 16:39:45 +00:00
Marc Delisle
c930d2bd4f patch #209978, missing svn:eol-style 2008-09-10 16:53:28 +00:00
Piotr Przybylski
5c658310aa new setup script (Google Summer of Code 2008), work in progress 2008-08-28 18:02:18 +00:00