gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
125,116 Commits 12 Branches 481 Tags 2.4 GiB
ea302e792d
Commit Graph

1131 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
f6ce169290
Fix issue when updating privs for various databases 
The sql_query global variable should be a string, and it can be a string
in this case, which will cause an error as the string will not be
converted to array.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2024-11-05 15:09:21 -03:00
Maurício Meneghini Fauth
12efd0a0fe
Replace replication statements with new terminology 
SHOW MASTER LOGS was removed in MySQL 8.4.0 and SHOW BINARY LOGS is
available since MySQL 4.1.1.

As of MySQL 8.2.0, SHOW BINARY LOG STATUS is available.
As of MariaDB 10.5.2, SHOW BINLOG STATUS is available.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2024-10-31 13:50:11 -03:00
Maurício Meneghini Fauth
587d185bb7
Validate *_structure_or_data param when exporting 
- Fixes #19213

This is not the best fix, but will avoid generating an invalid file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-07-18 16:07:46 -03:00
Maurício Meneghini Fauth
4f67631d48
Fix undefined variables in table/zoom_search/result_form.twig 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-06-22 17:34:21 -03:00
Maximilian Krög
3b84890770
Fix simulating query with -- comment 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2024-06-01 00:58:42 +02:00
Maximilian Krög
6d917b5b7f
Fix simulate multiple queries with ; in a string 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2024-06-01 00:16:35 +02:00
Faissal Wahabali
de7a96467f
Fix notification links (#18243) 
* fix not working notification copy link

Signed-off-by: faissaloux <fwahabali@gmail.com>

* fix not working notification links

Signed-off-by: faissaloux <fwahabali@gmail.com>

* fix notification links tooltip messages

Signed-off-by: faissaloux <fwahabali@gmail.com>

* update Edit Query message

Signed-off-by: faissaloux <fwahabali@gmail.com>

* remove unused event param

Signed-off-by: faissaloux <fwahabali@gmail.com>

* refactor

Signed-off-by: faissaloux <fwahabali@gmail.com>

* revert Edit Query message

Signed-off-by: faissaloux <fwahabali@gmail.com>

* refactor

Signed-off-by: faissaloux <fwahabali@gmail.com>

* code style

Signed-off-by: faissaloux <fwahabali@gmail.com>

* refactor

Signed-off-by: faissaloux <fwahabali@gmail.com>

---------

Signed-off-by: faissaloux <fwahabali@gmail.com>



Fixes #18241

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-04-30 16:08:56 -03:00
Mattia Rizzolo
3dfaed3554
Fix inverted logic hide serverlist (#18021) 
* Reflow lines to arguably better understand the logic

There are a bit too many branch in this single line..

Signed-off-by: Mattia Rizzolo <mattia@mapreri.org>

* Fix inverted logic in the serverlist in the home page

Here the server list was visible when it wasn't supposed to be, and
hidden when it was supposed to be visible.

Signed-off-by: Mattia Rizzolo <mattia@mapreri.org>

---------

Signed-off-by: Mattia Rizzolo <mattia@mapreri.org>

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-04-29 21:21:36 -03:00
William Desportes
892dda0f04
Fix #19041 - footer.twig gets printed to Binary File Download 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2024-04-28 17:18:43 +02:00
William Desportes
0bcc3e402d
Merge #19105 - Fix #17920, Fix #18006, Fix #18962 - Preserve check constraint during column move 
Pull-request: #19105
Fixes: #17920
Fixes: #18006
Fixes: #18962

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2024-04-28 10:46:15 +02:00
William Desportes
40d5b6dd57
Merge #19135 - Fix #18389, Fix #18487, Fix #18511 - Fix linter for sql query box with multiple statements 
Pull-request: #19121
Fixes: #18389
Fixes: #18487
Fixes: #18511

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2024-04-28 10:37:57 +02:00
Maximilian Krög
d5e0d711bd
Fix linter annotations for special editors 
When the sql string to lint isa changed, the result positions
need to be adjusted accordingly.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2024-04-22 21:42:36 +02:00
Maximilian Krög
02ebd6c5b0
Fix linting in sql editor with delimiter 
Always setting the delimiter to $$ is not right in normal sql editor.
This breaks usage of the default delimiter ; and using DELIMITER in the sql.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2024-04-21 16:01:26 +02:00
Maximilian Krög
26fc8f1b9e
Fix editing column where only virtuality changed 
Without this the column wasn't detected as changed and thus not
included in the alter statement.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2024-04-21 15:30:31 +02:00
Maximilian Krög
3b992e6a13
Preserve check constraint during column move 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2024-04-19 22:01:43 +02:00
Peter de Kraker
10a8943cfc
Add RocksDB support 
Signed-off-by: Peter de Kraker <peterdekraker@umito.nl>
 2024-03-15 20:13:58 -03:00
Maurício Meneghini Fauth
2b1f21ef07
Remove unused parameter from Table\StructureController::displayStructure 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-02-21 21:05:48 -03:00
Maurício Meneghini Fauth
4d20a8b7e3 Change error message link in ChangeLogController 
Uses URL redirector instead of a direct link in the error message.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-01-04 19:00:27 -03:00
Kamil Tekiela
7652f018aa Fix #17538 Index Rename Button generated incorrect sql 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-28 00:25:10 +01:00
Maurício Meneghini Fauth
6503321278
Fix case where column hash is empty in table relation page 
- Fixes #18834
- Related to #14305

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-12-08 16:57:12 -03:00
Liviu-Mihail Concioiu
bd9aa34013 Adds missing dot in translations 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2023-12-03 00:36:12 +02:00
Maurício Meneghini Fauth
99168688a7
Add ChangeLog entry for #15670 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-11-17 13:15:38 -03:00
Bram Stokman
d2c153d557
Update Table SaveController.php - bug fix (#18724) 
* Update SaveController.php - bug fix

Fix for possible truncation of data upon changing a MEDIUMTEXT or LONGTEXT column's collation when their content exceeds the length a BLOB column can hold.

* Update SaveController.php - bug fix

Signed-off-by: Bram Stokman <marbbom@hotmail.com>

* Fixed spacing

Signed-off-by: Bram Stokman <marbbom@hotmail.com>

---------

Signed-off-by: Bram Stokman <marbbom@hotmail.com>
 2023-11-17 12:38:40 -03:00
Maurício Meneghini Fauth
5cba58c82e
Fix truncate operation in EmptyTableController 
- Fixes https://github.com/phpmyadmin/phpmyadmin/issues/18762

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-11-12 15:05:35 -03:00
Maurício Meneghini Fauth
5c7e84047e
Merge pull request #18693 from kamil-tekiela/parseEnumSetValues_52 
Fix enum/set value escaping
 2023-10-03 16:54:56 -03:00
Maurício Meneghini Fauth
5e8ec69240
Improve git hash info error handling in home.js 
Instead of showing a generic error message alert when an error occurs,
it displays an error message at the same place where the success output
goes.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-09-20 14:14:28 -03:00
Maurício Meneghini Fauth
b06c773360
Merge pull request #18713 from MoonE/fix-column-type-lost 
Fix gis editor changing geometry type and opening in search views
 2023-09-20 11:22:26 -03:00
Kamil Tekiela
dba0086b90 Fix AJAX real-row-count 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-09-15 21:01:15 +01:00
Maximilian Krög
4bd6a2dd52
Fix opening GIS editor in zoom search 
The editor couldn't be opened there at all

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-09-15 00:36:02 +02:00
Maximilian Krög
5128da0071
Remember the current column type 
After switching the geometry type once the geometry select disappeared.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-09-14 22:58:23 +02:00
Kamil Tekiela
94eee04d50 Remove htmlentities() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-09-05 18:12:38 +01:00
Maximilian Krög
3786b40499
Geometry type selection only for Geometry column type 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-08-26 21:59:06 +02:00
Maximilian Krög
62db67a47c
Show affected rows instead of matched rows in SimulateDml 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-08-26 21:35:44 +02:00
William Desportes
7c975030b9
Fix #18592 - Remove instruction to remove the pma_collation_connection cookie removed in 4.8.0 
Ref: 3b6a994dcd
Fixes: #18592

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-08-03 15:00:19 +02:00
Kamil Tekiela
fb2953c487 Force string as return type of showCreate() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-07-24 19:45:24 +01:00
William Desportes
8b4a158a1b
Ref #16005 - Remove loading on each request favorites and recents 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-07-14 17:47:30 +02:00
William Desportes
d1019373ce
Fix route /database/structure/favorite-table - it does not require a db name 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-07-14 17:47:25 +02:00
Liviu-Mihail Concioiu
4951bc7fea Update CVE link with the new one 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2023-05-06 01:06:11 +02:00
William Desportes
99881debb5
Fix lint route not working correctly 
Related to 5a2baf607f
Related to https://github.com/phpmyadmin/sql-parser/pull/438

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-04-22 14:52:35 +02:00
Maurício Meneghini Fauth
3e7cf7cfab
Fix failing RelationTest test 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-12 16:35:28 -03:00
Maurício Meneghini Fauth
8c7c87f524
Merge pull request #18308 from win20/navigation-panel-settings-icon-issues 
Fix issues with settings icon in nav panel
 2023-04-12 16:17:48 -03:00
MoonE
0ff3f10134
Fix editing GEOMETRYCOLLECTION EMPTY (#18189) 
* Test editing empty geometry collection

- 'GEOMETRYCOLLECTION()'
- 'GEOMETRYCOLLECTION EMPTY'

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>

* Fix editing GEOMETRYCOLLECTION EMPTY

Instead of searching for first parenthesis look for word end.
Parsing was and is somewhat unsafe, though it works with the data
received from ST_AsText.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>

---------

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-04-08 15:12:40 -03:00
William Desportes
4cec0f1163
Stop pmadb database detection when all features are disabled 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-04-08 13:42:44 +02:00
Win Barua
a067418124 Fix issues with settings icon in nav panel 
- settings icon still shows in 2FA in all themes.
- bootstrap theme still shows settings icon on all settings tabs.

Signed-off-by: Win Barua <win.barua2@gmail.com>
 2023-04-01 14:47:50 +01:00
Kamil Tekiela
b5ae50454d Optimize getTrackingIcon 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-22 13:07:22 +00:00
Kamil Tekiela
7b20f58a0c Bug: IS NULL is shown for non-nullable columns 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-27 23:17:53 +00:00
William Desportes
24ac923632
Fix Internal error in ./libraries/classes/Controllers/HomeController.php#314 
TypeError: mb_strlen(): Argument #1 ($string) must be of type string, bool given

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-22 12:47:59 +01:00
Kamil Tekiela
69f7a915eb Replace getTablesFull with getTables 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-18 14:33:41 +00:00
William Desportes
9d92dafdcb
Merge #17923 - Fix #17766 - Allow to open in a new tab copy and edit row actions 
Pull-request: #17923
Fixes: #17766

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-08 13:13:39 +01:00
William Desportes
305fe52d9e
Fix #18019 - Error: "Call to a member function fetchAssoc() on bool" with SQL mode ONLY_FULL_GROUP_BY 
Fixes: #18019

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-01-20 19:36:52 +04:00